If a more recent revision/autosave exists, store its state on editor setup by talldan · Pull Request #7945 · WordPress/gutenberg

talldan · 2018-07-13T05:06:06Z

Attempts to resolve an issue whereby the editor is unaware of the existence of
a more recent autosave, resulting in attempts to perform an autosave fail.

Description

This PR results in autosave state being fetched when the editor loads (via a resolver). This request is preloaded (will require a core patch). Changes include:

Migration of autosave state from '@wordpress/editor' to '@wordpress/core-data'.
Addition of resolver for 'getAutosave' selector.
Disabling of the preview button until autosave state is fetched.
Deprecation of old selectors/actions

How has this been tested?

Manual testing - follow the steps in Saving: Autosaveable does not account for autosave existing at start of editing #7416
Added unit tests

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

My code is tested.
My code follows the WordPress code style.
My code follows the accessibility standards.
My code has proper inline documentation.

lib/client-assets.php

youknowriad · 2018-08-30T09:01:36Z

This seems an important bug to fix, but I'm moving to 3.8 for now as it doesn't seem ready.

aduth · 2018-11-08T21:55:46Z

There's quite a bit which has since been changed in affected code here, for which I'm largely to blame (both for the changes and neglecting to review this sooner). Let me know if there's anything I can do to help with bringing this back up to date.

talldan · 2018-11-12T11:14:53Z

@aduth - I've rebased it. I ended up dropping a couple of commits that didn't seem relevant any more. They seem to have been fixed since.

My understanding is that if we want to introduce this, the PHP code will need to patched into core. Is that right?

aduth · 2018-11-12T13:45:00Z

Yes, and there may be some conflict to anticipate between this and the changes introduced to core as part of Trac#45194 (specifically 43833), which doesn't appear to have yet been ported back to the plugin (cc @imath @danielbachhuber).

danielbachhuber · 2018-11-12T13:47:30Z

the changes introduced to core as part of Trac#45194 (specifically 43833), which doesn't appear to have yet been ported back to the plugin

It's still a WIP on #4155

…Selector

…t been fetched from the REST API

…of patch version

Co-Authored-By: talldan <daniel.p.richards@gmail.com>

talldan · 2019-04-16T09:55:36Z

@aduth - have fixed that issue with receiveAutosaves. I've also updated the deprecation versions, so hopefully everything is good 👍

aduth · 2019-04-17T21:11:23Z

This request is preloaded (will require a core patch).

Is this still the case? I don't see any PHP file edits included.

Is it possible that due to an earlier rebase where we'd been relying on redundant code in client-assets.php to specify the preload paths, it was removed in a rebase?

If we need it, we should filter block_editor_preload_paths. And if it requires a core patch, we should follow-up with a corresponding Trac ticket.

aduth

Thanks for the patience in delayed reviews. Nice work on this one 👍

Consider my prior comment as far as whether we should be preloading this path. I don't consider it a blocker since the preloading is more an optimization, but I'll leave it to you whether we should include it.

talldan · 2019-04-18T03:35:43Z

Thanks so much for you guidance, @aduth! This one has been through a few iterations, but feels good to finally get it merged.

I'll work on some follow-ups for the preloading.

noisysocks · 2019-04-18T03:38:31Z

10 months and 5 days—that must be a record! 😀👏

talldan · 2019-04-18T10:16:10Z

@aduth here's a ticket with a patch for adding the preloading:
https://core.trac.wordpress.org/ticket/46974

aduth · 2019-04-18T14:36:17Z

@aduth here's a ticket with a patch for adding the preloading:
https://core.trac.wordpress.org/ticket/46974

👍

Depending if you think it's important, we could also introduce a filter in the Gutenberg plugin ahead of this being patched in core.

talldan · 2019-04-19T06:08:38Z

Depending if you think it's important, we could also introduce a filter in the Gutenberg plugin ahead of this being patched in core.

I'm not completely convinced it's needed, but I made a PR - #15067

talldan added [Type] Bug An existing feature does not function as intended [Feature] Saving Related to saving functionality labels Jul 13, 2018

talldan self-assigned this Jul 13, 2018

talldan requested a review from aduth July 13, 2018 05:06

talldan mentioned this pull request Jul 13, 2018

Saving: Autosaveable does not account for autosave existing at start of editing #7416

Closed

aduth requested changes Jul 16, 2018

View reviewed changes

lib/client-assets.php Outdated Show resolved Hide resolved

talldan force-pushed the fix/initial-autosave-state branch from 73ed574 to 4c32e56 Compare July 20, 2018 06:15

This comment has been minimized.

Sign in to view

talldan force-pushed the fix/initial-autosave-state branch 2 times, most recently from f5f49f9 to 27b921b Compare July 23, 2018 05:08

talldan force-pushed the fix/initial-autosave-state branch 2 times, most recently from 40cb6ab to 847c699 Compare September 4, 2018 08:38

talldan added the [Status] In Progress Tracking issues with work in progress label Sep 6, 2018

talldan force-pushed the fix/initial-autosave-state branch 2 times, most recently from 68791dd to 2af62da Compare September 7, 2018 14:21

This comment has been minimized.

Sign in to view

talldan force-pushed the fix/initial-autosave-state branch 2 times, most recently from 53a19b0 to 9e1a31b Compare September 25, 2018 17:49

This comment has been minimized.

Sign in to view

talldan mentioned this pull request Oct 10, 2018

Add end 2 end test: should not revert title during a preview right after a save draft #7953

Merged

talldan added Needs Technical Feedback Needs testing from a developer perspective. and removed [Status] In Progress Tracking issues with work in progress labels Oct 11, 2018

talldan force-pushed the fix/initial-autosave-state branch from e44f855 to 8cb8fe3 Compare November 12, 2018 11:02

aduth added the REST API Interaction Related to REST API label Nov 12, 2018

talldan and others added 13 commits April 16, 2019 17:35

Undeprecate isEditedPostAutosaveable, update tests to handle registry…

a5cc963

…Selector

Update changelog and deprecation version numbers

3db52af

Update docs

0179088

Add JSDocs for currentUser reducer

b67a7c1

Minor renaming of functions/props

95dfdb2

Update deprecation version for action

d7c599a

Change PostPreviewButton prop back to isSaveable.

f5a47f5

Do not consider a post autosaveable if existing autosaves have not ye…

c523c23

…t been fetched from the REST API

Use undefined as the fallback when no currentUser is fetched

ac04601

Move changelog entries to unreleased section, and bump minor instead …

a046d29

…of patch version

Allow single or multiple autosaves to be passed to receiveAutosaves

52cce02

Update deprecation versions

aa0c408

Use REDUCER_KEY as arg to select

e16f74c

Co-Authored-By: talldan <daniel.p.richards@gmail.com>

Update docs

1e5a4b7

aduth approved these changes Apr 17, 2019

View reviewed changes

talldan mentioned this pull request Apr 19, 2019

Add preload paths for autosaves #15067

Merged

5 tasks

This was referenced Apr 29, 2019

Bump version number to 5.6.0-rc.1 #15248

Merged

Bump version number to 5.6.0 #15373

Merged

glendaviesnz mentioned this pull request Aug 19, 2019

FSE: Pages with autosaves cannot be previewed [2] Automattic/wp-calypso#35484

Closed

Conversation

talldan commented Jul 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How has this been tested?

Types of changes

Checklist:

Uh oh!

Uh oh!

This comment has been minimized.

youknowriad commented Aug 30, 2018

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

aduth commented Nov 8, 2018

Uh oh!

talldan commented Nov 12, 2018

Uh oh!

aduth commented Nov 12, 2018

Uh oh!

danielbachhuber commented Nov 12, 2018

Uh oh!

talldan commented Apr 16, 2019

Uh oh!

aduth commented Apr 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aduth left a comment

Choose a reason for hiding this comment

Uh oh!

talldan commented Apr 18, 2019

Uh oh!

noisysocks commented Apr 18, 2019

Uh oh!

talldan commented Apr 18, 2019

Uh oh!

aduth commented Apr 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

talldan commented Apr 19, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

talldan commented Jul 13, 2018 •

edited

Loading

aduth commented Apr 17, 2019 •

edited

Loading

aduth commented Apr 18, 2019 •

edited

Loading