Remove findDOMNode usage from the inserter#11363
Conversation
jorgefilipecosta
left a comment
There was a problem hiding this comment.
Hi @youknowriad in my tests this is working correctly 👍
Normally we use createRef() to initilize the references would this apporach be equivalent:
|
|
||
| exports[`PanelColorSettings should render a color panel if at least one setting specifies some colors to choose 2`] = ` | ||
| <PanelBody | ||
| <[object Object] |
There was a problem hiding this comment.
I wonder why the displayName we set is not being used here.
There was a problem hiding this comment.
Probably an enzyme bug :)
|
@jorgefilipecosta I don't know if it's equivalent. In general the |
That's true, nothing says it must be initialized in the constructor but your approach seems safer. |
…rnmobile/port-quote-block-step-1 * 'master' of https://github.com/WordPress/gutenberg: (22 commits) Add removed periods to block descriptions. (#11367) Remove findDOMNode usage from the inserter (#11363) Remove deprecated componentWillReceiveProps from TinyMCE component (#11368) Create file blocks when dropping multiple files at once (#11297) Try avoiding the deprecated findDOMNode API from DropZone Provider (#11168) Fix: make meta+A behaviour of selecting all blocks work on safari and firefox. (#8180) Remove _wpGutenbergCodeEditorSettings and wp.codeEditor assets (#11342) Remove the Cloudflare warning (#11350) Image Block: Use source_url for media file link (#11254) Enhance styling of nextpage block using the Hr element (#11354) Embed block refactor and tidy (#10958) Nonce Middleware: Wrap the nonce middleware function into it's own function that isn't regenerated on every API request. (#11347) Fix RTL block alignments (#11293) RichText: fix buggy enter/delete behaviour (#11287) Remove code coverage setup (#11198) Parser: Runs all parser implementations against the same tests (#11320) Stop trying to autosave when title and classic block content both are empty. (#10404) Fix "Mac OS" typo + use fancy quotes consistently (#11310) Update documentation link paths (#11324) Editor: Reshape blocks state under own key (#11315) ... # Conflicts: # gutenberg-mobile
Related #11360
This PR leverages
forwardRefto removefindDOMNodeusage from the inserter. The idea is that you canrefaPanelBodycomponent and you get the inner div instead. It's a small breaking change but since we never documentedrefas a public prop forPanelBodyI don't expect this to break anything.