Nonce Middleware: Wrap the nonce middleware function into it's own function.#11347
Merged
earnjam merged 1 commit intoWordPress:masterfrom Nov 1, 2018
Merged
Nonce Middleware: Wrap the nonce middleware function into it's own function.#11347earnjam merged 1 commit intoWordPress:masterfrom
earnjam merged 1 commit intoWordPress:masterfrom
Conversation
…nction that isn't regenerated on every API request. This allows the nonce to be updated during pageloads.
Contributor
|
I'll defer to @youknowriad since he wrote this code initially, but just wanted to note this is working well for me and appears to resolve the nonce issue. It also stopped the hook from firing multiple times per heartbeat tick. Without this patch I was seeing it firing ~7 times per tick after just an initial load of the editor and not doing anything. |
Contributor
I don't think the middleware function was regenerated by each API call, I'd say, the hook function was which is not great indeed. |
youknowriad
approved these changes
Nov 1, 2018
Contributor
youknowriad
left a comment
There was a problem hiding this comment.
Code changes look good to me 👍 And since others have tested, let's ship.
Member
|
Thanks @dd32 ! |
daniloercoli
added a commit
that referenced
this pull request
Nov 1, 2018
…rnmobile/port-quote-block-step-1 * 'master' of https://github.com/WordPress/gutenberg: (22 commits) Add removed periods to block descriptions. (#11367) Remove findDOMNode usage from the inserter (#11363) Remove deprecated componentWillReceiveProps from TinyMCE component (#11368) Create file blocks when dropping multiple files at once (#11297) Try avoiding the deprecated findDOMNode API from DropZone Provider (#11168) Fix: make meta+A behaviour of selecting all blocks work on safari and firefox. (#8180) Remove _wpGutenbergCodeEditorSettings and wp.codeEditor assets (#11342) Remove the Cloudflare warning (#11350) Image Block: Use source_url for media file link (#11254) Enhance styling of nextpage block using the Hr element (#11354) Embed block refactor and tidy (#10958) Nonce Middleware: Wrap the nonce middleware function into it's own function that isn't regenerated on every API request. (#11347) Fix RTL block alignments (#11293) RichText: fix buggy enter/delete behaviour (#11287) Remove code coverage setup (#11198) Parser: Runs all parser implementations against the same tests (#11320) Stop trying to autosave when title and classic block content both are empty. (#10404) Fix "Mac OS" typo + use fancy quotes consistently (#11310) Update documentation link paths (#11324) Editor: Reshape blocks state under own key (#11315) ... # Conflicts: # gutenberg-mobile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The nonce middleware function is re-generated on every API call, which is causing the initial nonce to always be used and the
addAction()to be queued up multiple times.Splitting this up and returning a function here solves both of the problems, and should fix #9260
How has this been tested?
To test, Set the nonce_life to 60s and have heartbeat run every 20s.
Use the editor for >2minutes (Switching images around works), you shouldn't encounter update failed messages, and the console should be clear.