Improve preloading request code#11007
Merged
danielbachhuber merged 1 commit intomasterfrom Oct 25, 2018
Merged
Conversation
This removes the conditional branching based on the existence of the `get_compact_response_links()` method on the `$server` object, as that method was introduced with WordPress 4.5, and Gutenberg requires WordPress 4.9.8 or later. Also, it turns the indirect and slow call through `call_user_func()` into a direct method call. Note: The call would actually be more correct as a static call (`$server::get_compact_response_links( $response)`), but this notation is PHP 5.3+ only.
danielbachhuber
approved these changes
Oct 25, 2018
Member
danielbachhuber
left a comment
There was a problem hiding this comment.
👍 Want to submit a core patch for this too?
Member
Author
antpb
pushed a commit
to antpb/gutenberg
that referenced
this pull request
Oct 26, 2018
This removes the conditional branching based on the existence of the `get_compact_response_links()` method on the `$server` object, as that method was introduced with WordPress 4.5, and Gutenberg requires WordPress 4.9.8 or later. Also, it turns the indirect and slow call through `call_user_func()` into a direct method call. Note: The call would actually be more correct as a static call (`$server::get_compact_response_links( $response)`), but this notation is PHP 5.3+ only.
daniloercoli
added a commit
that referenced
this pull request
Oct 26, 2018
…rnmobile/merge-blocks-on-backspace * 'master' of https://github.com/WordPress/gutenberg: Do not add isDirty prop to DOM (#11093) Format API (#10209) Remove 4.2 deprecated features (#10952) Update `@wordpress/hooks` README to include namespace mention (#11061) Feature: save lock control via actions (#10649) Fix usage of `preg_quote()` (#10998) Update plugin version to 4.1.1 (#11078) Improve preloading request code (#11007) Fix dynamic blocks not rendering in the frontend (#11050) Media & Text: Fixing vertical alignment of the image (#11025) Date: Mark getSettings as experimental (#10636) Improve handling of centered 1-col galleries with small images (#11040) Use better help text for ALT text input; fixes #8391. (#11052) # Conflicts: # packages/editor/src/components/rich-text/index.native.js
Member
|
Thanks for the improvement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the conditional branching based on the existence of the
get_compact_response_links()method on the$serverobject, as that method was introduced with WordPress 4.5, and Gutenberg requires WordPress 4.9.8 or later.Also, it turns the indirect and slow call through
call_user_func()into a direct method call.Note: The call would actually be more correct as a static call (
$server::get_compact_response_links( $response)), but this notation is PHP 5.3+ only.