Skip to content

Remove 4.2 deprecated features#10952

Merged
youknowriad merged 7 commits intomasterfrom
update/remove-4-2-deprecations
Oct 26, 2018
Merged

Remove 4.2 deprecated features#10952
youknowriad merged 7 commits intomasterfrom
update/remove-4-2-deprecations

Conversation

@youknowriad
Copy link
Copy Markdown
Contributor

@youknowriad youknowriad commented Oct 23, 2018 •
edited
Loading

A lot of cleanup in this release, which is nice:

  • The webpack config is simpler
  • The data module is simpler

Todo

  • Update CHANGELOG
  • Remove useless tests
  • Remove useless package dependencies.

@youknowriad youknowriad added this to the 4.2 milestone Oct 23, 2018
@youknowriad youknowriad self-assigned this Oct 23, 2018
@youknowriad youknowriad requested a review from a team October 23, 2018 13:44
youknowriad
youknowriad commented Oct 23, 2018
View reviewed changes
packages/editor/src/utils/media-upload/media-upload.js Outdated
Copy link
Copy Markdown
Contributor Author

@youknowriad youknowriad Oct 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right change @jorgefilipecosta ?

aduth
aduth previously requested changes Oct 23, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving the red. ❤️

packages/blocks/src/api/test/parser.js Outdated
Copy link
Copy Markdown
Member

@aduth aduth Oct 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove jest.mock a few lines below as well.

youknowriad
youknowriad commented Oct 23, 2018
View reviewed changes
lib/client-assets.php Outdated
Copy link
Copy Markdown
Contributor Author

@youknowriad youknowriad Oct 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atimmer Some changes here to keep track of, for 4.2 merge to Core.

youknowriad
youknowriad commented Oct 23, 2018
View reviewed changes
packages/components/src/tab-panel/index.js Outdated
Copy link
Copy Markdown
Contributor Author

@youknowriad youknowriad Oct 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad to see this magic trick go :)

@aduth
Copy link
Copy Markdown
Member

aduth commented Oct 23, 2018

There appears to be a mobile test failure? cc @hypest

@hypest
Copy link
Copy Markdown
Contributor

hypest commented Oct 23, 2018

👋 , thanks for the ping @aduth . Yeah, the mobile test fails because setUnknownTypeHandlerName() is not found. I see that this PR deprecates that function so, good catch from the mobile tests I'd say :).

This should be easy to fix AFAICT. @youknowriad or @aduth , interested in filing a PR to the mobile repo to fix this? A good chance to get a PR merged to the mobile project with your name on it ;)
Let me know if you'd like me to wrangle this instead. In any case, this PR will need to update the mobile submodule ref to point to a master with the fix merged.

@youknowriad youknowriad mentioned this pull request Oct 24, 2018
Merged
@youknowriad youknowriad force-pushed the update/remove-4-2-deprecations branch from 2b4df44 to bca2ef3 Compare October 24, 2018 09:56
@youknowriad youknowriad mentioned this pull request Oct 24, 2018
Merged
@youknowriad youknowriad force-pushed the update/remove-4-2-deprecations branch from 6f62143 to 8c92c85 Compare October 24, 2018 11:15
@youknowriad youknowriad dismissed aduth’s stale review October 24, 2018 13:04

It should be ready now

aduth
aduth approved these changes Oct 25, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase, but otherwise 👍

@youknowriad youknowriad force-pushed the update/remove-4-2-deprecations branch from 8c92c85 to a26e0c9 Compare October 26, 2018 07:49
@youknowriad youknowriad merged commit 4e92ac3 into master Oct 26, 2018
@youknowriad youknowriad deleted the update/remove-4-2-deprecations branch October 26, 2018 08:59
daniloercoli added a commit that referenced this pull request Oct 26, 2018
@daniloercoli
Merge branch 'master' of https://github.com/WordPress/gutenberg into …
7659051 
…rnmobile/merge-blocks-on-backspace

* 'master' of https://github.com/WordPress/gutenberg:
  Do not add isDirty prop to DOM (#11093)
  Format API (#10209)
  Remove 4.2 deprecated features (#10952)
  Update `@wordpress/hooks` README to include namespace mention (#11061)
  Feature: save lock control via actions (#10649)
  Fix usage of `preg_quote()` (#10998)
  Update plugin version to 4.1.1 (#11078)
  Improve preloading request code (#11007)
  Fix dynamic blocks not rendering in the frontend (#11050)
  Media & Text: Fixing vertical alignment of the image (#11025)
  Date: Mark getSettings as experimental (#10636)
  Improve handling of centered 1-col galleries with small images (#11040)
  Use better help text for ALT text input; fixes #8391. (#11052)

# Conflicts:
#	packages/editor/src/components/rich-text/index.native.js
@aduth aduth mentioned this pull request Jun 25, 2019
Merged
@timmyc timmyc mentioned this pull request Jun 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduth aduth aduth approved these changes

Assignees

@youknowriad youknowriad

Labels

None yet

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

3 participants

@youknowriad @aduth @hypest