Lib directory rewrite handling#212
Merged
summerswallow-whi merged 8 commits intomasterfrom Feb 10, 2023
Merged
Conversation
… is handled when dealing with notebook generation.
summerswallow-whi
approved these changes
Feb 10, 2023
ceandrade
pushed a commit
to ceandrade/pyvis
that referenced
this pull request
Jul 10, 2025
Lib directory rewrite handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug that happens when the work directory has a lib folder specified by the user when using local resources. This causes the application to overwrite the local lib directory as outlined in this:
#174
issue.
This does some internal refactoring of the write_html function to better handle how the in_line, remote, and local asset generation is handled for the 3 modes to better control the functionality as well as not being as heavy handed when interacting with the lib directory.