Fix unnecessary webbrowser.open in network.save_graph#199
Closed
squidKid-deluxe wants to merge 1 commit intoWestHealth:masterfrom
Closed
Fix unnecessary webbrowser.open in network.save_graph#199squidKid-deluxe wants to merge 1 commit intoWestHealth:masterfrom
squidKid-deluxe wants to merge 1 commit intoWestHealth:masterfrom
Conversation
ceandrade
pushed a commit
to ceandrade/pyvis
that referenced
this pull request
Jul 10, 2025
… self.cdn_resources argument on how to actually generate the graph. Address WestHealth#199, WestHealth#175, WestHealth#189 by adding option to open web browser when the graphic is created. Updated warning message for notebook when writing the graphic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a network is saved to file by
network.save_graph(), the file should not show.If
pyvisis running in a headless environment, this creates a browser that has to be killed manually each time the HTML file is saved.For these cases, it is important the save_graph method does not open the browser using
webbrowser.open()and only does that when showing withnetwork.show().The commit to fix Issue #175 does not fix this problem, and Pull request #192 is incorrect.