Implement text-transform: math-auto. #51271

eerii · 2025-09-24T18:45:57Z

`80e858b`

Implement text-transform: math-auto.
https://bugs.webkit.org/show_bug.cgi?id=202302

Reviewed by Frédéric Wang and Tim Nguyen.

MathML Core defines the math-auto text-transform
(https://w3c.github.io/mathml-core/#math-auto-transform). On text nodes
containing a single character, it maps it to the italic counterpart.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-transform-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-transform-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-transform/math/text-transform-math-auto-003-expected.txt:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/parser/CSSParserContext.cpp:
(WebCore::applyUASheetBehaviorsToContext):
(WebCore::add):
* Source/WebCore/css/parser/CSSParserContext.h:
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::convertToMathAuto):
(WebCore::applyTextTransform):
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
* Source/WebCore/rendering/style/RenderStyleConstants.h:
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertTextTransform):
* Source/WebCore/style/StyleExtractorConverter.h:
(WebCore::Style::ExtractorConverter::convertTextTransform):
* Source/WebCore/style/StyleExtractorSerializer.h:
(WebCore::Style::ExtractorSerializer::serializeTextTransform):
* Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation.js:

Canonical link: https://commits.webkit.org/302003@main

38de434

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-09-24T18:46:04Z

EWS run on previous version of this PR (hash ff2cbd6)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	❌ 🧪 win-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-09-25T12:35:22Z

EWS run on previous version of this PR (hash 4ef6bd7)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-09-25T16:21:33Z

EWS run on previous version of this PR (hash 4c63398)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-09-26T09:33:24Z

EWS run on previous version of this PR (hash 7bcea8b)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	⏳ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-09-26T13:22:00Z

EWS run on previous version of this PR (hash c0a2731)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

eerii · 2025-09-29T08:52:42Z

Hi @Ahmad-S792, whenever you can would it be ok for you to review this patch? Or maybe point me to another reviewer. Thanks! :)

Source/WebCore/rendering/RenderText.cpp

LayoutTests/platform/ios/TestExpectations

...ts/imported/w3c/web-platform-tests/css/css-text/parsing/text-transform-computed-expected.txt

Ahmad-S792 · 2025-10-01T11:22:32Z

Hi @Ahmad-S792, whenever you can would it be ok for you to review this patch? Or maybe point me to another reviewer. Thanks! :)

Unfortunately, I don't have reviewer rights, so I would defer the review from Apple side to @nt1m or @mdubet or @vitorroriz .

Source/WebCore/rendering/mathml/RenderMathMLToken.cpp

webkit-early-warning-system · 2025-10-01T19:03:52Z

EWS run on previous version of this PR (hash 1e38be2)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	⏳ 🛠 ios	✅ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2	⏳ 🧪 win-tests
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	⏳ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	~~🧪 api-ios~~	~~🧪 mac-wk2~~	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	⏳ 🛠 vision	⏳ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	⏳ 🛠 vision-sim	~~🧪 mac-wk2-stress~~	⏳ 🧪 api-gtk
	⏳ 🧪 vision-wk2	~~🧪 mac-intel-wk2~~	⏳ 🛠 playstation
	⏳ 🛠 tv	✅ 🛠 mac-safer-cpp	⏳ 🛠 jsc-armv7
	⏳ 🛠 tv-sim		⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

eerii · 2025-10-01T19:04:08Z

Since this is quite a large diff from the previous version, here is a list of changes and the motivation behind them:

Moved RenderMathMLToken::transformToMathVariant to TextTransform::transformToMathAuto. Removed the MathVariant argument since this is supposed to only do the italic transformation.
Moved RenderMathMLToken::mathVariant to TextTransform::mathVariantLegacy. This is the part that is still called from RenderMathMLToken when CSSTextTransformMathVariantEnabled is off.
Moved MathMLElement::MathVariant to TextTransform::MathVariant.
Moved MathMLTokenElement::convertToSingleCodePoint to TextTransform::convertToSingleCodePoint. Now it doesn't trim the whitespace around the codepoint. It was only called in two places, one of them RenderMathMLToken::updateMathVariantGlyph, which now do the trimming before calling the function. transformToMathVariant doesn't trim it to align more with how MathML Core is defined right now (pending Simplify whitespace collapsing/trimming for text nodes ; Support in Core? w3c/mathml-core#272 resolution). Perhaps this part should be in StringView or other utility header?

Additionally I removed the exceptions in the test expectations for iOS and Mac, let's see what the failures are in the EWS. Maybe they are not doing the text transform properly or maybe it's an issue with fonts.

vitorroriz · 2025-10-01T19:06:50Z

Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml

+    WebKitLegacy:
+      default: false
+    WebKit:
+      "PLATFORM(GTK) || PLATFORM(WPE)": true


Why is this on by default for these platforms?

Initially I started developing this under coreMathMLEnabled, which is on for GTK and WPE. We thought it was better to move it to a standalone preference, so when I was making it I set the same defaults as the previous one. The next step should be disabling the legacy mathvariant behaviour when MathML Core and this preference are enabled, so I think it makes sense having that.

I think we could enable text-transform: math-auto on all platforms. However, this is interacting with the mathvariant attribute and may lead to unexpected results for web developers when the legacy mathvariant attribute values are enabled. So probably better to keep math-auto disabled on platforms that have MathML Core disabled.

webkit-early-warning-system · 2025-10-01T19:09:24Z

EWS run on previous version of this PR (hash a21e804)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	⏳ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=202302 Reviewed by NOBODY (OOPS!). Part of WebKit#51271. Moves the MathVariant enum and the mathVariant function to the TextTransform file, making it easier to implement text-transform: math-auto in the next patch without having RenderText depend on various MathML classes. Also moves the convertToSingleCodePoint function there, which now doesn't perform whitespace trimming of the input string, as MathML Core doesn't define this. The two existing callers of this function are changed to do the trimming beforehand. No behaviour change. * Source/WebCore/mathml/MathMLElement.h: * Source/WebCore/mathml/MathMLOperatorElement.cpp: (WebCore::MathMLOperatorElement::parseOperatorChar): * Source/WebCore/mathml/MathMLPresentationElement.cpp: (WebCore::MathMLPresentationElement::parseMathVariantAttribute): (WebCore::MathMLPresentationElement::specifiedMathVariant): * Source/WebCore/mathml/MathMLTokenElement.cpp: (WebCore::MathMLTokenElement::convertToSingleCodePoint): Deleted. * Source/WebCore/mathml/MathMLTokenElement.h: * Source/WebCore/platform/graphics/TextTransform.cpp: (WebCore::convertToSingleCodePoint): (WebCore::ExtractKey): (WebCore::MathVariantMappingSearch): (WebCore::legacyMathVariant): * Source/WebCore/platform/graphics/TextTransform.h: * Source/WebCore/rendering/mathml/MathMLStyle.cpp: (WebCore::MathMLStyle::updateStyleIfNeeded): (WebCore::MathMLStyle::resolveMathMLStyle): * Source/WebCore/rendering/mathml/MathMLStyle.h: * Source/WebCore/rendering/mathml/RenderMathMLToken.cpp: (WebCore::RenderMathMLToken::updateMathVariantGlyph): (WebCore::ExtractKey): Deleted. (WebCore::MathVariantMappingSearch): Deleted. (WebCore::mathVariant): Deleted.

fred-wang

It's a bit difficult for me to understand this code without digging more, so I'll defer to other reviewers.

But as I see math-auto cannot be combined with other values per https://www.w3.org/TR/css-text-4/#text-transform-property

So your code does really follow the spec.

Do we have WPT tests to check different cases of math-auto combined with other values? Can we add some?

...eb-platform-tests/css/css-text/text-transform/math/text-transform-math-auto-003-expected.txt

Source/WebCore/style/StyleBuilderConverter.h

Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation.js

Source/WebCore/style/StyleExtractorSerializer.h

Source/WebCore/style/StyleExtractorConverter.h

webkit-early-warning-system · 2025-10-17T15:03:37Z

EWS run on previous version of this PR (hash 27d65ff)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	~~🛠 wpe~~	⏳ 🛠 win
✅ 🧪 bindings	⏳ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	⏳ 🧪 win-tests
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	~~🧪 api-mac~~	~~🧪 api-wpe~~
	⏳ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	⏳ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	⏳ 🧪 api-ios	~~🧪 mac-wk2~~	⏳ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	⏳ 🛠 vision	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 gtk-wk2
	⏳ 🛠 vision-sim	~~🧪 mac-wk2-stress~~	⏳ 🧪 api-gtk
	⏳ 🧪 vision-wk2	~~🧪 mac-intel-wk2~~	⏳ 🛠 playstation
	⏳ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	⏳ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2025-10-17T15:14:46Z

EWS run on previous version of this PR (hash 748d8ee)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	⏳ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

Source/WebCore/style/StyleExtractorSerializer.h

webkit-early-warning-system · 2025-10-21T10:29:28Z

EWS run on previous version of this PR (hash 162963c)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	~~🛠 wpe~~	~~🛠 win~~
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	~~🧪 api-wpe~~
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	~~🛠 wpe-cairo~~
✅ 🛠 🧪 jsc	❌ 🧪 api-ios	❌ 🧪 mac-wk2	~~🛠 gtk~~
✅ 🛠 🧪 jsc-arm64	~~🛠 vision~~	❌ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	~~🛠 vision-sim~~	❌ 🧪 mac-wk2-stress	~~🧪 api-gtk~~
	⏳ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2	~~🛠 playstation~~
	❌ 🛠 tv	~~🛠 mac-safer-cpp~~	✅ 🛠 jsc-armv7
	~~🛠 tv-sim~~		✅ 🧪 jsc-armv7-tests
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2025-10-21T10:39:02Z

EWS run on current version of this PR (hash 38de434)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

fred-wang

LGTM, but deferring to CSS reviewers.

Source/WebCore/style/StyleExtractorSerializer.h

eerii · 2025-10-22T07:11:52Z

@nt1m, @vitorroriz could you take a look at the updated version whenever you can? Thanks!

webkit-ews-buildbot · 2025-10-23T05:41:34Z

Safe-Merge-Queue: Build #72940.

https://bugs.webkit.org/show_bug.cgi?id=202302 Reviewed by Frédéric Wang and Tim Nguyen. MathML Core defines the math-auto text-transform (https://w3c.github.io/mathml-core/#math-auto-transform). On text nodes containing a single character, it maps it to the italic counterpart. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-transform-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-transform-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-transform/math/text-transform-math-auto-003-expected.txt: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/css/CSSPrimitiveValueMappings.h: * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/CSSValueKeywords.in: * Source/WebCore/css/parser/CSSParserContext.cpp: (WebCore::applyUASheetBehaviorsToContext): (WebCore::add): * Source/WebCore/css/parser/CSSParserContext.h: * Source/WebCore/rendering/RenderText.cpp: (WebCore::convertToMathAuto): (WebCore::applyTextTransform): * Source/WebCore/rendering/style/RenderStyle.h: * Source/WebCore/rendering/style/RenderStyleConstants.cpp: (WebCore::operator<<): * Source/WebCore/rendering/style/RenderStyleConstants.h: * Source/WebCore/style/StyleBuilderConverter.h: (WebCore::Style::BuilderConverter::convertTextTransform): * Source/WebCore/style/StyleExtractorConverter.h: (WebCore::Style::ExtractorConverter::convertTextTransform): * Source/WebCore/style/StyleExtractorSerializer.h: (WebCore::Style::ExtractorSerializer::serializeTextTransform): * Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation.js: Canonical link: https://commits.webkit.org/302003@main

webkit-commit-queue · 2025-10-23T06:01:57Z

Committed 302003@main (80e858b): https://commits.webkit.org/302003@main

Reviewed commits have been landed. Closing PR #51271 and removing active labels.

rkirsling · 2025-10-23T07:36:31Z

This broke PlayStation (which has a committer-restricted EWS) due to a missing include (or #if):

C:/BW/PlayStation-Debug-Build/build/Source/WebCore\rendering/RenderText.cpp:1677:84: error: use of undeclared identifier 'MathVariant'
 1677 |         char32_t transformedCodePoint = mathVariantMapCodePoint(codePoint.value(), MathVariant::Italic);
      |                                                                                    ^

This should be trivial enough to not warrant a revert; let me know if you can fix this quickly, otherwise I can do so this time.

rkirsling · 2025-10-23T07:42:49Z

Fixing in #52864.

eerii · 2025-10-23T08:02:36Z

Thanks for the quick fix @rkirsling

eerii requested review from dcrousso and patrickangle as code owners September 24, 2025 18:45

Ahmad-S792 assigned eerii Sep 24, 2025

Ahmad-S792 added the MathML For bugs specific to MathML. label Sep 24, 2025

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 24, 2025

eerii marked this pull request as draft September 25, 2025 10:38

eerii changed the title ~~Implement text-transform: math-auto and adapt mathvariant attribute.~~ Implement text-transform: math-auto. Sep 25, 2025

eerii force-pushed the mathvariant branch from ff2cbd6 to 4ef6bd7 Compare September 25, 2025 12:35

eerii force-pushed the mathvariant branch from 4ef6bd7 to 4c63398 Compare September 25, 2025 16:21

eerii force-pushed the mathvariant branch from 4c63398 to 7bcea8b Compare September 26, 2025 09:33

eerii force-pushed the mathvariant branch from 7bcea8b to c0a2731 Compare September 26, 2025 13:21

eerii marked this pull request as ready for review September 26, 2025 13:28

fred-wang requested changes Oct 1, 2025

View reviewed changes

nt1m reviewed Oct 1, 2025

View reviewed changes

Source/WebCore/rendering/mathml/RenderMathMLToken.cpp Outdated Show resolved Hide resolved

vitorroriz reviewed Oct 1, 2025

View reviewed changes

Source/WebCore/rendering/mathml/RenderMathMLToken.cpp Outdated Show resolved Hide resolved

eerii force-pushed the mathvariant branch from c0a2731 to 1e38be2 Compare October 1, 2025 19:03

vitorroriz reviewed Oct 1, 2025

View reviewed changes

eerii force-pushed the mathvariant branch from 1e38be2 to a21e804 Compare October 1, 2025 19:09

eerii marked this pull request as draft October 2, 2025 11:41

eerii requested a review from fred-wang October 17, 2025 09:46

fred-wang reviewed Oct 17, 2025

View reviewed changes

eerii force-pushed the mathvariant branch from 3b3d2c1 to 27d65ff Compare October 17, 2025 15:03

eerii force-pushed the mathvariant branch from 27d65ff to 748d8ee Compare October 17, 2025 15:14

fred-wang reviewed Oct 21, 2025

View reviewed changes

Source/WebCore/style/StyleExtractorSerializer.h Show resolved Hide resolved

eerii force-pushed the mathvariant branch from 748d8ee to 162963c Compare October 21, 2025 10:29

eerii force-pushed the mathvariant branch from 162963c to 38de434 Compare October 21, 2025 10:38

fred-wang approved these changes Oct 21, 2025

View reviewed changes

Source/WebCore/style/StyleExtractorSerializer.h Show resolved Hide resolved

eerii requested review from nt1m and vitorroriz October 22, 2025 07:12

nt1m approved these changes Oct 22, 2025

View reviewed changes

fred-wang added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks and removed merging-blocked Applied to prevent a change from being merged labels Oct 23, 2025

webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Oct 23, 2025

webkit-commit-queue force-pushed the mathvariant branch from 38de434 to 80e858b Compare October 23, 2025 06:01

webkit-commit-queue merged commit 80e858b into WebKit:main Oct 23, 2025

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 23, 2025

eerii deleted the mathvariant branch October 29, 2025 08:46

Implement text-transform: math-auto. #51271

Implement text-transform: math-auto. #51271

Uh oh!

Conversation

eerii commented Sep 24, 2025 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

80e858b

Uh oh!

webkit-early-warning-system commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eerii commented Sep 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ahmad-S792 commented Oct 1, 2025

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eerii commented Oct 1, 2025

Uh oh!

vitorroriz Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eerii Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

fred-wang Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fred-wang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fred-wang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

eerii commented Oct 22, 2025

Uh oh!

webkit-ews-buildbot commented Oct 23, 2025

Uh oh!

eerii commented Sep 24, 2025 •

edited by webkit-early-warning-system

Loading

`80e858b`

webkit-early-warning-system commented Sep 24, 2025 •

edited

Loading

webkit-early-warning-system commented Sep 25, 2025 •

edited

Loading

webkit-early-warning-system commented Sep 25, 2025 •

edited

Loading

webkit-early-warning-system commented Sep 26, 2025 •

edited

Loading

webkit-early-warning-system commented Sep 26, 2025 •

edited

Loading

webkit-early-warning-system commented Oct 1, 2025 •

edited

Loading

vitorroriz Oct 1, 2025 •

edited

Loading

webkit-early-warning-system commented Oct 1, 2025 •

edited

Loading

webkit-early-warning-system commented Oct 17, 2025 •

edited

Loading

webkit-early-warning-system commented Oct 17, 2025 •

edited

Loading

webkit-early-warning-system commented Oct 21, 2025 •

edited

Loading

webkit-early-warning-system commented Oct 21, 2025 •

edited

Loading