Skip to content

Fix !ENABLE(MATHML) build following 302003@main #52864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-commit-queue merged 1 commit into from
Oct 23, 2025
Merged

Fix !ENABLE(MATHML) build following 302003@main #52864

webkit-commit-queue merged 1 commit into from
Oct 23, 2025

Conversation

@rkirsling
Copy link
Member

@rkirsling rkirsling commented Oct 23, 2025 •
edited by webkit-early-warning-system
Loading

0c6bb54

Fix !ENABLE(MATHML) build following 302003@main
https://bugs.webkit.org/show_bug.cgi?id=301331

Unreviewed build fix.

* Source/WebCore/rendering/RenderText.cpp:
(WebCore::convertToMathAuto):
Add missing #if.

Canonical link: https://commits.webkit.org/302012@main

49f9049

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ❌ 🛠 wpe   🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim   🛠 mac-AS-debug ❌ 🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ❌ 🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ❌ 🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2 ❌ 🛠 gtk
  🛠 vision   🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-wk2-stress ❌ 🧪 api-gtk
⏳ 🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv   🛠 mac-safer-cpp ⏳ 🛠 jsc-armv7
  🛠 tv-sim ⏳ 🧪 jsc-armv7-tests
  🛠 watch
  🛠 watch-sim

@rkirsling rkirsling self-assigned this Oct 23, 2025
@rkirsling rkirsling added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Oct 23, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 23, 2025 •
edited
Loading

EWS run on current version of this PR (hash 49f9049)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ❌ 🛠 wpe   🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim   🛠 mac-AS-debug ❌ 🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ❌ 🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ❌ 🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2 ❌ 🛠 gtk
  🛠 vision   🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-wk2-stress ❌ 🧪 api-gtk
⏳ 🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv   🛠 mac-safer-cpp ⏳ 🛠 jsc-armv7
  🛠 tv-sim ⏳ 🧪 jsc-armv7-tests
  🛠 watch
  🛠 watch-sim

@rkirsling rkirsling mentioned this pull request Oct 23, 2025
Merged
@rkirsling rkirsling added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 23, 2025
@rkirsling
Fix !ENABLE(MATHML) build following 302003@main
0c6bb54 
https://bugs.webkit.org/show_bug.cgi?id=301331

Unreviewed build fix.

* Source/WebCore/rendering/RenderText.cpp:
(WebCore::convertToMathAuto):
Add missing #if.

Canonical link: https://commits.webkit.org/302012@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Fix-ENABLE-MATHML-build-following-302003-main branch from 49f9049 to 0c6bb54 Compare October 23, 2025 07:46
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Oct 23, 2025

Committed 302012@main (0c6bb54): https://commits.webkit.org/302012@main

Reviewed commits have been landed. Closing PR #52864 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0c6bb54 into WebKit:main Oct 23, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 23, 2025
@rkirsling rkirsling deleted the eng/Fix-ENABLE-MATHML-build-following-302003-main branch October 23, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rkirsling rkirsling

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rkirsling @webkit-early-warning-system @webkit-commit-queue