Implement <details>/<summary> disclosure triangle as a list item#34778
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Nov 20, 2024
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
rniwa
reviewed
Oct 7, 2024
Member
There was a problem hiding this comment.
Maybe we can use adoptedStyleSheets() instead of creating a new style element?
Member
Author
There was a problem hiding this comment.
The spec uses a style element: https://html.spec.whatwg.org/#the-details-and-summary-elements
Contributor
There was a problem hiding this comment.
It should be the same though. I said as much in the specification review and the main reason the style element approach was allowed because you couldn't observe the difference. If you're setting it up programmatically I'm not entirely sure it makes sense to create the additional node.
Member
Author
There was a problem hiding this comment.
I can try it, but it'll probably end up inconsistent with meter/attachment, although I guess they were created before adoptedStylesheets
Member
Author
There was a problem hiding this comment.
I tried to address this but none of my attempts worked
<details>/<summary> disclosure triangle as a list item
631905f to
0855b11
Compare
This comment was marked as outdated.
This comment was marked as outdated.
0855b11 to
ecec176
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
Can we fix this warning? It's probably due to the unified sources moving files around: |
Member
|
We can probably just inline |
|
Thank you @nt1m 🙏! |
ecec176 to
51f2d3f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
51f2d3f to
5c8deeb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
56684c6 to
3969c57
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
3969c57 to
504f453
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
504f453 to
a25e7d1
Compare
Collaborator
|
EWS run on current version of this PR (hash a25e7d1) Details |
nt1m
commented
Nov 20, 2024
Member
Author
There was a problem hiding this comment.
This test relies on ::details-content to emulate the old behavior of details/summary. It'll re-progress once I implement the pseudo-element: https://bugs.webkit.org/show_bug.cgi?id=275211 (I already have a PR for it)
webkit-commit-queue
pushed a commit
to nt1m/WebKit
that referenced
this pull request
Nov 20, 2024
https://bugs.webkit.org/show_bug.cgi?id=283429 rdar://140287648 Reviewed by Ryosuke Niwa and Chris Dumez. Silence some smart pointer errors with unified sources shifting around. See WebKit#34778 * Source/WebCore/html/track/TextTrack.cpp: (WebCore::TextTrack::invalidateTrackIndex): Deleted. * Source/WebCore/html/track/TextTrack.h: (WebCore::TextTrack::invalidateTrackIndex): Canonical link: https://commits.webkit.org/286866@main
rniwa
approved these changes
Nov 20, 2024
https://bugs.webkit.org/show_bug.cgi?id=157323 rdar://95148788 Reviewed by Ryosuke Niwa. https://html.spec.whatwg.org/#the-details-and-summary-elements This does the following changes to match the latest HTML spec: - Implements details/summary disclosure triangle as a list item - Implements collapsing of summary with `content-visibility: hidden` as mandated by spec, instead of appending/deleting the default slot - Sets `display: block` on the default slot when the details element is open for easier styling - Adds the user-agent styles for details/summary - Stops forcing the used display value for details/summary - Removes DetailsMarkerControl/RenderDetailsMarker (::-webkit-details-marker) since this is now covered by the list item ::marker As a result, the following are fixed: - ::marker can now be used instead of ::-webkit-details-marker (bug 157323) - Changing list-style and display is now effective on the ::marker (bug 264381) - element.checkVisibility() now works properly on elements in the default slot (bug 264733) - summary::before now appears in the correct order (bug 61426) - details::before/after now appear in the correct order (bug 61766) - and more... * LayoutTests/TestExpectations: * LayoutTests/accessibility/ios-simulator/aria-details-toggle-summary-expected.txt: * LayoutTests/fast/css-grid-layout/grid-was-populated-assert-expected.txt: * LayoutTests/fast/html/details-clone-expected.txt: Removed. * LayoutTests/fast/html/details-clone.html: Removed. * LayoutTests/fast/html/details-inline-expected.html: Removed. * LayoutTests/fast/html/details-inline.html: Removed. * LayoutTests/fast/multicol/crash-in-vertical-writing-mode-expected.txt: * LayoutTests/fast/multicol/crash-in-vertical-writing-mode.html: * LayoutTests/http/tests/security/cross-origin-blob-transfer-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/run/inserthorizontalrule-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/the-details-element/details-blockification-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/the-details-element/details-display-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-details-element/closed-details-layout-apis.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-details-element/toggleEvent-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-summary-element/anchor-with-inline-element-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-summary-element/interactive-content-expected.txt: * LayoutTests/platform/glib/fast/css-generated-content/details-summary-before-after-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-child-1-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-child-2-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-details-child-1-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-details-child-2-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-summary-1-and-click-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-summary-1-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-summary-10-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-add-summary-10-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-summary-2-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-add-summary-2-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-summary-3-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-add-summary-3-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-summary-4-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-add-summary-4-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-summary-5-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-add-summary-5-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-summary-6-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-add-summary-6-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-summary-7-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-add-summary-7-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-summary-8-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-add-summary-8-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-summary-9-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-add-summary-9-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-summary-child-1-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-summary-child-2-expected.txt: * LayoutTests/platform/glib/fast/html/details-marker-style-expected.txt: * LayoutTests/platform/glib/fast/html/details-marker-style-mixed-expected.txt: * LayoutTests/platform/glib/fast/html/details-nested-1-expected.txt: * LayoutTests/platform/glib/fast/html/details-nested-2-expected.txt: * LayoutTests/platform/glib/fast/html/details-no-summary1-expected.txt: * LayoutTests/platform/glib/fast/html/details-no-summary2-expected.txt: * LayoutTests/platform/glib/fast/html/details-no-summary3-expected.txt: * LayoutTests/platform/glib/fast/html/details-open1-expected.txt: * LayoutTests/platform/glib/fast/html/details-open3-expected.txt: * LayoutTests/platform/glib/fast/html/details-open5-expected.txt: * LayoutTests/platform/glib/fast/html/details-open6-expected.txt: * LayoutTests/platform/glib/fast/html/details-position-expected.txt: * LayoutTests/platform/glib/fast/html/details-remove-child-1-expected.txt: * LayoutTests/platform/glib/fast/html/details-remove-child-2-expected.txt: * LayoutTests/platform/glib/fast/html/details-remove-summary-1-and-click-expected.txt: * LayoutTests/platform/glib/fast/html/details-remove-summary-1-expected.txt: * LayoutTests/platform/glib/fast/html/details-remove-summary-2-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-remove-summary-2-expected.txt: * LayoutTests/platform/glib/fast/html/details-remove-summary-3-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-remove-summary-3-expected.txt: * LayoutTests/platform/glib/fast/html/details-remove-summary-4-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-remove-summary-4-expected.txt: * LayoutTests/platform/glib/fast/html/details-remove-summary-5-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-remove-summary-5-expected.txt: * LayoutTests/platform/glib/fast/html/details-remove-summary-6-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-remove-summary-6-expected.txt: * LayoutTests/platform/glib/fast/html/details-remove-summary-child-1-expected.txt: * LayoutTests/platform/glib/fast/html/details-remove-summary-child-2-expected.txt: * LayoutTests/platform/glib/fast/html/details-writing-mode-expected.txt: * LayoutTests/platform/glib/fast/html/details-writing-mode-mixed-expected.txt: * LayoutTests/platform/glib/fast/multicol/span/clone-summary-expected.txt: * LayoutTests/platform/gtk/TestExpectations: * LayoutTests/platform/gtk/fast/html/details-add-summary-10-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-add-summary-2-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-add-summary-3-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-add-summary-4-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-add-summary-5-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-add-summary-6-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-add-summary-7-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-add-summary-8-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-add-summary-9-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-no-summary4-expected.txt: * LayoutTests/platform/gtk/fast/html/details-open-javascript-expected.txt: * LayoutTests/platform/gtk/fast/html/details-open2-expected.txt: * LayoutTests/platform/gtk/fast/html/details-open4-expected.txt: * LayoutTests/platform/gtk/fast/html/details-remove-summary-2-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-remove-summary-3-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-remove-summary-5-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-remove-summary-6-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-replace-summary-child-expected.txt: * LayoutTests/platform/gtk/fast/html/details-replace-text-expected.txt: * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/ios/fast/html/details-add-child-1-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-child-2-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-details-child-1-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-details-child-2-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-1-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-1-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-10-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-10-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-2-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-2-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-3-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-3-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-4-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-4-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-5-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-5-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-6-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-6-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-7-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-7-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-8-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-8-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-9-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-9-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-child-1-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-child-2-expected.txt: * LayoutTests/platform/ios/fast/html/details-marker-style-expected.txt: * LayoutTests/platform/ios/fast/html/details-marker-style-mixed-expected.txt: * LayoutTests/platform/ios/fast/html/details-nested-1-expected.txt: * LayoutTests/platform/ios/fast/html/details-nested-2-expected.txt: * LayoutTests/platform/ios/fast/html/details-no-summary1-expected.txt: * LayoutTests/platform/ios/fast/html/details-no-summary2-expected.txt: * LayoutTests/platform/ios/fast/html/details-no-summary3-expected.txt: * LayoutTests/platform/ios/fast/html/details-no-summary4-expected.txt: * LayoutTests/platform/ios/fast/html/details-open-javascript-expected.txt: * LayoutTests/platform/ios/fast/html/details-open1-expected.txt: * LayoutTests/platform/ios/fast/html/details-open2-expected.txt: * LayoutTests/platform/ios/fast/html/details-open3-expected.txt: * LayoutTests/platform/ios/fast/html/details-open4-expected.txt: * LayoutTests/platform/ios/fast/html/details-open5-expected.txt: * LayoutTests/platform/ios/fast/html/details-open6-expected.txt: * LayoutTests/platform/ios/fast/html/details-position-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-child-1-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-child-2-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-1-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-1-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-2-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-2-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-3-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-3-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-4-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-4-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-5-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-5-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-6-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-6-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-child-1-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-child-2-expected.txt: * LayoutTests/platform/ios/fast/html/details-replace-summary-child-expected.txt: * LayoutTests/platform/ios/fast/html/details-replace-text-expected.txt: * LayoutTests/platform/ios/fast/html/details-writing-mode-expected.txt: * LayoutTests/platform/ios/fast/html/details-writing-mode-mixed-expected.txt: * LayoutTests/platform/ios/fast/multicol/span/clone-summary-expected.txt: * LayoutTests/platform/mac-ventura/fast/html/details-no-summary4-expected.txt: * LayoutTests/platform/mac-ventura/fast/html/details-open-javascript-expected.txt: * LayoutTests/platform/mac-ventura/fast/html/details-open2-expected.txt: * LayoutTests/platform/mac-ventura/fast/html/details-open4-expected.txt: * LayoutTests/platform/mac/TestExpectations: * LayoutTests/platform/mac/fast/css-generated-content/details-summary-before-after-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-child-1-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-child-2-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-details-child-1-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-details-child-2-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-1-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-1-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-10-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-10-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-2-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-2-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-3-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-3-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-4-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-4-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-5-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-5-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-6-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-6-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-7-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-7-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-8-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-8-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-9-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-9-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-child-1-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-child-2-expected.txt: * LayoutTests/platform/mac/fast/html/details-marker-style-expected.txt: * LayoutTests/platform/mac/fast/html/details-marker-style-mixed-expected.txt: * LayoutTests/platform/mac/fast/html/details-nested-1-expected.txt: * LayoutTests/platform/mac/fast/html/details-nested-2-expected.txt: * LayoutTests/platform/mac/fast/html/details-no-summary1-expected.txt: * LayoutTests/platform/mac/fast/html/details-no-summary2-expected.txt: * LayoutTests/platform/mac/fast/html/details-no-summary3-expected.txt: * LayoutTests/platform/mac/fast/html/details-no-summary4-expected.txt: * LayoutTests/platform/mac/fast/html/details-open-javascript-expected.txt: * LayoutTests/platform/mac/fast/html/details-open1-expected.txt: * LayoutTests/platform/mac/fast/html/details-open2-expected.txt: * LayoutTests/platform/mac/fast/html/details-open3-expected.txt: * LayoutTests/platform/mac/fast/html/details-open4-expected.txt: * LayoutTests/platform/mac/fast/html/details-open5-expected.txt: * LayoutTests/platform/mac/fast/html/details-open6-expected.txt: * LayoutTests/platform/mac/fast/html/details-position-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-child-1-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-child-2-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-1-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-2-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-3-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-4-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-5-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-6-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-child-1-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-child-2-expected.txt: * LayoutTests/platform/mac/fast/html/details-replace-summary-child-expected.txt: * LayoutTests/platform/mac/fast/html/details-replace-text-expected.txt: * LayoutTests/platform/mac/fast/html/details-writing-mode-expected.txt: * LayoutTests/platform/mac/fast/html/details-writing-mode-mixed-expected.txt: * LayoutTests/platform/mac/fast/multicol/span/clone-summary-expected.txt: * LayoutTests/platform/wpe/TestExpectations: * LayoutTests/platform/wpe/fast/html/details-add-summary-10-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-add-summary-2-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-add-summary-3-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-add-summary-4-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-add-summary-5-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-add-summary-6-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-add-summary-7-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-add-summary-8-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-add-summary-9-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-no-summary4-expected.txt: * LayoutTests/platform/wpe/fast/html/details-open-javascript-expected.txt: * LayoutTests/platform/wpe/fast/html/details-open2-expected.txt: * LayoutTests/platform/wpe/fast/html/details-open4-expected.txt: * LayoutTests/platform/wpe/fast/html/details-remove-summary-2-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-remove-summary-3-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-remove-summary-4-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-remove-summary-5-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-remove-summary-6-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-replace-summary-child-expected.txt: * LayoutTests/platform/wpe/fast/html/details-replace-text-expected.txt: * LayoutTests/tables/table-col-indent-crash-expected.txt: * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::determineAccessibilityRole): * Source/WebCore/css/CSSPseudoSelectors.json: * Source/WebCore/css/html.css: (details, summary): (details > summary:first-of-type): (details[open] > summary:first-of-type): (frameset, frame): (frameset): (iframe): (details): Deleted. (summary): Deleted. (summary::-webkit-details-marker): Deleted. * Source/WebCore/css/process-css-pseudo-selectors.py: * Source/WebCore/html/HTMLDetailsElement.cpp: (WebCore::HTMLDetailsElement::didAddUserAgentShadowRoot): (WebCore::HTMLDetailsElement::attributeChanged): (WebCore::HTMLDetailsElement::createElementRenderer): Deleted. * Source/WebCore/html/HTMLDetailsElement.h: * Source/WebCore/html/HTMLSummaryElement.cpp: (WebCore::HTMLSummaryElement::create): (): Deleted. (WebCore::HTMLSummaryElement::createElementRenderer): Deleted. (WebCore::HTMLSummaryElement::didAddUserAgentShadowRoot): Deleted. * Source/WebCore/html/HTMLSummaryElement.h: * Source/WebCore/html/shadow/DetailsMarkerControl.cpp: Removed. * Source/WebCore/html/shadow/DetailsMarkerControl.h: Removed. * Source/WebCore/html/shadow/detailsElementShadow.css: Added. (:host summary): (:host([open]) summary): * Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp: * Source/WebCore/rendering/RenderDetailsMarker.cpp: Removed. * Source/WebCore/rendering/RenderDetailsMarker.h: Removed. * Source/WebCore/rendering/RenderTreeAsText.cpp: (WebCore::RenderTreeAsText::writeRenderObject): * Source/WebCore/style/UserAgentStyle.cpp: (WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement): Canonical link: https://commits.webkit.org/286869@main
a25e7d1 to
cd2f382
Compare
Collaborator
|
Committed 286869@main (cd2f382): https://commits.webkit.org/286869@main Reviewed commits have been landed. Closing PR #34778 and removing active labels. |
mnutt
pushed a commit
to movableink/webkit
that referenced
this pull request
Nov 23, 2024
https://bugs.webkit.org/show_bug.cgi?id=283429 rdar://140287648 Reviewed by Ryosuke Niwa and Chris Dumez. Silence some smart pointer errors with unified sources shifting around. See WebKit/WebKit#34778 * Source/WebCore/html/track/TextTrack.cpp: (WebCore::TextTrack::invalidateTrackIndex): Deleted. * Source/WebCore/html/track/TextTrack.h: (WebCore::TextTrack::invalidateTrackIndex): Canonical link: https://commits.webkit.org/286866@main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cd2f382
a25e7d1
🛠 mac-safer-cpp