Skip to content

Commit cd2f382

Browse files
nt1mnt1m
committed
Implement <details>/<summary> disclosure triangle as a list item
https://bugs.webkit.org/show_bug.cgi?id=157323 rdar://95148788 Reviewed by Ryosuke Niwa. https://html.spec.whatwg.org/#the-details-and-summary-elements This does the following changes to match the latest HTML spec: - Implements details/summary disclosure triangle as a list item - Implements collapsing of summary with `content-visibility: hidden` as mandated by spec, instead of appending/deleting the default slot - Sets `display: block` on the default slot when the details element is open for easier styling - Adds the user-agent styles for details/summary - Stops forcing the used display value for details/summary - Removes DetailsMarkerControl/RenderDetailsMarker (::-webkit-details-marker) since this is now covered by the list item ::marker As a result, the following are fixed: - ::marker can now be used instead of ::-webkit-details-marker (bug 157323) - Changing list-style and display is now effective on the ::marker (bug 264381) - element.checkVisibility() now works properly on elements in the default slot (bug 264733) - summary::before now appears in the correct order (bug 61426) - details::before/after now appear in the correct order (bug 61766) - and more... * LayoutTests/TestExpectations: * LayoutTests/accessibility/ios-simulator/aria-details-toggle-summary-expected.txt: * LayoutTests/fast/css-grid-layout/grid-was-populated-assert-expected.txt: * LayoutTests/fast/html/details-clone-expected.txt: Removed. * LayoutTests/fast/html/details-clone.html: Removed. * LayoutTests/fast/html/details-inline-expected.html: Removed. * LayoutTests/fast/html/details-inline.html: Removed. * LayoutTests/fast/multicol/crash-in-vertical-writing-mode-expected.txt: * LayoutTests/fast/multicol/crash-in-vertical-writing-mode.html: * LayoutTests/http/tests/security/cross-origin-blob-transfer-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/editing/run/inserthorizontalrule-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/the-details-element/details-blockification-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/the-details-element/details-display-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-details-element/closed-details-layout-apis.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-details-element/toggleEvent-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-summary-element/anchor-with-inline-element-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-summary-element/interactive-content-expected.txt: * LayoutTests/platform/glib/fast/css-generated-content/details-summary-before-after-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-child-1-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-child-2-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-details-child-1-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-details-child-2-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-summary-1-and-click-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-summary-1-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-summary-10-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-add-summary-10-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-summary-2-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-add-summary-2-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-summary-3-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-add-summary-3-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-summary-4-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-add-summary-4-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-summary-5-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-add-summary-5-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-summary-6-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-add-summary-6-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-summary-7-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-add-summary-7-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-summary-8-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-add-summary-8-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-summary-9-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-add-summary-9-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-summary-child-1-expected.txt: * LayoutTests/platform/glib/fast/html/details-add-summary-child-2-expected.txt: * LayoutTests/platform/glib/fast/html/details-marker-style-expected.txt: * LayoutTests/platform/glib/fast/html/details-marker-style-mixed-expected.txt: * LayoutTests/platform/glib/fast/html/details-nested-1-expected.txt: * LayoutTests/platform/glib/fast/html/details-nested-2-expected.txt: * LayoutTests/platform/glib/fast/html/details-no-summary1-expected.txt: * LayoutTests/platform/glib/fast/html/details-no-summary2-expected.txt: * LayoutTests/platform/glib/fast/html/details-no-summary3-expected.txt: * LayoutTests/platform/glib/fast/html/details-open1-expected.txt: * LayoutTests/platform/glib/fast/html/details-open3-expected.txt: * LayoutTests/platform/glib/fast/html/details-open5-expected.txt: * LayoutTests/platform/glib/fast/html/details-open6-expected.txt: * LayoutTests/platform/glib/fast/html/details-position-expected.txt: * LayoutTests/platform/glib/fast/html/details-remove-child-1-expected.txt: * LayoutTests/platform/glib/fast/html/details-remove-child-2-expected.txt: * LayoutTests/platform/glib/fast/html/details-remove-summary-1-and-click-expected.txt: * LayoutTests/platform/glib/fast/html/details-remove-summary-1-expected.txt: * LayoutTests/platform/glib/fast/html/details-remove-summary-2-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-remove-summary-2-expected.txt: * LayoutTests/platform/glib/fast/html/details-remove-summary-3-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-remove-summary-3-expected.txt: * LayoutTests/platform/glib/fast/html/details-remove-summary-4-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-remove-summary-4-expected.txt: * LayoutTests/platform/glib/fast/html/details-remove-summary-5-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-remove-summary-5-expected.txt: * LayoutTests/platform/glib/fast/html/details-remove-summary-6-and-click-expected.txt: Removed. * LayoutTests/platform/glib/fast/html/details-remove-summary-6-expected.txt: * LayoutTests/platform/glib/fast/html/details-remove-summary-child-1-expected.txt: * LayoutTests/platform/glib/fast/html/details-remove-summary-child-2-expected.txt: * LayoutTests/platform/glib/fast/html/details-writing-mode-expected.txt: * LayoutTests/platform/glib/fast/html/details-writing-mode-mixed-expected.txt: * LayoutTests/platform/glib/fast/multicol/span/clone-summary-expected.txt: * LayoutTests/platform/gtk/TestExpectations: * LayoutTests/platform/gtk/fast/html/details-add-summary-10-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-add-summary-2-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-add-summary-3-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-add-summary-4-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-add-summary-5-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-add-summary-6-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-add-summary-7-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-add-summary-8-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-add-summary-9-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-no-summary4-expected.txt: * LayoutTests/platform/gtk/fast/html/details-open-javascript-expected.txt: * LayoutTests/platform/gtk/fast/html/details-open2-expected.txt: * LayoutTests/platform/gtk/fast/html/details-open4-expected.txt: * LayoutTests/platform/gtk/fast/html/details-remove-summary-2-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-remove-summary-3-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-remove-summary-5-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-remove-summary-6-and-click-expected.txt: Added. * LayoutTests/platform/gtk/fast/html/details-replace-summary-child-expected.txt: * LayoutTests/platform/gtk/fast/html/details-replace-text-expected.txt: * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/ios/fast/html/details-add-child-1-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-child-2-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-details-child-1-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-details-child-2-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-1-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-1-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-10-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-10-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-2-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-2-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-3-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-3-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-4-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-4-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-5-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-5-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-6-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-6-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-7-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-7-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-8-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-8-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-9-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-9-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-child-1-expected.txt: * LayoutTests/platform/ios/fast/html/details-add-summary-child-2-expected.txt: * LayoutTests/platform/ios/fast/html/details-marker-style-expected.txt: * LayoutTests/platform/ios/fast/html/details-marker-style-mixed-expected.txt: * LayoutTests/platform/ios/fast/html/details-nested-1-expected.txt: * LayoutTests/platform/ios/fast/html/details-nested-2-expected.txt: * LayoutTests/platform/ios/fast/html/details-no-summary1-expected.txt: * LayoutTests/platform/ios/fast/html/details-no-summary2-expected.txt: * LayoutTests/platform/ios/fast/html/details-no-summary3-expected.txt: * LayoutTests/platform/ios/fast/html/details-no-summary4-expected.txt: * LayoutTests/platform/ios/fast/html/details-open-javascript-expected.txt: * LayoutTests/platform/ios/fast/html/details-open1-expected.txt: * LayoutTests/platform/ios/fast/html/details-open2-expected.txt: * LayoutTests/platform/ios/fast/html/details-open3-expected.txt: * LayoutTests/platform/ios/fast/html/details-open4-expected.txt: * LayoutTests/platform/ios/fast/html/details-open5-expected.txt: * LayoutTests/platform/ios/fast/html/details-open6-expected.txt: * LayoutTests/platform/ios/fast/html/details-position-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-child-1-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-child-2-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-1-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-1-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-2-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-2-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-3-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-3-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-4-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-4-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-5-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-5-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-6-and-click-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-6-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-child-1-expected.txt: * LayoutTests/platform/ios/fast/html/details-remove-summary-child-2-expected.txt: * LayoutTests/platform/ios/fast/html/details-replace-summary-child-expected.txt: * LayoutTests/platform/ios/fast/html/details-replace-text-expected.txt: * LayoutTests/platform/ios/fast/html/details-writing-mode-expected.txt: * LayoutTests/platform/ios/fast/html/details-writing-mode-mixed-expected.txt: * LayoutTests/platform/ios/fast/multicol/span/clone-summary-expected.txt: * LayoutTests/platform/mac-ventura/fast/html/details-no-summary4-expected.txt: * LayoutTests/platform/mac-ventura/fast/html/details-open-javascript-expected.txt: * LayoutTests/platform/mac-ventura/fast/html/details-open2-expected.txt: * LayoutTests/platform/mac-ventura/fast/html/details-open4-expected.txt: * LayoutTests/platform/mac/TestExpectations: * LayoutTests/platform/mac/fast/css-generated-content/details-summary-before-after-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-child-1-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-child-2-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-details-child-1-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-details-child-2-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-1-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-1-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-10-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-10-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-2-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-2-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-3-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-3-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-4-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-4-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-5-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-5-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-6-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-6-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-7-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-7-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-8-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-8-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-9-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-9-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-child-1-expected.txt: * LayoutTests/platform/mac/fast/html/details-add-summary-child-2-expected.txt: * LayoutTests/platform/mac/fast/html/details-marker-style-expected.txt: * LayoutTests/platform/mac/fast/html/details-marker-style-mixed-expected.txt: * LayoutTests/platform/mac/fast/html/details-nested-1-expected.txt: * LayoutTests/platform/mac/fast/html/details-nested-2-expected.txt: * LayoutTests/platform/mac/fast/html/details-no-summary1-expected.txt: * LayoutTests/platform/mac/fast/html/details-no-summary2-expected.txt: * LayoutTests/platform/mac/fast/html/details-no-summary3-expected.txt: * LayoutTests/platform/mac/fast/html/details-no-summary4-expected.txt: * LayoutTests/platform/mac/fast/html/details-open-javascript-expected.txt: * LayoutTests/platform/mac/fast/html/details-open1-expected.txt: * LayoutTests/platform/mac/fast/html/details-open2-expected.txt: * LayoutTests/platform/mac/fast/html/details-open3-expected.txt: * LayoutTests/platform/mac/fast/html/details-open4-expected.txt: * LayoutTests/platform/mac/fast/html/details-open5-expected.txt: * LayoutTests/platform/mac/fast/html/details-open6-expected.txt: * LayoutTests/platform/mac/fast/html/details-position-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-child-1-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-child-2-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-1-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-2-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-3-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-4-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-5-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-6-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-child-1-expected.txt: * LayoutTests/platform/mac/fast/html/details-remove-summary-child-2-expected.txt: * LayoutTests/platform/mac/fast/html/details-replace-summary-child-expected.txt: * LayoutTests/platform/mac/fast/html/details-replace-text-expected.txt: * LayoutTests/platform/mac/fast/html/details-writing-mode-expected.txt: * LayoutTests/platform/mac/fast/html/details-writing-mode-mixed-expected.txt: * LayoutTests/platform/mac/fast/multicol/span/clone-summary-expected.txt: * LayoutTests/platform/wpe/TestExpectations: * LayoutTests/platform/wpe/fast/html/details-add-summary-10-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-add-summary-2-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-add-summary-3-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-add-summary-4-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-add-summary-5-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-add-summary-6-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-add-summary-7-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-add-summary-8-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-add-summary-9-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-no-summary4-expected.txt: * LayoutTests/platform/wpe/fast/html/details-open-javascript-expected.txt: * LayoutTests/platform/wpe/fast/html/details-open2-expected.txt: * LayoutTests/platform/wpe/fast/html/details-open4-expected.txt: * LayoutTests/platform/wpe/fast/html/details-remove-summary-2-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-remove-summary-3-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-remove-summary-4-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-remove-summary-5-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-remove-summary-6-and-click-expected.txt: Added. * LayoutTests/platform/wpe/fast/html/details-replace-summary-child-expected.txt: * LayoutTests/platform/wpe/fast/html/details-replace-text-expected.txt: * LayoutTests/tables/table-col-indent-crash-expected.txt: * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::determineAccessibilityRole): * Source/WebCore/css/CSSPseudoSelectors.json: * Source/WebCore/css/html.css: (details, summary): (details > summary:first-of-type): (details[open] > summary:first-of-type): (frameset, frame): (frameset): (iframe): (details): Deleted. (summary): Deleted. (summary::-webkit-details-marker): Deleted. * Source/WebCore/css/process-css-pseudo-selectors.py: * Source/WebCore/html/HTMLDetailsElement.cpp: (WebCore::HTMLDetailsElement::didAddUserAgentShadowRoot): (WebCore::HTMLDetailsElement::attributeChanged): (WebCore::HTMLDetailsElement::createElementRenderer): Deleted. * Source/WebCore/html/HTMLDetailsElement.h: * Source/WebCore/html/HTMLSummaryElement.cpp: (WebCore::HTMLSummaryElement::create): (): Deleted. (WebCore::HTMLSummaryElement::createElementRenderer): Deleted. (WebCore::HTMLSummaryElement::didAddUserAgentShadowRoot): Deleted. * Source/WebCore/html/HTMLSummaryElement.h: * Source/WebCore/html/shadow/DetailsMarkerControl.cpp: Removed. * Source/WebCore/html/shadow/DetailsMarkerControl.h: Removed. * Source/WebCore/html/shadow/detailsElementShadow.css: Added. (:host summary): (:host([open]) summary): * Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp: * Source/WebCore/rendering/RenderDetailsMarker.cpp: Removed. * Source/WebCore/rendering/RenderDetailsMarker.h: Removed. * Source/WebCore/rendering/RenderTreeAsText.cpp: (WebCore::RenderTreeAsText::writeRenderObject): * Source/WebCore/style/UserAgentStyle.cpp: (WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement): Canonical link: https://commits.webkit.org/286869@main
1 parent 896e97e commit cd2f382

273 files changed

Lines changed: 3231 additions & 3208 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎LayoutTests/TestExpectations‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -922,12 +922,7 @@ imported/w3c/web-platform-tests/html/rendering/replaced-elements/attributes-for-
922922
webkit.org/b/252594 imported/w3c/web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/video-inline-size-containment-no-crash.html [ Skip ]
923923
imported/w3c/web-platform-tests/html/rendering/replaced-elements/embedded-content/cross-domain-iframe.sub.html [ ImageOnlyFailure ]
924924
imported/w3c/web-platform-tests/html/rendering/replaced-elements/embedded-content/tall-cross-domain-iframe-in-scrolled.sub.html [ ImageOnlyFailure ]
925-
imported/w3c/web-platform-tests/html/rendering/the-details-element/details-page-break-after-1-print.html [ ImageOnlyFailure ]
926-
imported/w3c/web-platform-tests/html/rendering/the-details-element/details-page-break-after-2-print.html [ ImageOnlyFailure ]
927-
imported/w3c/web-platform-tests/html/rendering/the-details-element/details-page-break-before-1-print.html [ ImageOnlyFailure ]
928-
imported/w3c/web-platform-tests/html/rendering/the-details-element/details-page-break-before-2-print.html [ ImageOnlyFailure ]
929925
imported/w3c/web-platform-tests/html/rendering/the-details-element/details-display-type-001.html [ ImageOnlyFailure ]
930-
imported/w3c/web-platform-tests/html/rendering/the-details-element/details-display-type-002.html [ ImageOnlyFailure ]
931926
imported/w3c/web-platform-tests/html/rendering/the-details-element/details-pseudo-elements-001.html [ ImageOnlyFailure ]
932927
imported/w3c/web-platform-tests/html/rendering/the-details-element/details-pseudo-elements-002.html [ ImageOnlyFailure ]
933928
imported/w3c/web-platform-tests/html/rendering/the-details-element/details-pseudo-elements-003.html [ ImageOnlyFailure ]

‎LayoutTests/accessibility/ios-simulator/aria-details-toggle-summary-expected.txt‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,4 @@ PASS successfullyParsed is true
88

99
TEST COMPLETE
1010
Details example
11+

‎LayoutTests/fast/css-grid-layout/grid-was-populated-assert-expected.txt‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,4 @@ This test passes if it does not crash in debug mode.
22

33

44

5+

‎LayoutTests/fast/html/details-clone-expected.txt‎

Lines changed: 0 additions & 4 deletions
This file was deleted.

‎LayoutTests/fast/html/details-clone.html‎

Lines changed: 0 additions & 32 deletions
This file was deleted.

‎LayoutTests/fast/html/details-inline-expected.html‎

Lines changed: 0 additions & 15 deletions
This file was deleted.

‎LayoutTests/fast/html/details-inline.html‎

Lines changed: 0 additions & 15 deletions
This file was deleted.

‎LayoutTests/fast/multicol/crash-in-vertical-writing-mode-expected.txt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
PASS if no
2-
crash
1+
2+
PASS if no crash

‎LayoutTests/fast/multicol/crash-in-vertical-writing-mode.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,12 @@
2626
</head>
2727
<body>
2828
<details>
29-
<summary>PASS if no</summary>
29+
<summary>-------</summary>
3030
</details>
3131

3232
<span>
3333
<table>
34-
<caption>crash</caption>
34+
<caption>PASS if no crash</caption>
3535
</table>
3636
</span>
3737

‎LayoutTests/http/tests/security/cross-origin-blob-transfer-expected.txt‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,4 @@ Details
1414
Result Test Name Message
1515
Pass Test for creating blob in iframe and then transferring it cross-origin.
1616
Asserts run
17+

0 commit comments

Comments
 (0)