-
Notifications
You must be signed in to change notification settings - Fork 57
Update WEC-Sim Applications CI to reference the main branch #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| # WEC-Sim_Applications | ||
|
|
||
| [](https://github.com/WEC-Sim/WEC-Sim_Applications/actions/workflows/run-tests-master.yml) | ||
| [](https://github.com/WEC-Sim/WEC-Sim_Applications/actions/workflows/run-tests-main.yml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akeeste, you either need to rename the workflow file to run-tests-main.yml or leave the links to the files unaltered.
|
I assume you're going to push this to |
|
Yes before merging I'll make the main branch and make this PR go into main |
|
@akeeste can you resubmit this PR against the new |
|
Thanks @H0R5E! I reran the tests here and the documentation tests on WEC-Sim/WEC-Sim#1235. Everything seems to be passing now. The last thing before merging #59 and WEC-Sim/WEC-Sim#1235, is to update the default branch on the Applications repo to main. If you can rename master directly to main, it looks like we'll have the added benefit of having API or web requests to master automatically redirect to the main branch https://github.com/github/renaming?tab=readme-ov-file#renaming-existing-branches |
|
I'm not sure how renaming 'master' to 'main' will go if the 'main' branch already exists. If we need to take a couple extra steps to get the API / web requests automatically redirecting, it's worth it; e.g.
|
|
@akeeste, I'm on it. |
|
@akeeste, I found another |
Good catch, done! I did one more search across all Applications repo files but did not find any other references to master. let me know if you catch anything else. |
|
I also just confirmed that this repo's Mooring test does not checkout a specific master or main branch from the WEC-Sim/MoorDyn repo. There's only one branch and the default is always used for the test, so that repo should not affect this PR |
|
@akeeste, I'm going to merge this now. Thanks for sorting this out and the tip about renaming the branches. |
This PR updates the CI workflows for the Applications repo and any documentation references within it to reference the main branches WEC-Sim/WEC-Sim#1215