Skip to content

Conversation

@akeeste
Copy link
Contributor

@akeeste akeeste commented Feb 28, 2024

This PR addresses a few outstanding names changes described in #1215 on updating master to main.

It updates every reference to the master branch in our repo, except in release_notes.rst since the master branch was valid at the time of those releases.

Most of the lines changed come from correcting an old merge conflict in a LIS file

@akeeste
Copy link
Contributor Author

akeeste commented Mar 5, 2024

@H0R5E we renamed our "master" branch to "main". Can you review this PR and

@H0R5E
Copy link
Contributor

H0R5E commented Mar 5, 2024

@akeeste, as I said in Applications, you might want to consider renaming run-tests-master.yml to run-tests-main.yml and then updating the README.

To redirect the docs, you're going to have to change this line so that the url field is now url=./main/index.html".

EDIT: I would say that the CI is fixed, given it ran successfully on this PR.

Copy link
Contributor

@H0R5E H0R5E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comments.

@H0R5E
Copy link
Contributor

H0R5E commented Mar 6, 2024

@akeeste you will also need to update this line to reference main rather than master. I only just remembered, sorry.

@H0R5E
Copy link
Contributor

H0R5E commented Mar 6, 2024

@akeeste, I've added akeeste#13 which makes the change I suggested above and also adds a second redirect from /master/index.html to /main/index.html. This should mean that any links that went straight to master instead of the root index will be redirected.

@H0R5E
Copy link
Contributor

H0R5E commented Mar 6, 2024

One last comment, Adam, is that you will need to sync the dev branch after merging this, otherwise its docs builds won't create the main branch version.

H0R5E and others added 3 commits March 6, 2024 13:49
* Add second redirect for old /mastet/index.html route

* Build main branch rather than master

* Make master directory before copy

* Make url redirect relative to root
@akeeste
Copy link
Contributor Author

akeeste commented Mar 6, 2024

Thanks for your help @H0R5E! Once this is merged, I'll pull this and a few other bugfixes from master into dev.

Since the docs will now redirect, I finished changing every reference to the old docs here and on WEC-Sim/WEC-Sim_Applications#59. The test to build the current branch docs is failing because it's trying to reference the main branch on the Applications repo, which does not exist yet. It will pass once the WEC-Sim_Applications branch name is renamed.

Unfortunately from the labs, only @kmruehl has access to the Applications repo to rename master to main, and is unable to for two more weeks. @H0R5E do you have access here to do this?

@H0R5E
Copy link
Contributor

H0R5E commented Mar 13, 2024

@akeeste, sorry for the delay in replying. I'll add a main branch to the repo now and we can check it's working OK, prior to changing the default.

@akeeste
Copy link
Contributor Author

akeeste commented Mar 13, 2024

I've only found one more reference to the master branch documentation. It's a comment within the WECSim_Lib_PTOSim.slx but I can't find it for the life of me. I suggest we let that go for now since it should redirect anyways, and it's very unlikely to be used or found by anyone

@H0R5E
Copy link
Contributor

H0R5E commented Mar 15, 2024

I suggest we let that go for now since it should redirect anyways, and it's very unlikely to be used or found by anyone

@akeeste, agreed. We can tidy up any little things in the future, and this is important to get merged ASAP. Thanks for the great work.

@H0R5E H0R5E merged commit a113b54 into WEC-Sim:main Mar 15, 2024
H0R5E added a commit to H0R5E/WEC-Sim that referenced this pull request Mar 15, 2024
* update CI to use main branch
* update simulationClass to reference git commits on main
* fix cubes.LIS file with merge conflicts
* update repository tree references in docs from master to main
* update readme and github workflow to run-tests-main.yml
* update redirect in gh-pages-redirect.html
* Add second redirect for old /mastet/index.html route
* Build main branch rather than master
* update other references to documentation

---------

Co-authored-by: Mathew Topper <dataonlygreater@gmail.com>
H0R5E added a commit to H0R5E/WEC-Sim that referenced this pull request Mar 15, 2024
* cherry picked from main branch
* update CI to use main branch
* update simulationClass to reference git commits on main
* fix cubes.LIS file with merge conflicts
* update repository tree references in docs from master to main
* update readme and github workflow to run-tests-main.yml
* update redirect in gh-pages-redirect.html
* Add second redirect for old /mastet/index.html route
* Build main branch rather than master
* update other references to documentation

---------

Co-authored-by: Mathew Topper <dataonlygreater@gmail.com>
H0R5E added a commit that referenced this pull request Mar 15, 2024
As part of #1235, a sphinx option was incorrectly renamed from master_doc to main_doc. This PR corrects this using the root_doc option, available in Sphinx >= 4.
H0R5E added a commit that referenced this pull request Mar 15, 2024
As part of #1235, a sphinx option was incorrectly renamed from master_doc to main_doc. This PR corrects this using the root_doc option, available in Sphinx >= 4.
H0R5E added a commit to H0R5E/WEC-Sim that referenced this pull request Mar 15, 2024
As part of WEC-Sim#1235, a sphinx option was incorrectly renamed from master_doc to main_doc. This PR corrects this using the root_doc option, available in Sphinx >= 4.
H0R5E added a commit that referenced this pull request Mar 15, 2024
* Update master to main (#1235)
* Rename incorrect main_doc option to root_doc (#1241)

---------

Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com>
@H0R5E
Copy link
Contributor

H0R5E commented Mar 15, 2024

@akeeste, I've applied this to the dev branch in #1240, FYI.

@akeeste akeeste deleted the update_CI_to_main branch March 20, 2024 15:46
@kmruehl
Copy link
Collaborator

kmruehl commented Mar 22, 2024

@akeeste and @H0R5E thank you both for resolving these issues while I was OOO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants