Remove passive yaw tests from WEC-Sim repo #730
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* change to workspace blocks decimation to sample time * clean up bemio.m clears * update wave elevation calculations for variable step solver * update simu.time to be actual simulation time
Collaborator
|
Thanks @akeeste I'll work on merging this, but I want to first make sure we've migrated the passive yaw test over to the applications repo as a regression test. Right now the passive yaw test on the applications repo is just a compilation test. To Do:
|
) * adding spherical constraint, cable block, and cable ex * updating to v4.3 * update lib to v4.3, mask funcs, etc. cleanup cableClass, add preTension, etc :q * fix embedded post-process command to work with cable class * fix library links, library 2019b * resolving library issue * resolving library issues * working on cable pr * fixing issues with RM3_3dof_cable example * fixing issues with RM3_cable_external_constraint example * passing constraints to cable class * cable class cleanup * more cable class cleanup * more cleanup cable * library cleanup * swapping base and follower in cable class and library * added spherical pto and update cable class * remove stl and use spherical solid block * removing 3dof and more cable cleanup * removing rotDisp * update documentation and images * updating doc and more cableClass cleanup * cleaning up api doc for all classes * resolving initDisp issues * save library as 2020a and create cable sub-library * creating ptos sublibrary * creating constraints sublibrary * adding library fwding for ptos and constraints * remove unused class parameters, update simulink outputs * restructure cable block with PTO response * rename responseClass struct * run from simulink for cable * removing cable example will be moved to applications repo * adding cable class doc to code structure Co-authored-by: dforbush2 <dforbus@sandia.gov> Co-authored-by: akeeste <akeeste@sandia.gov>
* add nlHydro flag to rigid and flex body masks * resolving wec-sim library issue Co-authored-by: Kelley Ruehl <kmruehl@sandia.gov>
Collaborator
|
Passive yaw test migrated to applications repo with WEC-Sim/WEC-Sim_Applications#15 |
Collaborator
|
This PR does the following:
|
Collaborator
|
@akeeste this pr is no longer current with dev so I'm going to close and re-open a new one |
Contributor
Author
Collaborator
|
@akeeste I agree, I'm not sure why the conflicts were not resolved automatically, but the merge shows/showed 82 files changed. It was easier to just re-open than resolve the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the passive yaw test from the WEC-Sim repo to the applications repo, where it already exists.
It also makes a minor fix to the BEMIO test so that plot visibility is restored properly after the test runs.