Skip to content

adding spherical constraint, cable block, and spherical pto #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kmruehl merged 38 commits into from
Oct 6, 2021
Merged

adding spherical constraint, cable block, and spherical pto #712

kmruehl merged 38 commits into from
Oct 6, 2021

Conversation

@kmruehl
Copy link
Collaborator

@kmruehl kmruehl commented Sep 22, 2021 •
edited
Loading

This is a continuation of #675, refer to discussion on prior PR.

Prior to the v4.4 release we need to:

@kmruehl kmruehl added Constraint Class Constraint Class (constraintClass.m) Feature new feature request labels Sep 22, 2021
kmruehl and others added 20 commits September 22, 2021 14:46
@kmruehl
resolving library issues
c6e99bf
@kmruehl
working on cable pr
3365423
@kmruehl
fixing issues with RM3_3dof_cable example
a0f5e2d
@kmruehl
fixing issues with RM3_cable_external_constraint example
d6f8808
@kmruehl
passing constraints to cable class
2f112aa
@kmruehl
cable class cleanup
9e033c7
@kmruehl
more cable class cleanup
e0740db
@kmruehl
more cleanup cable
e50c779
@kmruehl
library cleanup
f00e840
@kmruehl
swapping base and follower in cable class and library
f090a12
@kmruehl
added spherical pto and update cable class
741e820
@kmruehl
remove stl and use spherical solid block
b4ec2f1
@kmruehl
removing 3dof and more cable cleanup
bf9705e
@kmruehl
removing rotDisp
f8e61c3
@dforbush2
Merge pull request #1 from kmruehl/feature_cable
ee33442 
Will add docs to dforbush fork post-merge
@dforbush2
update documentation and images
0f6c2c8
@dforbush2
Merge branch 'feature_cable' of https://github.com/dforbush2/WEC-Sim …
8fe5f4b 
…into feature_cable
@kmruehl
updating doc and more cableClass cleanup
def61b0
@kmruehl
cleaning up api doc for all classes
1ff2893
@kmruehl
resolving initDisp issues
fe8227d
@kmruehl
Copy link
Collaborator Author

kmruehl commented Sep 28, 2021

All tests are passing locally, I'm going to work on resolving the merge conflicts now

@kmruehl
Copy link
Collaborator Author

kmruehl commented Sep 28, 2021

@akeeste I've resolved conflicts with the dev branch, so you should be good to work on this PR now.

@kmruehl
Copy link
Collaborator Author

kmruehl commented Sep 28, 2021

@akeeste one more minor library update to include the fwding table. Tests should pass now https://github.com/WEC-Sim/WEC-Sim/actions/runs/1283845806

@kmruehl kmruehl mentioned this pull request Sep 28, 2021
Closed
5 tasks
@akeeste akeeste mentioned this pull request Sep 28, 2021
Merged
2 tasks
@kmruehl kmruehl changed the title adding spherical constraint, cable block, and cable ex adding spherical constraint, cable block, and spherical pto Sep 29, 2021
@kmruehl kmruehl added Cable Class Cable Class (cableClass.m) PTO Class Power Take-off Class (ptoClass.m) labels Oct 5, 2021
@kmruehl kmruehl merged commit 24419d0 into WEC-Sim:dev Oct 6, 2021
@kmruehl
Copy link
Collaborator Author

kmruehl commented Oct 6, 2021

@dforbush2 and @akeeste thanks for your work on this PR, it's finally merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akeeste akeeste Awaiting requested review from akeeste

@dforbush2 dforbush2 Awaiting requested review from dforbush2

Assignees

No one assigned

Labels

Cable Class Cable Class (cableClass.m) Constraint Class Constraint Class (constraintClass.m) Feature new feature request PTO Class Power Take-off Class (ptoClass.m)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kmruehl @dforbush2 @akeeste