You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the nlHydro flag to body masks, so that it can be used in the Run From Simulink feature.
Only rigid and flexible body masks changed. A single mask parameter (nlHydro) was added to each. Visibility callbacks updated to hide the nlHydro flag when a body is drag or nonhydro.
@akeeste after a lot of (frustrating) troubleshooting I determined the issue. While the source/lib/WEC-Sim/WECSim_Lib_Body_Elements.slx sub-library block was in the source directory, and had been updated correctly to include nonlinear hydro, for some reason none of the sub-library blocks were being called on from WECSim_Lib.slx. This resulted in the strange error saying there was no nonlinear hydro from the mask, when WECSim_Lib_Body_Elements.slx clearly included it... because the WECSim_Lib_Body_Elements.slx sub-library was never being used.
Turns out it was an easy fix was I was able to identify the issue. This must have been the result of a failed merged, possibly one that was done automatically. Anyway, we should be good now. Thank you!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the nlHydro flag to body masks, so that it can be used in the Run From Simulink feature.
Only rigid and flexible body masks changed. A single mask parameter (
nlHydro) was added to each. Visibility callbacks updated to hide the nlHydro flag when a body is drag or nonhydro.