Fix irregular wave elevation with multiple directions #1403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This is related to #1406, MATLAB 2022a and 2022b ubunto tests are failing |
* Updates the Ubuntu and Matlab versions
akeeste
added a commit
that referenced
this pull request
Mar 25, 2025
* updated the intro * fixes a bug with the QTF interpolation function (#1396) * fix #1288, cleanup waveclass (main) (#1417) * fix on pDis function call * preliminary fix for issue #1288 * Update readAQWA.m (#1253) * body mask fixes for #1346 * add warning when variable hydro turned on for drag or nonhydro bodies * flex body - add missing mask lines, define h5 button callback * fix #1288 cleanup waveClass * adding bodyClass, should match --------- Co-authored-by: jtgrasb <87095491+jtgrasb@users.noreply.github.com> Co-authored-by: akeeste <akeeste@sandia.gov> * Fix irregular wave elevation with multiple directions (#1403) * Fix irregular wave elevation with multiple directions * Updates the Ubuntu and Matlab versions (#1420) * Updates the Ubuntu and Matlab versions --------- Co-authored-by: Mohamed Shabara <84589678+MShabara@users.noreply.github.com> * new body class constructor, no need for h5file * removed disp used in debugging * short check to ensure hydro struct provided is the right hydro struct * cleaned up one comment * rename hydrodata to hydroinput in body constructor * move input checking to body.checkInputs() * make body.hydroStruct a private variable * make body.hydroStruct public and alphabetize * clear body.hydroStruct once used * brief documentation * function to build body class hydro format struct from BEMIO format * update hydro to hydroData function for other features * fix bug in reading water depth, ex.irf.t and dofs * make readH5ToStruct function identically to writeBEMIOH5 for GBM modes * read GBM data and irf times correctly * reference function in documentation * update function docstring --------- Co-authored-by: Shabara <mshabara@nrel.gov> Co-authored-by: Mohamed Shabara <84589678+MShabara@users.noreply.github.com> Co-authored-by: dforbush2 <dforbus@sandia.gov> Co-authored-by: jtgrasb <87095491+jtgrasb@users.noreply.github.com> Co-authored-by: akeeste <akeeste@sandia.gov>
MShabara
added a commit
that referenced
this pull request
Mar 28, 2025
* updated the intro * fixes a bug with the QTF interpolation function (#1396) * fix #1288, cleanup waveclass (main) (#1417) * fix on pDis function call * preliminary fix for issue #1288 * Update readAQWA.m (#1253) * body mask fixes for #1346 * add warning when variable hydro turned on for drag or nonhydro bodies * flex body - add missing mask lines, define h5 button callback * fix #1288 cleanup waveClass * adding bodyClass, should match --------- Co-authored-by: jtgrasb <87095491+jtgrasb@users.noreply.github.com> Co-authored-by: akeeste <akeeste@sandia.gov> * Fix irregular wave elevation with multiple directions (#1403) * Fix irregular wave elevation with multiple directions * Updates the Ubuntu and Matlab versions (#1420) * Updates the Ubuntu and Matlab versions --------- Co-authored-by: Mohamed Shabara <84589678+MShabara@users.noreply.github.com> * Enhances function flexibility * Fix warnings * change coercion for consistency with documentation --------- Co-authored-by: Shabara <mshabara@nrel.gov> Co-authored-by: Mohamed Shabara <84589678+MShabara@users.noreply.github.com> Co-authored-by: dforbush2 <dforbus@sandia.gov> Co-authored-by: jtgrasb <87095491+jtgrasb@users.noreply.github.com> Co-authored-by: akeeste <akeeste@sandia.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the irregular wave elevation function, which was failing for multiple directions. This was causing the Morison Element applications case to fail - see #1400. The OSWEC case was also erroring because it had multiple wave directions.
@dforbush2 I traced this change back to our PR #1332, but I don't think it was intentional since you created a new function
waves.waveElevFullDir()for the imported full directional wave elevation.