elevationToSpectrum.m Function Enhancements #1423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix on pDis function call * preliminary fix for issue WEC-Sim#1288 * Update readAQWA.m (WEC-Sim#1253) * body mask fixes for WEC-Sim#1346 * add warning when variable hydro turned on for drag or nonhydro bodies * flex body - add missing mask lines, define h5 button callback * fix WEC-Sim#1288 cleanup waveClass * adding bodyClass, should match --------- Co-authored-by: jtgrasb <87095491+jtgrasb@users.noreply.github.com> Co-authored-by: akeeste <akeeste@sandia.gov>
* Fix irregular wave elevation with multiple directions * Updates the Ubuntu and Matlab versions (WEC-Sim#1420) * Updates the Ubuntu and Matlab versions --------- Co-authored-by: Mohamed Shabara <84589678+MShabara@users.noreply.github.com>
Contributor
Author
|
I realized I accidentally turned data and time from a row vector to a column vector. |
Collaborator
|
Thank you @Gusmano-2-OSU. This looks like a great addition. However, can you revise this PR to go into dev instead of main? |
Collaborator
|
Thank you for changing the PR to dev |
MShabara
approved these changes
Mar 28, 2025
Contributor
MShabara
left a comment
There was a problem hiding this comment.
@Gusmano-2-OSU Thank you for submitting this PR, the new feature is useful and coded nicely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes slight enhancements to the elevationToSpectrum.m function
Now coerces
dataandtimevectors into the correct shape.Adds an option for users to remove spectral leakage from the function. Default is
false.Fixes miscellaneous warnings.