removed finalizer from core k8s resources#1839
Merged
Conversation
9bed397 to
4fbfd83
Compare
bb2bde7 to
bf7390b
Compare
9a8b813 to
500bb28
Compare
vrutkovs
requested changes
Feb 25, 2026
internal/controller/operator/factory/reconcile/statefulset_pvc_expand_test.go
Show resolved
Hide resolved
15496b5 to
53372c8
Compare
191b9ac to
8a2ff1f
Compare
8a2ff1f to
c7bed6c
Compare
vrutkovs
approved these changes
Feb 27, 2026
AndrewChubatiuk
added a commit
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #835, #1773, #1845
this PR removes finalizer on core resources. Finalizer only complicates reconcile and may lead to dangling resources. Additionally keeping removed resource till the next reconciliation is not needed as no additional cleanup actions are performed. with this change finalizer will be removed from existing core resources and will not be added to new ones, but CR deletion still performs finalizer removal for smooth migration
made controller.disableCRDOwnership flag noop, removed owner reference from cluster wide resources and using selector instead.
In later versions we could keep only finalizer removal for CR and drop other API calls
Summary by cubic
Remove operator-added finalizers from core Kubernetes resources to prevent stuck deletions and simplify reconciliation (addresses #835). Finalizers remain only on CRs; existing core objects have legacy finalizers removed during reconcile, and new ones are created without them.
Refactors
Dependencies
Written for commit c7bed6c. Summary will update on new commits.