Skip to content

refactor finalize package #1773

@AndrewChubatiuk

Description

@AndrewChubatiuk

list of potential improvements for internal/controller/operator/factory/finalize package:

  • remove finalizers from core resources, as they don't provide any value, leads to dangling resources during cleanup or removal and rjust equire extra patch request to remove finalizers
  • replace ownerreferences for cluster wide resources with selectors. cluster wide resources can only have a cluster wide resources as an owner, in our case we're using CRD as owner reference, which makes no sense. replace it with label selector.
  • some namespaced resources use selectors instead of owner reference to define which objects should be removed, replace this logic with ownerreferences check

Metadata

Metadata

Labels

waiting for releaseThe change was merged to upstream, but wasn't released yet.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions