Conversation
Valorith
pushed a commit
that referenced
this pull request
Mar 22, 2026
47 test cases across 15 sections covering all evolution types (XP, kill count, mob race, zone), activation/timer mechanics, evolution completion, augment handling, XP transfer window, merchant/parcel interactions, persistence, GM commands, edge cases, and regression tests for PRs EQEmu#4607, EQEmu#4992, #8, and #98. Includes ready-to-run SQL setup for 5 test item families with low thresholds for fast manual testing. https://claude.ai/code/session_017wrKmjuMTicYybGCRiBBFG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports EQEmu#5017 into this fork.
Credit to Nekkola
Description
An outstanding item from PR4992 was item EQEmu#4. An issue where creating a saylink from an evolving item would inject a random character as character EQEmu#1.
Fixes the above noted item from PR4992. Saylinks should work correctly for evolving items.
In testing, noticed that when selling an evolving item with progression, if the player had the merchant window open and clicked inspect, the progression would show incorrectly. This has been fixed to show progression at 0. This was not present if the merchant window was opened after selling the item.
Similar issue with parceling an evolving item with progression. If the player receiving the item had the parcel window open, the inspect would show the incorrect progression. This was not present if the player opens the parcel window after receiving the item.