Skip to content

[Bug Fix] Evolving Items SayLink#5017

Closed
neckkola wants to merge 1 commit intoEQEmu:masterfrom
neckkola:Fix_EvolveSayLink
Closed

[Bug Fix] Evolving Items SayLink#5017
neckkola wants to merge 1 commit intoEQEmu:masterfrom
neckkola:Fix_EvolveSayLink

Conversation

@neckkola
Copy link
Copy Markdown
Contributor

Description

An outstanding item from PR4992 was item #4. An issue where creating a saylink from an evolving item would inject a random character as character #1.

Fixes # (issue)

  1. Fixes the above noted item from PR4992. Saylinks should work correctly for evolving items.
  2. In testing, noticed that when selling an evolving item with progression, if the player had the merchant window open and clicked inspect, the progression would show incorrectly. This has been fixed to show progression at 0. This was not present if the merchant window was opened after selling the item.
  3. Similar issue with parceling an evolving item with progression. If the player receiving the item had the parcel window open, the inspect would show the incorrect progression. This was not present if the player opens the parcel window after receiving the item.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

evolve_say_error evolve_say_fix

Clients tested:
RoF2

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

Tested ok
@neckkola neckkola closed this Sep 27, 2025
@neckkola neckkola deleted the Fix_EvolveSayLink branch September 27, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants