Accessibility issue: image controls disappear when activated by keyboard (fixes #1076)#1158
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
demiankatz
left a comment
There was a problem hiding this comment.
@rNegi-bl, it appears that you merged this before it was tested and reviewed. Please wait for approval before merging. At least a little bit more work appears to be needed here -- see review below. Can you please open a follow-up PR to address that issue and any others that may come up during testing?
|
|
||
| updateResponsiveView(): void { | ||
| this.setNavigatorVisible(); | ||
| this.viewer.autoHideControls = true; |
There was a problem hiding this comment.
It looks like this change has removed the original logic to disable auto-hide on mobile devices. Perhaps you should initialize this like:
this.viewer.autoHideControls = this.extension.isDesktopMetric();
|
@rNegi-bl Hi Rahul, I was just wondering about the desired functionality of this fix when it comes to using the keyboard for the image adjustment because when you close the image adjustment the image controls disappear again, it looks good for the other controls :) |
Yes, I'm seeing the same thing -- I think there may be two different parts to the problem, as well -- one issue is that I wonder if closing the adjust image modal should re-focus the adjust image button, so the user is in the same context they were before opening the control. The other issue is that after opening and closing the modal, the adjustImageButton no longer stays visible when re-focused; it's like interacting with the modal somehow breaks the event logic. |
|
Actually, to clarify, I see that the adjustImageButton fails to stay visible when focused whether or not you open the modal first... so I think there are definitely two separate issues to consider here -- the focus-after-close and the general failure of visibility. |
|
I am seeing some added styling on the prev/next buttons here, the arrows are more filled in and have a line across them But this may have occurred when the other image adjustment buttons (home, contrast etc) were added. |
|
@jamesmisson, I think the styling of the buttons is unrelated to the changes here -- I believe that came in when the elements were changed from |
No description provided.