Add focus highlight to previous/next buttons in center panel #1146
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @Saira-A -- looks much better, but a couple of possible suggestions for finishing touches...
|
|
||
| this.$nextButton = $('<div class="paging btn next" tabindex="0"></div>'); | ||
| this.$nextButton = $( | ||
| `<button class="btn btn-default paging next" tabindex="0" title="${this.content.next}" style="position: relative; padding-right: 0px; padding-top: 0px; display: inline-block; top: 131.5px;"> |
There was a problem hiding this comment.
I think you can remove the tabindex="0" from these buttons because button elements automatically have a tab index.
I also wonder if it would be a good idea to move the hard-coded styles out of the code here and into the appropriate LESS files.
|
@demiankatz, I have tested the fix, and it works as expected. It makes sense to have the focus highlight move to the next or previous buttons when clicked within the image. Thanks @Saira-A. |
|
Done, thanks @LanieOkorodudu @demiankatz |
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @Saira-A, looking great!
I think there's still a problem where the next/previous buttons can fade out of view before you have time to focus on them, but that's a separate issue that may already have its own ticket, so I don't think we need to solve that problem here -- this fixes a different, unrelated problem and might as well be merged as-is!
Fixes #1077