Skip to content

Add function to validate timedelta for overflow#3295

Merged
johannaengland merged 3 commits intomasterfrom
cleanup/utils-validate-timedelta-overflow
Feb 26, 2025
Merged

Add function to validate timedelta for overflow#3295
johannaengland merged 3 commits intomasterfrom
cleanup/utils-validate-timedelta-overflow

Conversation

@johannaengland
Copy link
Copy Markdown
Contributor

@johannaengland johannaengland commented Feb 25, 2025

As suggested by @hmpf in #3289.

I will soon make all the other time input PRs (#3285, #3287 and #3289) dependent on this then.

@johannaengland johannaengland self-assigned this Feb 25, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 25, 2025 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 3 0 0.62s
✅ PYTHON ruff 3 0 0.01s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 25, 2025 •
edited
Loading

Test results

   12 files     12 suites   11m 48s ⏱️
2 168 tests 2 168 ✅ 0 💤 0 ❌
5 979 runs  5 979 ✅ 0 💤 0 ❌

Results for commit ce89f5b.

♻️ This comment has been updated with latest results.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.73%. Comparing base (2aa3866) to head (ce89f5b).
Report is 149 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3295      +/-   ##
==========================================
- Coverage   60.75%   60.73%   -0.03%     
==========================================
  Files         606      606              
  Lines       43756    43757       +1     
  Branches       48       48              
==========================================
- Hits        26586    26577       -9     
- Misses      17158    17168      +10     
  Partials       12       12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hmpf
Copy link
Copy Markdown
Contributor

hmpf commented Feb 26, 2025

Good location for the utility function!

As me and @lunkwill42 discovered, merging a PR that depends on sub-PRs will also automatically close the sub-PRs. Therefore I'll only be reviewing this one =)

Less to do now too what with the validator in play.

@stveit
Copy link
Copy Markdown
Contributor

stveit commented Feb 26, 2025

A docstring stating what error it will raise if the validation fails could be useful

@johannaengland johannaengland added the nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes) label Feb 26, 2025
@johannaengland
Copy link
Copy Markdown
Contributor Author

johannaengland commented Feb 26, 2025

As me and @lunkwill42 discovered, merging a PR that depends on sub-PRs will also automatically close the sub-PRs. Therefore I'll only be reviewing this one =)

Yes, but the others mentioned are not sub-PRs, they are dependent on this PR and will not automatically closed when this one is merged, they will simply change their base to master.

This was referenced Feb 26, 2025
Merged
Closed
@johannaengland johannaengland force-pushed the cleanup/utils-validate-timedelta-overflow branch from 4e20d9e to ce89f5b Compare February 26, 2025 12:07
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 26, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@johannaengland johannaengland mentioned this pull request Feb 26, 2025
Merged
@johannaengland johannaengland merged commit 2819c03 into master Feb 26, 2025
15 of 16 checks passed
@johannaengland johannaengland deleted the cleanup/utils-validate-timedelta-overflow branch February 26, 2025 12:23
@johannaengland johannaengland restored the cleanup/utils-validate-timedelta-overflow branch February 26, 2025 12:28
@johannaengland johannaengland deleted the cleanup/utils-validate-timedelta-overflow branch February 26, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hmpf hmpf hmpf approved these changes

@lunkwill42 lunkwill42 Awaiting requested review from lunkwill42

@stveit stveit Awaiting requested review from stveit

Assignees

@johannaengland johannaengland

Labels

nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johannaengland @hmpf @stveit