Clean number of hours in error log search form #3287
Closed
johannaengland wants to merge 7 commits intoUninett:cleanup/utils-validate-timedelta-overflowfrom
Closed
Clean number of hours in error log search form #3287johannaengland wants to merge 7 commits intoUninett:cleanup/utils-validate-timedelta-overflowfrom
johannaengland wants to merge 7 commits intoUninett:cleanup/utils-validate-timedelta-overflowfrom
Conversation
hmpf
approved these changes
Feb 25, 2025
In case of a user input for an interval
Giving it a timedelta with a big number would already error when calling the function
70d3d20 to
ab9d789
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## cleanup/utils-validate-timedelta-overflow #3287 +/- ##
=============================================================================
+ Coverage 60.73% 60.76% +0.03%
=============================================================================
Files 606 606
Lines 43754 43763 +9
Branches 48 48
=============================================================================
+ Hits 26572 26592 +20
+ Misses 17170 17159 -11
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hmpf
approved these changes
Feb 26, 2025
4e20d9e to
ce89f5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3246. Dependent on #3295.