Skip to content

Clean number of days in account charts form#3285

Merged
johannaengland merged 1 commit intoUninett:masterfrom
johannaengland:bugfix/account-charts-form-days
Feb 26, 2025
Merged

Clean number of days in account charts form#3285
johannaengland merged 1 commit intoUninett:masterfrom
johannaengland:bugfix/account-charts-form-days

Conversation

@johannaengland
Copy link
Copy Markdown
Contributor

@johannaengland johannaengland commented Feb 20, 2025

Dependent on #3295. Closes #3245.

@johannaengland johannaengland force-pushed the bugfix/account-charts-form-days branch from 041d2e1 to 73e69e3 Compare February 26, 2025 11:09
@johannaengland johannaengland changed the base branch from master to cleanup/utils-validate-timedelta-overflow February 26, 2025 11:09
@johannaengland johannaengland requested a review from hmpf February 26, 2025 11:09
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.74%. Comparing base (2819c03) to head (b72410f).
Report is 145 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3285      +/-   ##
==========================================
- Coverage   60.76%   60.74%   -0.03%     
==========================================
  Files         606      606              
  Lines       43757    43762       +5     
  Branches       48       48              
==========================================
- Hits        26590    26583       -7     
- Misses      17155    17167      +12     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@johannaengland johannaengland force-pushed the cleanup/utils-validate-timedelta-overflow branch from 4e20d9e to ce89f5b Compare February 26, 2025 12:07
@johannaengland johannaengland deleted the branch Uninett:master February 26, 2025 12:23
@johannaengland johannaengland changed the base branch from cleanup/utils-validate-timedelta-overflow to master February 26, 2025 12:28
@johannaengland johannaengland force-pushed the bugfix/account-charts-form-days branch from f9dd9cc to b72410f Compare February 26, 2025 13:32
@sonarqubecloud
Copy link
Copy Markdown

@johannaengland johannaengland merged commit 617c8d5 into Uninett:master Feb 26, 2025
14 of 15 checks passed
@johannaengland johannaengland deleted the bugfix/account-charts-form-days branch February 26, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Giving a big number as input for AccountChartsForm causes a 500 error

2 participants