Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

TT-8109 Update documentation of snapshot tool based on newest changes#581

Merged
buraksekili merged 7 commits intomasterfrom
docs/TT-8109/update-snapshot-doc
Mar 14, 2023
Merged

TT-8109 Update documentation of snapshot tool based on newest changes#581
buraksekili merged 7 commits intomasterfrom
docs/TT-8109/update-snapshot-doc

Conversation

@buraksekili
Copy link

@buraksekili buraksekili commented Mar 3, 2023

Description

Depends on #569

Related Issue

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • Make sure you are updating CHANGELOG.md based on your changes.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • If you've changed API models, please update CRDs.
    • make manifests
    • make helm
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...
    • golangci-lint run

buraksekili and others added 4 commits March 3, 2023 14:13
@buraksekili buraksekili marked this pull request as ready for review March 3, 2023 12:42
@buraksekili buraksekili requested a review from a team as a code owner March 3, 2023 12:42
@buraksekili buraksekili requested review from andrei-tyk and removed request for a team March 3, 2023 12:42
@buraksekili buraksekili changed the title Update documentation of snapshot tool based on newest changes TT-8109 Update documentation of snapshot tool based on newest changes Mar 14, 2023
@caroltyk caroltyk self-requested a review March 14, 2023 11:22
caroltyk
caroltyk approved these changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@caroltyk caroltyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@buraksekili buraksekili merged commit a6b3ff7 into master Mar 14, 2023
@buraksekili buraksekili deleted the docs/TT-8109/update-snapshot-doc branch March 14, 2023 11:25
buger pushed a commit that referenced this pull request May 22, 2024
@buraksekili @caroltyk
TT-8109 Update documentation of snapshot tool based on newest changes (…
5698686 
…#581)

* Update documentation for new Snapshot tool

Signed-off-by: Burak Sekili <buraksekili@gmail.com>

* Update README.md

* Added a new installation section

Signed-off-by: Burak Sekili <buraksekili@gmail.com>

---------

Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Co-authored-by: caroltyk <97617859+caroltyk@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrei-tyk andrei-tyk Awaiting requested review from andrei-tyk andrei-tyk was automatically assigned from TykTechnologies/operator-squad

1 more reviewer

@caroltyk caroltyk caroltyk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@buraksekili @caroltyk