This repository was archived by the owner on Oct 11, 2024. It is now read-only.
TT-7365 - Prevent reading k8s config while running snapshot tool#569
Merged
TT-7365 - Prevent reading k8s config while running snapshot tool#569
Conversation
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
andrei-tyk
approved these changes
Feb 21, 2023
letzya
suggested changes
Feb 21, 2023
Co-authored-by: Yaara <yaara@tyk.io>
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
18 tasks
letzya
suggested changes
Mar 3, 2023
Co-authored-by: Yaara <yaara@tyk.io>
letzya
approved these changes
Mar 3, 2023
andrei-tyk
approved these changes
Mar 6, 2023
|
Kudos, SonarCloud Quality Gate passed! |
buger
pushed a commit
that referenced
this pull request
May 22, 2024
* Prevent reading k8s config while running snapshot tool Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Update CHANGELOG according to new changes Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Revert "Prevent reading k8s config while running snapshot tool" This reverts commit 8a1a9e8. * Revert "Revert "Prevent reading k8s config while running snapshot tool"" This reverts commit 297bf9a. * Update CHANGELOG.md Co-authored-by: Yaara <yaara@tyk.io> * update output directory for snapshot tool Signed-off-by: Burak Sekili <buraksekili@gmail.com> * Update CHANGELOG.md Co-authored-by: Yaara <yaara@tyk.io> --------- Signed-off-by: Burak Sekili <buraksekili@gmail.com> Co-authored-by: Yaara <yaara@tyk.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, snapshot tool was reading the k8s config even though it does not require any specific k8s API functionality. So, in order for users to use the snapshot tool, they need to have a running k8s environment; so that the program could read k8s config.
This PR updates the main file of tyk-operator. While running in snapshot mode, it does not do any k8s specific operation.
Related Issue
Motivation and Context
Test Coverage For This Change
Screenshots (if appropriate)
Types of changes
Checklist
master!masterbranch (left side). Also, it would be best if you started your change off our latestmaster.make manifestsmake helmgofmt -s -w .go vet ./...golangci-lint run