Removes config.theme and restructures how theme variables are cached#3947
Merged
ErisDS merged 1 commit intoTryGhost:masterfrom Sep 15, 2014
Merged
Removes config.theme and restructures how theme variables are cached#3947ErisDS merged 1 commit intoTryGhost:masterfrom
ErisDS merged 1 commit intoTryGhost:masterfrom
Conversation
resolves TryGhost#1789 - removes config/theme.js - moves caching of theme variables to api/settings.js which is where the rest of the settings cache occurs. this removes the requirement of having to push changes to cache, now it simply occurs alongside when settings are changed. - updates relevant tests.
ErisDS
added a commit
that referenced
this pull request
Sep 15, 2014
Removes config.theme and restructures how theme variables are cached
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1789
rest of the settings cache occurs. this removes the requirement of having
to push changes to cache, now it simply occurs alongside when settings
are changed.