Skip to content

Revisit config.paths.update and config.theme.update #1789

@ErisDS

Description

@ErisDS

The paths and theme modules are really nicely separated out, and it's great to be able to include them individually, but the update methods are a little awkward, especially when working with subdirectories.

The subdir path can't be pre-assigned to any variables, as it gets reloaded part way through start-up.

config.url shouldn't change whilst the app is running, therefore config.paths.update shouldn't really be needed.

Ideally, config.theme.update shouldn't require being passed the settings object, but circular references are to be avoided.

It would be great to revisit these again in future to see how they could be improved upon.

Metadata

Metadata

Assignees

No one assigned

    Labels

    affects:serverIssues relating to the server or core of Ghost

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions