Skip to content

Update About page styles#3907

Merged
ErisDS merged 1 commit intoTryGhost:masterfrom
PaulAdamDavis:fix-about-styles
Sep 2, 2014
Merged

Update About page styles#3907
ErisDS merged 1 commit intoTryGhost:masterfrom
PaulAdamDavis:fix-about-styles

Conversation

@PaulAdamDavis
Copy link
Member

@PaulAdamDavis PaulAdamDavis commented Sep 1, 2014

References #3568 & #3575

With the move to new global styles, the about page styles got a bit borked. This fixes those.
It also adds hover styling to nicely show contributor names, from this comment and the below gif.

contribs

@novaugust
Copy link
Contributor

novaugust commented Sep 1, 2014

hawt

@nuclearpengy
Copy link

nuclearpengy commented Sep 1, 2014

baie mooi! :-)

@novaugust
Copy link
Contributor

novaugust commented Sep 1, 2014

While you're at it, the icon needs killing :D
screen shot 2014-09-01 at 9 51 10

@novaugust
Copy link
Contributor

novaugust commented Sep 1, 2014

Would you also add titlecasing to the about-environment-detail class?

<div class="about-environment">
    <p>
        <b>Version:</b>
        <span class="about-environment-detail">{{version}}</span>
        <br>
        <b>Environment:</b>
        <span class="about-environment-detail">{{environment}}</span>
        <br>
        <b>Database:</b>
        <span class="about-environment-detail">{{database}}</span>
        <br>
        <b>Mail:</b>
        <span class="about-environment-detail">{{#if mail}}{{mail}}{{else}}Native{{/if}}</span>
    </p>
</div>

@novaugust novaugust mentioned this pull request Sep 1, 2014
Merged
4 tasks
@ErisDS
Copy link
Member

ErisDS commented Sep 1, 2014

@PaulAdamDavis gimme a ping when this is updated & I'll mergify

@ErisDS ErisDS added this to the 0.5.x Feature Release Backlog milestone Sep 1, 2014
@novaugust
Copy link
Contributor

novaugust commented Sep 1, 2014

I also changed the environment details to be dl, dt, dd

@PaulAdamDavis
Copy link
Member Author

PaulAdamDavis commented Sep 1, 2014

Got a few changes to make first, will do those tonight so it's ready for the AM.

@ErisDS
Copy link
Member

ErisDS commented Sep 2, 2014

@PaulAdamDavis is this GTG?

@PaulAdamDavis
Copy link
Member Author

PaulAdamDavis commented Sep 2, 2014

@ErisDS Yup, 👍 from me

@PaulAdamDavis
Update About page styles
9341d05 
Closes #3919

With the move to new global styles, the about page styles got a bit borked. This fixes those.
ErisDS added a commit that referenced this pull request Sep 2, 2014
@ErisDS
Merge pull request #3907 from PaulAdamDavis/fix-about-styles
cfd987b 
Update About page styles
@ErisDS ErisDS merged commit cfd987b into TryGhost:master Sep 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Next Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@PaulAdamDavis @novaugust @nuclearpengy @ErisDS