Skip to content

About ghost page#3575

Merged
ErisDS merged 1 commit intoTryGhost:masterfrom
novaugust:about-ghost
Sep 2, 2014
Merged

About ghost page#3575
ErisDS merged 1 commit intoTryGhost:masterfrom
novaugust:about-ghost

Conversation

@novaugust
Copy link
Contributor

Closes #3568

  • Deleted html placeholders in client
  • Added new grunt task, buildAboutPage, which 1)creates -contributors.hbs partial and 2) downloads contributor avatars
  • buildAboutPage is called by anything that does an emberTemplates task
  • Removed unused code from ghostpaths

  1. query GH API for top contributors between releases (via)
  2. Create hbs partial for user list from 1 @ core/client/templates/-contributors.hbs
  3. Download avatar for each user, and move to client/assets/img/contributors/<name>
  4. Insert ghost config (DB, Version, Environment, Mail

@PaulAdamDavis
Copy link
Member

Couple things, from a UI perspective:

  • Header needs a class settings-content-header, much like this to match the rest
  • Only 20 images, not 30

Aside from those, it looks good to me. 👍

@novaugust
Copy link
Contributor Author

Cheers buddy. I got the drop down to 20 in there already, I'll add the class =)

@ErisDS
Copy link
Member

ErisDS commented Aug 8, 2014

👍

@novaugust
Copy link
Contributor Author

@PaulAdamDavis The about.html needs updating to be brought up to speed with GUI2.

Gruntfile.js Outdated

This comment was marked as abuse.

This comment was marked as abuse.

@PaulAdamDavis
Copy link
Member

I'm clearing up the CSS ready for this. Just a couple HTML changes:

@novaugust
Copy link
Contributor Author

h/t @morficus for telling me I should make a separate dep for this. It had crossed my mind, but without outside influence I wasn't going to. behold! novaugust/top-gh-contribs (gh: is it ghost or github?! (hint: it's github, but inspired by ghost?))

If people think having the code in an external place is a bad idea, I can move it back in. But hey, it's OSS, so if I die, you can always just c/p eh?
I'd also be happy to give ownership to @TryGhost, but then they'd be responsible for yet another repo ;)

@novaugust
Copy link
Contributor Author

@PaulAdamDavis
Copy link
Member

@novaugust So, so so close.

I think I badly communicated the "Buttons next to the env info needs to change the class to btn" bit. It doesn't need to be btn-dark, just btn. My bad 😔

@JohnONolan
Copy link
Member

Pretty sure multi-classes are required, eg. btn btn-default

@PaulAdamDavis
Copy link
Member

@JohnONolan Truedat.

Okay, let's use use btn btn-alt and i'll add that to the global buttons styles and override a couple things for the about page.

@novaugust
Copy link
Contributor Author

@PaulAdamDavis told you you should have done this :P
novaugust@b5c4db5
Does this need a btn class?

@PaulAdamDavis
Copy link
Member

@novaugust It does. I'm a doofus.

Also, another thing, a new thing this time, and that's to add the contributors name which is currently on the <img> tag as a title attr, onto the <a> tag, such as:

<a href="gh.com/user" title="Users Name">
  <img src="/images/user.jpg" alt="Users Name" />
</a>

This way, I can do this! http://cl.ly/image/0u3r2x110m1F (Yes, it was never specced, but it's a thing now.)

@novaugust novaugust changed the title [WIP] About ghost page About ghost page Sep 1, 2014
@novaugust
Copy link
Contributor Author

Update!

screen shot 2014-09-01 at 11 02 57

@ErisDS This is Good To Go, assuming everyone else is alright with the code. Just needs some CSS love provided by #3907

@ErisDS
Copy link
Member

ErisDS commented Sep 1, 2014

Wa-heeeey!

.gitignore Outdated

This comment was marked as abuse.

@novaugust novaugust force-pushed the about-ghost branch 2 times, most recently from d3d654d to ad65b90 Compare September 1, 2014 17:31

This comment was marked as abuse.

This comment was marked as abuse.

@novaugust novaugust force-pushed the about-ghost branch 4 times, most recently from c279d52 to 7c99009 Compare September 1, 2014 21:59

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

Closes TryGhost#3568
- Deleted html placeholders in client
- Added new grunt task, buildAboutPage, which 1)creates -contributors.hbs partial and 2) downloads contributor avatars
- buildAboutPage is called by anything that does an emberTemplates task
- Removed unused code from ghostpaths
ErisDS added a commit that referenced this pull request Sep 2, 2014
@ErisDS ErisDS merged commit e008438 into TryGhost:master Sep 2, 2014
@novaugust novaugust deleted the about-ghost branch September 19, 2014 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] "About Ghost" page

6 participants