Conversation
|
Couple things, from a UI perspective:
Aside from those, it looks good to me. 👍 |
|
Cheers buddy. I got the drop down to 20 in there already, I'll add the class =) |
|
👍 |
|
@PaulAdamDavis The about.html needs updating to be brought up to speed with GUI2. |
Gruntfile.js
Outdated
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
I'm clearing up the CSS ready for this. Just a couple HTML changes:
|
|
h/t @morficus for telling me I should make a separate dep for this. It had crossed my mind, but without outside influence I wasn't going to. behold! novaugust/top-gh-contribs (gh: is it ghost or github?! (hint: it's github, but inspired by ghost?)) If people think having the code in an external place is a bad idea, I can move it back in. But hey, it's OSS, so if I die, you can always just c/p eh? |
|
@novaugust So, so so close. I think I badly communicated the "Buttons next to the env info needs to change the class to |
|
Pretty sure multi-classes are required, eg. |
|
@JohnONolan Truedat. Okay, let's use use |
|
@PaulAdamDavis told you you should have done this :P |
|
@novaugust It does. I'm a doofus. Also, another thing, a new thing this time, and that's to add the contributors name which is currently on the <a href="gh.com/user" title="Users Name">
<img src="/images/user.jpg" alt="Users Name" />
</a>This way, I can do this! http://cl.ly/image/0u3r2x110m1F (Yes, it was never specced, but it's a thing now.) |
11b6135 to
ecfbd33
Compare
ecfbd33 to
650fabb
Compare
|
Wa-heeeey! |
.gitignore
Outdated
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
d3d654d to
ad65b90
Compare
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
c279d52 to
7c99009
Compare
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Closes TryGhost#3568 - Deleted html placeholders in client - Added new grunt task, buildAboutPage, which 1)creates -contributors.hbs partial and 2) downloads contributor avatars - buildAboutPage is called by anything that does an emberTemplates task - Removed unused code from ghostpaths
7c99009 to
737ea3f
Compare

Closes #3568
core/client/templates/-contributors.hbsclient/assets/img/contributors/<name>