Added error link on 404 pages#2792
Added error link on 404 pages#2792ErisDS merged 1 commit intoTryGhost:masterfrom jxhn:2298-error-page
Conversation
|
Any PR that introduces visual changes needs screenshot(s) to accompany. For sanity / ease of review / and history. I think the copy would maybe be better as: Go to the front page → |
|
I'll redo the copy (→ inclusive? ) and screen cap tonight or this weekend. |
|
Yep including the arrow :) |
|
@jomahoney ping? 😺 |
|
@ErisDS Laptop died earlier in the week 😧 Using a replacement now, PR ready tonight, like actually tonight. |
|
Submitting the PR as @JohnONolan suggested |
|
I don't know how I managed the last commit but the PR https://github.com/jomahoney/Ghost/commit/24d5885a61eb0800c9ee7c5786e6922c1229a2fa should be the one accepted. Sorry for messing this up so much, if you want a clean new PR let me know. |
|
Yes pleae to the clean PR, but it shouldn't be necessary to make a new one, it should be possible to clean this one. We have instructions on how to manage PRs in the contributing guidelines, specifically here: https://github.com/TryGhost/Ghost/wiki/Git-workflow#clean-up-history I imagine that this happened because you tried to do a merge, rather than a rebase? I'm always interested to understand what goes wrong so that I can update our guidelines to be more helpful. I think the easiest way to clean this up would be to cherry-pick the changes you want to keep onto a fresh copy of master, and then squash. Once you've got a branch you're happy with, you can delete your existing |
closes #2298 - added hyperlink to error templates - added class for styling hyperlinks on error pages
|
Hope that's ok, I think my merging came about as I used Hope you're happy with the PR and sorry for the few months delay. |

closes #2722, closes #2298