Skip to content

Linked 404 page to the blog's home#2722

Closed
seifip wants to merge 1 commit intoTryGhost:masterfrom
seifip:patch-1
Closed

Linked 404 page to the blog's home#2722
seifip wants to merge 1 commit intoTryGhost:masterfrom
seifip:patch-1

Conversation

@seifip
Copy link

@seifip seifip commented May 10, 2014

The default error page template should have an easy way to get somewhere useful. The home page of the blog seems to be a reasonable default for most.

The default error page template should have an easy way to get somewhere useful. The home page of the blog seems to be a reasonable default for most.
@halfdan
Copy link
Contributor

halfdan commented May 10, 2014

refs #2298

@ErisDS
Copy link
Member

ErisDS commented May 17, 2014

Hi @seifip welcome to Ghost's GitHub. Did you see the issue #2298 that @halfdan linked to?
There was a proposed design for a link to do this, but it seems @jomahoney never got around to submitting a PR. I don't think having a hidden link will help many people - could you update your PR to make the change as shown in #2298?

Thanks 👍

@jxhn
Copy link
Contributor

jxhn commented May 19, 2014

Yes - completely forgot to submit the PR as @ErisDS mentions, I can update and submit the PR this evening if @seifip doesn't mind. Apologies for the delay in closing this out btw.

@ErisDS
Copy link
Member

ErisDS commented May 20, 2014

Whoever submits the fix first wins 😉

@shindakun
Copy link
Contributor

Apologies to @seifip @jomahoney. I had to try and win the race. 😉

@jxhn
Copy link
Contributor

jxhn commented May 22, 2014

@shindakun Sorry for undermining your PR, I just noticed there's two templates.

I've also made a PR to Ghost UI for the styling. TryGhost/Ghost-UI#32

@ErisDS
Copy link
Member

ErisDS commented May 25, 2014

Closing this in favour of #2792 which should hopefully be ready soon.

@ErisDS ErisDS closed this May 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants