Merged
Conversation
Contributor
Author
|
Tests failed but those are unrelated - @ErisDS can you restart the two failed runs? I restarted my tests at https://travis-ci.org/halfdan/Ghost/builds/20888807 5 times and couldn't produce the pg issues, so hope that they are finally gone. |
Contributor
Author
|
Ok - Tests seem to be pretty solid right now in regard to pg. #2395 however seems to have introduced new intermittent CasperJS errors. I would like to raise the cause of pg test errors in the next meeting if possible. Several tests were expecting a specific order in the result sets which aren't guaranteed by the database. MySQL/SQLite seem to consistently return data in the order in was inserted, PostgreSQL however sometimes returns data out of this order. |
fixes TryGhost#2075 - Updates knex to latest version - Fixes expected value in page test - Change fixture insertion to be sequential - Add orderBy to insertMorePostsTags fixture helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2075