Added functional tests for editor: tag editor, image uploads, post settings#2395
Merged
ErisDS merged 1 commit intoTryGhost:masterfrom Mar 14, 2014
m-tse:mattse#2273
Merged
Added functional tests for editor: tag editor, image uploads, post settings#2395ErisDS merged 1 commit intoTryGhost:masterfrom m-tse:mattse#2273
ErisDS merged 1 commit intoTryGhost:masterfrom
m-tse:mattse#2273
Conversation
…ttings references #2273 - test tag creation and tag deletion - tests image uploader appears after typing `![]()` in editor - tests image URL matches url inside `` - tests all input elements of post settings menu
Member
|
Love these PRs 👍 |
ErisDS
added a commit
that referenced
this pull request
Mar 14, 2014
Added functional tests for editor: tag editor, image uploads, post settings
Contributor
|
This PR seems to have introduced an intermittent functional test error: https://travis-ci.org/halfdan/Ghost/jobs/20900525 |
Contributor
Author
|
@halfdan for https://travis-ci.org/halfdan/Ghost/jobs/20900525, I see a race condition that I will fix. I'll also look through the rest of my code to see if I can find any more similar race conditions. In #2409, you mentioned errors(plural). Did the functional test fail on any more of the tests besides the test in: ? |
tigefa4u
pushed a commit
to tigefa4u/Ghost
that referenced
this pull request
Aug 3, 2022
Co-authored-by: Renovate Bot <bot@renovateapp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added functional tests for editor: tag editor, image uploads, post settings
references #2273
![]()in editor