Add /town nearby command by Nrleryx · Pull Request #8040 · TownyAdvanced/Towny

Nrleryx · 2025-12-13T10:54:45Z

Description
Adds a new /town nearby command that lists the 10 nearest towns sorted by distance from the player's current location.

Changes

Added TOWNY_COMMAND_TOWN_NEARBY permission node
Added parseTownNearbyCommand() method in TownCommand.java
Added command case handler for "nearby"
Added permission definition in plugin.yml
Added translation strings in en-US.yml

Features

Lists up to 10 nearest towns
Shows distance in blocks
Displays nation information if town is in a nation
Filters towns by same world
Handles edge cases (no towns found, world not using Towny)

Testing

Tested with towns in same world
Tested with towns in different worlds
Tested with no towns nearby

I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.

LlmDl

Found some things to change.

I've also tested the jar and I cannot get it to list any towns, it just says "No towns found nearby." so you should probably retest it.

Thanks for the pull request.

Towny/src/main/java/com/palmergames/bukkit/towny/command/TownCommand.java

Towny/src/main/resources/lang/en-US.yml

Towny/src/main/resources/plugin.yml

Towny/src/main/java/com/palmergames/bukkit/towny/command/TownCommand.java

Nrleryx · 2025-12-13T16:06:25Z

Thanks for the review! I've addressed all the feedback:

Moved "nearby" to alphabetical order (just above "new")
Added town.hasWorld() check before accessing town.getWorld()
Added help menu entry using town_help_11 in HelpMenu class
Moved hardcoded strings to lang file (msg_nearby_town_format and msg_nearby_town_nation)
Changed empty check to throw exception instead of returning
Added permission to townyperms.yml in nomad section
Added entry to config-migration.json using TOWNYPERMS_ADD
Switched from Stream API to for loop for better reliability

I've also fixed the issue where no towns were showing - the problem was with the stream filtering. The for loop approach should work correctly now.

Please let me know if there's anything else that needs to be changed!

…ssages, help menu, townyperms, config migration

Towny/src/main/resources/lang/en-US.yml

Towny/src/main/resources/config-migration.json

BASIT_OZELLIKLER.md

Towny/src/main/java/com/palmergames/bukkit/towny/command/TownCommand.java

…ASIT_OZELLIKLER.md

Nrleryx · 2025-12-13T17:04:51Z

All review comments addressed:

Using town_help_36 instead of town_help_11
Added version section 0.102.0.2 in config-migration.json
Removed BASIT_OZELLIKLER.md
Fixed TownCommand.java formatting - only new code added

Ready for review!

LlmDl

Couple more things to clean up.

I am pretty sure this command will be able to do some harm to larger servers. If players spam this command it's going to cause a lot of math over and over again.

I had at first thought that this could go in as a /t list by nearby command so that it would use our Comparator caches. Then I realized that it wouldn't work well because the list would be different for each player.

Although I like the idea here, I don't think we can add it without some sort of cache and having this done on its own thread.

Towny/src/main/java/com/palmergames/bukkit/towny/command/HelpMenu.java

Towny/src/main/resources/lang/en-US.yml

…nc for performance

Nrleryx · 2025-12-13T17:11:03Z

Fixed:

Removed duplicate town_help entries from en-US.yml
Fixed HelpMenu to use town_help_11
Made nearby command async for better performance

Towny/src/main/java/com/palmergames/bukkit/towny/command/TownCommand.java

Towny/src/main/resources/lang/en-US.yml

Towny/src/main/java/com/palmergames/bukkit/towny/command/TownCommand.java

…ssary scheduler, fix exception handling, move language strings to end of file

Nrleryx · 2025-12-13T17:33:05Z

Addressed all review comments: optimized distance calculation with Map, removed unnecessary scheduler and exception handling, moved language strings to end of file.

LlmDl

Looks pretty good now, we'll see what Warrior thinks.

Nrleryx · 2025-12-13T17:44:34Z

Thanks! Waiting.

Towny/src/main/java/com/palmergames/bukkit/towny/command/TownCommand.java

…tream API

Nrleryx · 2025-12-13T18:03:10Z

Optimizations applied. Thanks!

Warriorrrr

Final thing I noticed, the rest looks good.

Towny/src/main/resources/lang/en-US.yml

Nrleryx · 2025-12-13T18:19:09Z

Updated to use minimessage colors. Thanks!

LlmDl

I've tested the jar and it is working now, thanks.

Nrleryx · 2025-12-13T19:09:03Z

Thanks for testing! Will this be merged soon? @LlmDl @Warriorrrr

LlmDl · 2025-12-13T19:37:36Z

Thanks for testing! Will this be merged soon? @LlmDl @Warriorrrr

It'll get merged before the next pre-release

Nrleryx · 2025-12-13T19:40:33Z

Thanks for the update! Do you have an approximate ETA for the next pre-release?

- Adds a configurable system based on town age and size limits, to refund recently-made, "small" towns their full cost. - Closes #7974. - New Config Option: economy.refund_deleted_new_towns.allow_refund_on_deletion - Default: false - Will towns that are recently created allow for a refund when the town is deleted by using the /t delete command? - This allows a player who has founded their town in the wrong place to delete their town and move it. - Towns must be less than the age specified below and have a configuable number of townblocks. - New Config Option: economy.refund_deleted_new_towns.max_town_age_in_hours - Default: 1 - How many hours old is a town allowed to be in order to get the refund when being deleted. - New Config Option: economy.refund_deleted_new_towns.max_townblocks - Default: 8 - How many townblocks is a town allowed to have in order to qualify for the refund. - Fix exception when attempting to query NPC perms through LuckPerms, courtesy of Warrior with PR #8033. - Future proof minecraft version parsing, courtesy of Warrior with PR #8034. - Fix 2 points where permission node tests bypass the adminbypass mode. - Add /town nearby command, courtesy of Nrleryx with PR #8040. (First-Time Contributor!) - New Permission Node: towny.command.town.nearby - Will be automatically added to your nomads in the townyperms.yml. - New Command: /town nearby - Shows a player up to 10 towns that are nearest to the player in the order of closest to furthest.

Add /town nearby command to list nearby towns by distance

866df73

github-actions bot added the Label-Command label Dec 13, 2025

LlmDl requested changes Dec 13, 2025

View reviewed changes

Fix review comments: alphabetical order, hasWorld check, lang file me…

ad21f3f

…ssages, help menu, townyperms, config migration

Nrleryx force-pushed the feature/town-nearby-command branch from b4b4801 to ad21f3f Compare December 13, 2025 16:08

LlmDl requested changes Dec 13, 2025

View reviewed changes

Nrleryx added 2 commits December 13, 2025 19:46

Fix review: use town_help_36, add version section 0.102.0.2, remove B…

e05190e

…ASIT_OZELLIKLER.md

Fix TownCommand.java: only add new nearby command, no formatting changes

a129cf3

Nrleryx force-pushed the feature/town-nearby-command branch from df4ea28 to a129cf3 Compare December 13, 2025 16:55

LlmDl requested changes Dec 13, 2025

View reviewed changes

Towny/src/main/java/com/palmergames/bukkit/towny/command/HelpMenu.java Outdated Show resolved Hide resolved

Towny/src/main/resources/lang/en-US.yml Outdated Show resolved Hide resolved

Fix review: remove duplicate town_help entries, fix HelpMenu, add asy…

598857a

…nc for performance

Nrleryx requested a review from LlmDl December 13, 2025 17:22

LlmDl requested changes Dec 13, 2025

View reviewed changes

Address review comments: optimize distance calculation, remove unnece…

4354a39

…ssary scheduler, fix exception handling, move language strings to end of file

Nrleryx requested a review from LlmDl December 13, 2025 17:33

LlmDl reviewed Dec 13, 2025

View reviewed changes

Warriorrrr reviewed Dec 13, 2025

View reviewed changes

Optimize nearby command: use world.getTowns(), distanceSquared, and S…

233845a

…tream API

Nrleryx requested a review from LlmDl December 13, 2025 18:02

Warriorrrr approved these changes Dec 13, 2025

View reviewed changes

Towny/src/main/resources/lang/en-US.yml Outdated Show resolved Hide resolved

Use minimessage colors instead of legacy color codes

d378807

Nrleryx requested a review from Warriorrrr December 13, 2025 18:28

LlmDl approved these changes Dec 13, 2025

View reviewed changes

LlmDl added this to the 0.102.1.0 milestone Dec 13, 2025

Warriorrrr removed their request for review December 13, 2025 20:18

Merge branch 'master' into feature/town-nearby-command

44dc758

LlmDl merged commit 362fbb6 into TownyAdvanced:master Dec 13, 2025
1 check passed

Uh oh!

Conversation

Nrleryx commented Dec 13, 2025 • edited by LlmDl Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LlmDl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nrleryx commented Dec 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nrleryx commented Dec 13, 2025

Uh oh!

LlmDl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Nrleryx commented Dec 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nrleryx commented Dec 13, 2025

Uh oh!

LlmDl left a comment

Choose a reason for hiding this comment

Uh oh!

Nrleryx commented Dec 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nrleryx commented Dec 13, 2025

Uh oh!

Warriorrrr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Nrleryx commented Dec 13, 2025

Uh oh!

LlmDl left a comment

Choose a reason for hiding this comment

Uh oh!

Nrleryx commented Dec 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LlmDl commented Dec 13, 2025

Uh oh!

Nrleryx commented Dec 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Nrleryx commented Dec 13, 2025 •

edited by LlmDl

Loading

Nrleryx commented Dec 13, 2025 •

edited

Loading