Skip to content

Future proof minecraft version parsing#8034

Merged
LlmDl merged 1 commit intomasterfrom
feat/future-proof-minecraft-version
Dec 13, 2025
Merged

Future proof minecraft version parsing#8034
LlmDl merged 1 commit intomasterfrom
feat/future-proof-minecraft-version

Conversation

@Warriorrrr
Copy link
Copy Markdown
Member

Description:

The MinecraftVersion class currently parses the minecraft version from the bukkit version ("1.21.10-R0.1-SNAPSHOT"), which works fine and will likely continue working fine. Regardless, this PR changes it to directly get the minecraft version ("1.21.10") so that this will always continue working normally.

The code as it already is will also work fine for the future version format changes mojang is planning on doing next year.


  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.

@Warriorrrr Warriorrrr added this to the 0.102.1.0 milestone Dec 5, 2025
@LlmDl LlmDl merged commit 91553cf into master Dec 13, 2025
3 checks passed
@LlmDl LlmDl deleted the feat/future-proof-minecraft-version branch December 13, 2025 21:38
LlmDl added a commit that referenced this pull request Dec 13, 2025
    - Adds a configurable system based on town age and size limits, to
refund recently-made, "small" towns their full cost.
    - Closes #7974.
  - New Config Option:
economy.refund_deleted_new_towns.allow_refund_on_deletion
    - Default: false
    - Will towns that are recently created allow for a refund when the
town is deleted by using the /t delete command?
    - This allows a player who has founded their town in the wrong place
to delete their town and move it.
    - Towns must be less than the age specified below and have a
configuable number of townblocks.
  - New Config Option:
economy.refund_deleted_new_towns.max_town_age_in_hours
    - Default: 1
    - How many hours old is a town allowed to be in order to get the
refund when being deleted.
  - New Config Option: economy.refund_deleted_new_towns.max_townblocks
    - Default: 8
    - How many townblocks is a town allowed to have in order to qualify
for the refund.
  - Fix exception when attempting to query NPC perms through LuckPerms,
courtesy of Warrior with PR #8033.
  - Future proof minecraft version parsing, courtesy of Warrior with
PR #8034.
  - Fix 2 points where permission node tests bypass the adminbypass
mode.
  - Add /town nearby command, courtesy of Nrleryx with PR #8040.
(First-Time Contributor!)
  - New Permission Node: towny.command.town.nearby
    - Will be automatically added to your nomads in the townyperms.yml.
  - New Command: /town nearby
    - Shows a player up to 10 towns that are nearest to the player in
the order of closest to furthest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants