Skip to content

Enforce notnull for account name/uuid fields#7705

Merged
LlmDl merged 2 commits intomasterfrom
fix/enforce-account-notnull
Jan 18, 2026
Merged

Enforce notnull for account name/uuid fields#7705
LlmDl merged 2 commits intomasterfrom
fix/enforce-account-notnull

Conversation

@Warriorrrr
Copy link
Copy Markdown
Member

Description:


New Nodes/Commands/ConfigOptions:


Relevant Towny Issue ticket:


  • I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.

@Warriorrrr Warriorrrr changed the title Enforce notnull for accoutn name/uuid fields Enforce notnull for account name/uuid fields Dec 21, 2024
@LlmDl
Copy link
Copy Markdown
Member

LlmDl commented Dec 21, 2024

Do we know how these ended up null?

@Warriorrrr
Copy link
Copy Markdown
Member Author

Not sure, but the only way I'd see it happening is someone not having a uuid= line in one of the data files. I marked it as a draft for now since adding this would make it blow up elsewhere if the uuid is not there

@Warriorrrr Warriorrrr marked this pull request as ready for review January 7, 2026 21:41
@Warriorrrr
Copy link
Copy Markdown
Member Author

Once the uuid db pr is in the chances of this being tripped is very low, but I think these changes are still useful to have for future debugging if it ever does happen again

@LlmDl
Copy link
Copy Markdown
Member

LlmDl commented Jan 7, 2026

This one is good to go, and should go in before the UUID db or after?

@Warriorrrr
Copy link
Copy Markdown
Member Author

After, just in case

@LlmDl LlmDl added the Post-UUID-DB To be merged after UUID DB overhaul is merged. label Jan 7, 2026
@LlmDl LlmDl added this to the 0.103.0.0 milestone Jan 14, 2026
@LlmDl LlmDl merged commit 5ad1bd5 into master Jan 18, 2026
4 checks passed
@LlmDl LlmDl deleted the fix/enforce-account-notnull branch January 18, 2026 15:07
LlmDl added a commit that referenced this pull request Jan 18, 2026
  - This version includes Major Changes to the database structure which
took place in 0.102.0.4!
    - Read about it here:
https://github.com/TownyAdvanced/Towny/releases/tag/0.102.0.4
    - The Changelog for 0.102.0.5 follows:
  - Enforce notnull for economy account name/uuid fields, courtesy of
Warrior with PR #7705.
  - Fix IndexOutOfBounds exception in /t join, courtesy of Veyronity
with PR #8062.
  - Fix SQL loading of forSale, forSalePrice, and forSaleTime, courtesy
of Groovymeister with PR #8063. (First-Time Contributor!)
  - Add info/meta node for overriding teleport warmup.
    - Closes #7950.
  - New Permission Node: towny_teleport_warmup_seconds.N
    - An info/option node (see
https://github.com/TownyAdvanced/Towny/wiki/Towny-Permission-Nodes#infooptionmeta-nodes)
that overrides a player's warmup time.
    - Replace N with the seconds to use for a warmup time.
    - When not set, the standard warmup time from the Towny config.yml
is used.
  - Bump junit.version from 5.13.4 to 6.0.2.
  - Bump net.luckperms:api from 5.4 to 5.5.
  - Bump org.apache.maven.plugins:maven-source-plugin from 3.3.1 to
3.4.0.
  - Bump net.milkbowl.vault:VaultUnlockedAPI from 2.9 to 2.15.
  - Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.11.2 to
3.12.0.
  - Fix itemuse list not being used against projectiles which are fired
into the air.
  - Allow empty towns to turn into ruins, courtesy of Warrior with
PR #8071.
  - New config option: town_ruining.empty_towns_become_ruins
    - Default: false
    - When enabled, when the last resident is removed from a town and it
becomes empty (such as when inactive resident deletion is enabled),
      the town will turn into a ruin instead of being immediately
removed.
  - Fix IllegalArgumentException when a plugin we integrate with has a
bad version, courtesy of Warrior with PR #8072.
  - Fix unneeded msg_invalid_name exception message from /n enemy,
courtesy of pernio with PR #8073. (First-Time Contributor!)
  - Add a cooldown to prevent towns spamming residents by outlawing and
unoutlawing them, courtesy of Veyronity with PR #8074.
  - New Config Option:
resident_settings.warn_player_on_outlaw_message_cooldown_in_seconds
    - Default: 30
    - How many seconds in between warning messages, to prevent spam.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Label-Money Post-UUID-DB To be merged after UUID DB overhaul is merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants