-
Notifications
You must be signed in to change notification settings - Fork 614
fix: resolve sidebar toggle button conflict #637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve sidebar toggle button conflict #637
Conversation
WalkthroughA media query hook is added to detect large screens in the chat tab view. The sidebar's outside click handler is updated to close the sidebar only on smaller screens, preventing it from closing due to outside clicks on large screens. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (9)**/*.{ts,tsx,js,jsx,vue}📄 CodeRabbit Inference Engine (CLAUDE.md)
Files:
src/renderer/src/**/*.vue📄 CodeRabbit Inference Engine (CLAUDE.md)
Files:
src/renderer/src/**/*.{ts,tsx,vue}📄 CodeRabbit Inference Engine (CLAUDE.md)
Files:
src/renderer/src/**/*📄 CodeRabbit Inference Engine (.cursor/rules/i18n.mdc)
Files:
src/renderer/**/*.{vue,ts,js,tsx,jsx}📄 CodeRabbit Inference Engine (.cursor/rules/project-structure.mdc)
Files:
src/renderer/src/**/*.{vue,ts,tsx,js,jsx}📄 CodeRabbit Inference Engine (.cursor/rules/vue-best-practices.mdc)
Files:
src/renderer/**/*.{ts,tsx,vue}📄 CodeRabbit Inference Engine (.cursor/rules/vue-shadcn.mdc)
Files:
src/renderer/**/*.{vue,ts}📄 CodeRabbit Inference Engine (.cursor/rules/vue-shadcn.mdc)
Files:
src/renderer/**/*.{ts,vue}📄 CodeRabbit Inference Engine (.cursor/rules/vue-shadcn.mdc)
Files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (3)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
* (WIP) feat: add Builtin Knowledge Server and settings integration * feat: add multiple languages translation * feat: enhance BuiltinKnowledgeSettings with model selection and update translations * feat: update BuiltinKnowledgeSettings with enhanced configuration options and translations * feat: update knowledge base settings to use 'builtinKnowledge' and enhance BuiltinKnowledgeSettings with URL query parameter handling * feat: enhance BuiltinKnowledgeSettings with model selection and error handling for missing models * feat: add confirmation dialog and error messages for removing built-in knowledge configurations * props * [WIP] feat: implement KnowledgePresenter and related embedding functionality * [WIP] feat: add KnowledgeConfHelper for managing knowledge base configurations * [WIP] feat: log new knowledge config additions in KnowledgePresenter * [WIP] feat: enhance knowledge base settings and descriptions across components * [WIP] feat: enhance Built-in Knowledge settings and descriptions, add advanced options and tooltips * [WIP] feat: add dimensionsHelper to settings for better user guidance on embedding dimensions * [WIP] feat: add getDimensions method and update embedding handling across providers * [wip] feat: enhance embedding handling by adding error handling and resetting model selection in settings * [WIP] feat: refactor embedding handling to use modelId and providerId, enhance KnowledgePresenter integration * [WIP] feat: update KnowledgePresenter and LLMProviderPresenter to improve embedding handling and error logging * [WIP] feat: enhance BuiltinKnowledgeSettings with additional parameters and loading logic for better user experience * [WIP] feat: enhance KnowledgePresenter to handle deleted configs and improve reset logic * [WIP] feat: update LLMProviderPresenter and OllamaProvider to enhance model listing with additional configuration properties * [WIP] feat: enhance Ollama model integration by updating local models to include dynamic configuration retrieval * [WIP] fix: update getRagApplication to include baseURL in Embeddings instantiation * [WIP] feat: update getDimensions method to return structured response with error handling * [WIP] feat: enhance BuiltinKnowledgeSettings with dynamic dimension detection and loading state * feat: add duration to toast notifications for improved user feedback * feat: add BuiltinKnowledge file upload box * feat: update TODO list with additional parameters and logic improvements for BuiltinKnowledgeSettings and OllamaProvider * feat: add delay duration to tooltips for improved user experience * feat: add BuiltinKnowledge file reload button * feat: limit BuiltinKnowledge file types * feat: add new BuiltinKnowledge form items * fix: fix BuiltInKnowledge embedding modelId * 还原lucide-vue-next版本提升的修改 * fix: fix BuiltInKnowledge rerank form item * [WIP] refactor: update knowledge base configuration to use BuiltinKnowledgeConfig and remove unused embedding classes (duckdb does not provide an binrary extension for windows) * chore: remove unused llm-tools embedjs dependencies from package.json * feat: implement DuckDBPresenter for vector database operations (make sure duckdb extension vss has been installed) * refactor: update import statements to use default imports for fs and path * feat: add BuiltinKnowledge form Information display * refactor: restructure postinstall script for clarity and improved extension installation process * refactor: update icon in BuiltinKnowledgeSettings and change v-show to v-if in KnowledgeBaseSettings; add file type acceptance in KnowledgeFile * refactor: simplify file icon retrieval by centralizing logic in getMimeTypeIcon utility function * refactor: enhance type safety for builtinKnowledgeDetail and improve code readability in KnowledgeBaseSettings and KnowledgeFile components * fix: add optional chaining for builtinKnowledgeDetail description to prevent potential runtime errors * feat: add KnowledgeFileMessage type and file management methods to IKnowledgePresenter interface * feat: enhance DuckDBPresenter with file management methods and update IVectorDatabasePresenter interface * refactor: rename methods and update table names in DuckDBPresenter for clarity and consistency * feat: implement file management methods in RagPresenter and update IKnowledgePresenter interface * feat: access BuiltinKnowledge file interface * fix: fix prompt information error * fix: improve error toast description for file upload failure * feat: add file management methods and enhance interfaces in presenters; update file handling logic * feat: add RAG_EVENTS for file update notifications; implement vector utility functions * feat: enhance LLM dimension handling and add normalization support; update related components and translations * feat: update vector database handling to include normalization support; refactor related methods * feat: add dayjs dependency for time formatting * feat: add a listener for FILE_UPDATED * feat: change the params format * feat: change callback function * fix: resolve merge conflicts in localization files * feat(knowledge): Implement file listing and fix embedding parameters * feat: change loadlist after file upload and file delete * fix(knowledge): correct timestamp storage and refactor database interaction * fix: remove unnecessary nextTick in reAddFile * fix: remove duplicate loadList in deleteFile * feat(knowledge): enhance file handling with status updates and event emissions * feat: add similarity query functionality to RagPresenter and DuckDBPresenter * feat: implement similarity query in BuiltinKnowledgeServer and update KnowledgeFile component * feat: enhance BuiltinKnowledge module with detailed architecture and design documentation * feat: remove part of builtinKnowledge base info display * fix: fix file status switching bug * feat: add builtinKnowledge file search * fix: reemove redundant div * feat: enhance file handling process in BuiltinKnowledge design with detailed flow for file insertion and retrieval * feat: update BuiltinKnowledge design document with refined file handling and retrieval processes * feat: refactor BuiltinKnowledge module by replacing RagPresenter with KnowledgeStorePresenter and updating related components * feat: add builtinKnowledge file search score * feat: enhance error handling in file upload and re-upload processes in KnowledgeFile component * fix: fix overly long file names * fix: fix overly long file names * refactor: simplify checkpoint logic in DuckDBPresenter open method * feat: add @langchain/core dependency to enhance functionality * fix: update file extension handling to use correct variable name * feat: add crash reporter initialization for error tracking * fix: enhance logging and error handling in DuckDBPresenter methods * fix: move crash reporter initialization inside logging check * feat: add toast messages for model status and L2 normalization support in multiple languages * refactor: simplify fileTask method by removing unnecessary promise wrapping and adding comments * refactor: update model handling by removing unnecessary ModelConfig references and enhancing model info structure * fix: update company name format in crash reporter configuration * fix: fix embedding model default settings and revert ModelConfigItem changed * fix: cancel crash report * fix: fix pulling model type not assignable problem * fix: remove unneccessary files * fix: remove unnecessary files * fix: block option rerank model (not implemented yet) * fix: dynamically decide whether to show model customization configuration button * fix: remove useless i18n translations * fix: remove useless dependencies and improve definitions * perf: imporve knowledgePresenter resource release * perf: convert to async function for better error handling * perf: convert to async function for better error handling * perf: imporve vector utils * fix: fix error words * (WIP) feat: selectively enable mcp toolsets * perf: mark the interrupted task as a user-cancelled task when app startup * perf: add try-catch to enhance program stability * fix: declared but never read error * fix: missing attr file_id when insert vector(s) * perf: skip duckdb vss extension installation on macOS * fix: remove bad references * perf: disable auto install duckdb vss extension 1. will cause macOS sign problem 2. will increase 40Mb for build * perf: remove langchain from package, reduce package size * fix: declared but never read error * perf: use Bipolar Quadratic Mapping algorithm to ensure that the vector confidence is between [0,1] * perf: a more appropriate scaling factor * perf: knowledge config update logic * fix: update text fixed * fix: lint * feat:Add Groq as Provider * update groq.svg * update groqProvider.ts * (WIP) perf: enhance knowledge management with chunk processing and task scheduling features * feat: remove python code run on js * (WIP) feat: add clearDirtyData method to clean up orphaned vectors and chunks * (WIP) feat: enhance DuckDBPresenter with logging and new insertVectors method; update KnowledgeStorePresenter for chunk processing and status management * feat: refactor task management in KnowledgeTaskPresenter; enhance chunk processing and status handling in KnowledgeStorePresenter * feat: add enabledMcpTools field to conversation for controlling MCP tools * feat: filter MCP tools by enabledMcpTools * refactor: update task management and chunk processing in KnowledgePresenter and KnowledgeTaskPresenter; enhance error handling and metadata management * feat: enhance DuckDBPresenter and KnowledgeStorePresenter with error handling; update task management and chunk processing * feat: enhance task management in KnowledgeTaskPresenter; improve error handling and processing flow in KnowledgeStorePresenter; update file list handling in KnowledgeFile component * feat: refactor toggle logic for MCP service and tool state * feat: enhance file handling in KnowledgeStorePresenter; improve error handling and metadata management in KnowledgeFile and presenter.d.ts * feat: update DuckDBPresenter and presenter.d.ts; enhance transaction management and introduce new task status summary interface * refactor: remove obsolete RAG event constants for file progress, chunk completion, and task queue status * feat: add file progress tracking and event emission for file processing updates * fix: update DuckDB dependency to version 1.3.2-alpha.25; enhance database cleanup logic in KnowledgePresenter * feat: enhance KnowledgePresenter configuration management; improve store presenter handling and update method signature * feat: add dialog handling with DialogPresenter and MessageDialog component * feat: enhance dialog handling with improved response management and new closeable option * feat: refactor dialog handling to support timeout and response management with enhanced type definitions * feat: update dialog request types for consistency and clarity in MessageDialog component * feat: enhance MessageDialog component with i18n support for descriptions and improve dialog timeout handling * feat: enhance dialog handling with improved error management and response structure * feat: improve dialog error handling and response structure in DialogPresenter * fix: e2b key not working * (WIP) perf: enhance knowledge management with chunk processing and task scheduling features * feat: implement task management features for pausing and resuming tasks in DuckDB and Knowledge presenters * feat: implement database migration and metadata management in DuckDBPresenter * fix: ensure database version is set after migration completion * update githubCopilotProvider * update Copilot Model * feat: Refactor Knowledge Presenter and related components - Updated KnowledgePresenter design document to reflect new architecture and features, including improved lifecycle management and event handling. - Enhanced file processing flow in KnowledgeStorePresenter to ensure immediate feedback and error handling during file reading. - Modified KnowledgeFile.vue to support additional file types and improve file status handling in the UI. - Improved configuration management for Knowledge Presenter, allowing for better integration and user experience. * use provider check if model id is not provided * fix: reorder parameters in getEmbeddings method for consistency across providers * feat: add export markdown * check copilot provider by model * update GitHubCopilotOAuth.vue * fix: remove redundant 'redetectDimensions' translations from multiple language settings * wip: better style * wip: fix worker * chore: remove unuse code * feat: add i18n * fix: format * fix: convert uploadedAt to string for consistent data handling * fix: lint * docs: add comprehensive documentation for Dialog module and its components * fix: i18n and ai review * Update src/main/events.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update src/main/lib/textsplitters/index.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update src/renderer/src/lib/utils.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * refactor: improve error handling and logging in dialog and knowledge task presenters; update text sanitization and localization * fix: #623 * feat: change function name * feat: add empty data display * feat: add click outside to close sidebar functionality * style(threads): optimize the operation logic of new sessions (#633) * style(threads): optimize the operation logic of new sessions * chore: format code * chore(ci): add code lint check (#634) * chore(ci): add code lint check * chore: remove linting steps from build workflow; add linting steps to PR check workflow * fix: resolve sidebar toggle button conflict (#637) * fix: Bugfix/gemini thinking (#639) * fix: gemini reasoning by config * feat: support gemini thinking * fix: user define model config first * fix: format * chore: ignore md for format * doc: remove empty line * fix: ai review * perf(ChatConfig): Set the TooltipProvider component to add a delay duration of 200& update the include configuration in the tsconfig.web.json file (#640) * feat: Add thinking budget support for Gemini 2.5 series models (#643) * chore: update 0.2.7 --------- Co-authored-by: hllshiro <40970081+hllshiro@users.noreply.github.com> Co-authored-by: ysli <sqsyli@qq.com> Co-authored-by: zhangmo8 <wegi866@gmail.com> Co-authored-by: dw9 <xweimvp@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: yyhhyyyyyy <yyhhyyyyyy8@gmail.com> Co-authored-by: 阿菜 Cai <1064425721@qq.com> Co-authored-by: 阿菜 Cai <jimmyrss1102@gmail.com> Co-authored-by: flingyp <flingyp@163.com>
Resolve sidebar toggle button conflict.
Follow this logic:
Summary by CodeRabbit