-
Notifications
You must be signed in to change notification settings - Fork 614
chore(ci): add code lint check #634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis update introduces a new npm script for formatting checks and integrates it into the GitHub Actions workflow. The workflow now runs linting and formatting checks after dependency installation. Additional changes across various source files include whitespace, indentation, and minor formatting corrections, with no modifications to logic or functionality. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~6 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (7)
src/main/events.ts (1)
178-179: Whitespace trimmed – keep renderer/main event maps in sync.The removal is harmless, but remember to run the same linter on
src/renderer/src/events.tswhenever new dialog events are added so that both maps stay strictly identical.src/renderer/src/events.ts (1)
129-131: Trailing commas removed – match ESLint config but double-check auto-generation scripts.If this file is regenerated by tooling, ensure the generator also adopts the new style to avoid churn in future commits.
src/main/presenter/knowledgePresenter/knowledgeTaskPresenter.ts (1)
118-118: Extraneous blank line deleted – OK.While you’re here, consider making
destroy()idempotent (e.g., guard withif (this.isProcessing === null) return) to avoid accidental double calls during shutdown..github/workflows/build.yml (1)
45-50: Remove stray whitespace to satisfy YAML lintersYAML-lint is complaining about trailing spaces on the blank line (current line 47).
Apply the diff to keep the workflow tidy:-src/main/presenter/mcpPresenter/inMemoryServers/builtinKnowledgeServer.ts (1)
126-126: Round similarity for cleaner outputLong floating-point values reduce readability; round to e.g. 2 dp.
- resultText += `相似度: ${1 - result.distance}\n\n` + resultText += `相似度: ${(1 - result.distance).toFixed(2)}\n\n`src/renderer/src/components/settings/GitHubCopilotOAuth.vue (1)
256-256: Remove empty onMounted hookEmpty lifecycle hooks add noise and may trigger linter rules.
-onMounted(() => {}) +// remove – no side-effects required on mountsrc/main/presenter/filePresenter/FilePresenter.ts (1)
95-106: JSDoc could describe parametersThe new multi-line signature is fine, but the JSDoc lacks descriptions (and remains partly Chinese, violating the “English comments” guideline). Consider amending:
/** - * 准备文件,返回一个完整的 MessageFile 对象,支持不同的 contentType(兼容旧方法调用) - * @param absPath - * @param typeInfo - * @param contentType - * @returns + * Prepare a file and return a full `MessageFile`. + * @param absPath Absolute path to the source file. + * @param typeInfo Optional MIME hint; bypasses auto-detection when provided. + * @param contentType `'origin'` to embed raw content, `'llm-friendly'` for summarised content, `null` for metadata only. + * @returns A populated `MessageFile` instance. */
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
.github/workflows/build.yml(1 hunks)package.json(1 hunks)src/main/events.ts(1 hunks)src/main/lib/textsplitters/index.ts(1 hunks)src/main/presenter/filePresenter/FilePresenter.ts(1 hunks)src/main/presenter/index.ts(1 hunks)src/main/presenter/knowledgePresenter/knowledgeTaskPresenter.ts(1 hunks)src/main/presenter/llmProviderPresenter/providers/githubCopilotProvider.ts(2 hunks)src/main/presenter/mcpPresenter/inMemoryServers/builtinKnowledgeServer.ts(2 hunks)src/main/utils/vector.ts(2 hunks)src/renderer/src/components/settings/GitHubCopilotOAuth.vue(3 hunks)src/renderer/src/components/settings/KnowledgeFileItem.vue(1 hunks)src/renderer/src/events.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (18)
**/*.{ts,tsx,js,jsx,vue}
📄 CodeRabbit Inference Engine (CLAUDE.md)
Use English for logs and comments
Files:
src/main/utils/vector.tssrc/main/lib/textsplitters/index.tssrc/main/events.tssrc/main/presenter/index.tssrc/renderer/src/events.tssrc/main/presenter/llmProviderPresenter/providers/githubCopilotProvider.tssrc/renderer/src/components/settings/KnowledgeFileItem.vuesrc/renderer/src/components/settings/GitHubCopilotOAuth.vuesrc/main/presenter/knowledgePresenter/knowledgeTaskPresenter.tssrc/main/presenter/filePresenter/FilePresenter.tssrc/main/presenter/mcpPresenter/inMemoryServers/builtinKnowledgeServer.ts
**/*.{ts,tsx}
📄 CodeRabbit Inference Engine (CLAUDE.md)
Strict type checking enabled for TypeScript
**/*.{ts,tsx}: 始终使用 try-catch 处理可能的错误
提供有意义的错误信息
记录详细的错误日志
优雅降级处理
日志应包含时间戳、日志级别、错误代码、错误描述、堆栈跟踪(如适用)、相关上下文信息
日志级别应包括 ERROR、WARN、INFO、DEBUG
不要吞掉错误
提供用户友好的错误信息
实现错误重试机制
避免记录敏感信息
使用结构化日志
设置适当的日志级别
Files:
src/main/utils/vector.tssrc/main/lib/textsplitters/index.tssrc/main/events.tssrc/main/presenter/index.tssrc/renderer/src/events.tssrc/main/presenter/llmProviderPresenter/providers/githubCopilotProvider.tssrc/main/presenter/knowledgePresenter/knowledgeTaskPresenter.tssrc/main/presenter/filePresenter/FilePresenter.tssrc/main/presenter/mcpPresenter/inMemoryServers/builtinKnowledgeServer.ts
src/main/**/*.ts
📄 CodeRabbit Inference Engine (CLAUDE.md)
Main to Renderer: Use EventBus to broadcast events via mainWindow.webContents.send()
Use Electron's built-in APIs for file system and native dialogs
Files:
src/main/utils/vector.tssrc/main/lib/textsplitters/index.tssrc/main/events.tssrc/main/presenter/index.tssrc/main/presenter/llmProviderPresenter/providers/githubCopilotProvider.tssrc/main/presenter/knowledgePresenter/knowledgeTaskPresenter.tssrc/main/presenter/filePresenter/FilePresenter.tssrc/main/presenter/mcpPresenter/inMemoryServers/builtinKnowledgeServer.ts
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit Inference Engine (.cursor/rules/development-setup.mdc)
**/*.{js,jsx,ts,tsx}: 使用 OxLint 进行代码检查
Log和注释使用英文书写
Files:
src/main/utils/vector.tssrc/main/lib/textsplitters/index.tssrc/main/events.tssrc/main/presenter/index.tssrc/renderer/src/events.tssrc/main/presenter/llmProviderPresenter/providers/githubCopilotProvider.tssrc/main/presenter/knowledgePresenter/knowledgeTaskPresenter.tssrc/main/presenter/filePresenter/FilePresenter.tssrc/main/presenter/mcpPresenter/inMemoryServers/builtinKnowledgeServer.ts
src/{main,renderer}/**/*.ts
📄 CodeRabbit Inference Engine (.cursor/rules/electron-best-practices.mdc)
src/{main,renderer}/**/*.ts: Use context isolation for improved security
Implement proper inter-process communication (IPC) patterns
Optimize application startup time with lazy loading
Implement proper error handling and logging for debugging
Files:
src/main/utils/vector.tssrc/main/lib/textsplitters/index.tssrc/main/events.tssrc/main/presenter/index.tssrc/renderer/src/events.tssrc/main/presenter/llmProviderPresenter/providers/githubCopilotProvider.tssrc/main/presenter/knowledgePresenter/knowledgeTaskPresenter.tssrc/main/presenter/filePresenter/FilePresenter.tssrc/main/presenter/mcpPresenter/inMemoryServers/builtinKnowledgeServer.ts
src/main/**/*.{ts,js,tsx,jsx}
📄 CodeRabbit Inference Engine (.cursor/rules/project-structure.mdc)
主进程代码放在
src/main
Files:
src/main/utils/vector.tssrc/main/lib/textsplitters/index.tssrc/main/events.tssrc/main/presenter/index.tssrc/main/presenter/llmProviderPresenter/providers/githubCopilotProvider.tssrc/main/presenter/knowledgePresenter/knowledgeTaskPresenter.tssrc/main/presenter/filePresenter/FilePresenter.tssrc/main/presenter/mcpPresenter/inMemoryServers/builtinKnowledgeServer.ts
src/main/presenter/**/*.ts
📄 CodeRabbit Inference Engine (CLAUDE.md)
One presenter per functional domain
Files:
src/main/presenter/index.tssrc/main/presenter/llmProviderPresenter/providers/githubCopilotProvider.tssrc/main/presenter/knowledgePresenter/knowledgeTaskPresenter.tssrc/main/presenter/filePresenter/FilePresenter.tssrc/main/presenter/mcpPresenter/inMemoryServers/builtinKnowledgeServer.ts
src/main/presenter/index.ts
📄 CodeRabbit Inference Engine (.cursor/rules/electron-best-practices.mdc)
The IPC messages from the main process to notify the view mainly rely on the EventBus index.ts to listen for events that need to be notified and then send them to the renderer through the mainWindow
Files:
src/main/presenter/index.ts
src/renderer/src/**/*.{ts,tsx,vue}
📄 CodeRabbit Inference Engine (CLAUDE.md)
src/renderer/src/**/*.{ts,tsx,vue}: Use Pinia for frontend state management
Renderer to Main: Use usePresenter.ts composable for direct presenter method calls
Files:
src/renderer/src/events.tssrc/renderer/src/components/settings/KnowledgeFileItem.vuesrc/renderer/src/components/settings/GitHubCopilotOAuth.vue
src/renderer/src/**/*
📄 CodeRabbit Inference Engine (.cursor/rules/i18n.mdc)
src/renderer/src/**/*: All user-facing strings must use i18n keys (avoid hardcoded user-visible text in code)
Use the 'vue-i18n' framework for all internationalization in the renderer
Ensure all user-visible text in the renderer uses the translation system
Files:
src/renderer/src/events.tssrc/renderer/src/components/settings/KnowledgeFileItem.vuesrc/renderer/src/components/settings/GitHubCopilotOAuth.vue
src/renderer/**/*.{vue,ts,js,tsx,jsx}
📄 CodeRabbit Inference Engine (.cursor/rules/project-structure.mdc)
渲染进程代码放在
src/renderer
Files:
src/renderer/src/events.tssrc/renderer/src/components/settings/KnowledgeFileItem.vuesrc/renderer/src/components/settings/GitHubCopilotOAuth.vue
src/renderer/src/**/*.{vue,ts,tsx,js,jsx}
📄 CodeRabbit Inference Engine (.cursor/rules/vue-best-practices.mdc)
src/renderer/src/**/*.{vue,ts,tsx,js,jsx}: Use the Composition API for better code organization and reusability
Implement proper state management with Pinia
Utilize Vue Router for navigation and route management
Leverage Vue's built-in reactivity system for efficient data handling
Files:
src/renderer/src/events.tssrc/renderer/src/components/settings/KnowledgeFileItem.vuesrc/renderer/src/components/settings/GitHubCopilotOAuth.vue
src/renderer/**/*.{ts,tsx,vue}
📄 CodeRabbit Inference Engine (.cursor/rules/vue-shadcn.mdc)
src/renderer/**/*.{ts,tsx,vue}: Use descriptive variable names with auxiliary verbs (e.g., isLoading, hasError).
Use TypeScript for all code; prefer types over interfaces.
Avoid enums; use const objects instead.
Use arrow functions for methods and computed properties.
Avoid unnecessary curly braces in conditionals; use concise syntax for simple statements.
Files:
src/renderer/src/events.tssrc/renderer/src/components/settings/KnowledgeFileItem.vuesrc/renderer/src/components/settings/GitHubCopilotOAuth.vue
src/renderer/**/*.{vue,ts}
📄 CodeRabbit Inference Engine (.cursor/rules/vue-shadcn.mdc)
Implement lazy loading for routes and components.
Files:
src/renderer/src/events.tssrc/renderer/src/components/settings/KnowledgeFileItem.vuesrc/renderer/src/components/settings/GitHubCopilotOAuth.vue
src/renderer/**/*.{ts,vue}
📄 CodeRabbit Inference Engine (.cursor/rules/vue-shadcn.mdc)
src/renderer/**/*.{ts,vue}: Use useFetch and useAsyncData for data fetching.
Implement SEO best practices using Nuxt's useHead and useSeoMeta.
Files:
src/renderer/src/events.tssrc/renderer/src/components/settings/KnowledgeFileItem.vuesrc/renderer/src/components/settings/GitHubCopilotOAuth.vue
src/main/presenter/llmProviderPresenter/providers/*.ts
📄 CodeRabbit Inference Engine (CLAUDE.md)
src/main/presenter/llmProviderPresenter/providers/*.ts: Create provider file in src/main/presenter/llmProviderPresenter/providers/ when adding a new LLM provider
Implement coreStream method following standardized event interface in LLM provider files
src/main/presenter/llmProviderPresenter/providers/*.ts: Each file insrc/main/presenter/llmProviderPresenter/providers/*.tsshould handle interaction with a specific LLM API, including request/response formatting, tool definition conversion, native/non-native tool call management, and standardizing output streams to a common event format.
Provider implementations must use acoreStreammethod that yields standardized stream events to decouple the main loop from provider-specific details.
ThecoreStreammethod in each Provider must perform a single streaming API request per conversation round and must not contain multi-round tool call loop logic.
Provider files should implement helper methods such asformatMessages,convertToProviderTools,parseFunctionCalls, andprepareFunctionCallPromptas needed for provider-specific logic.
All provider implementations must parse provider-specific data chunks and yield standardized events for text, reasoning, tool calls, usage, errors, stop reasons, and image data.
When a provider does not support native function calling, it must prepare messages using prompt wrapping (e.g.,prepareFunctionCallPrompt) before making the API call.
When a provider supports native function calling, MCP tools must be converted to the provider's format (e.g., usingconvertToProviderTools) and included in the API request.
Provider implementations should aggregate and yield usage events as part of the standardized stream.
Provider implementations should yield image data events in the standardized format when applicable.
Provider implementations should yield reasoning events in the standardized format when applicable.
Provider implementations should yield tool call events (`tool_call_star...
Files:
src/main/presenter/llmProviderPresenter/providers/githubCopilotProvider.ts
src/renderer/src/**/*.vue
📄 CodeRabbit Inference Engine (CLAUDE.md)
src/renderer/src/**/*.vue: Use Composition API for all Vue 3 components
Use Tailwind CSS with scoped styles for styling
Organize components by feature in src/renderer/src/
Follow existing component patterns in src/renderer/src/ when creating new UI components
Use Composition API with proper TypeScript typing for new UI components
Implement responsive design with Tailwind CSS for new UI components
Add proper error handling and loading states for new UI componentsUse scoped styles to prevent CSS conflicts between components
Files:
src/renderer/src/components/settings/KnowledgeFileItem.vuesrc/renderer/src/components/settings/GitHubCopilotOAuth.vue
src/main/presenter/mcpPresenter/inMemoryServers/*.ts
📄 CodeRabbit Inference Engine (CLAUDE.md)
Implement new MCP tool in src/main/presenter/mcpPresenter/inMemoryServers/ when adding a new MCP tool
Files:
src/main/presenter/mcpPresenter/inMemoryServers/builtinKnowledgeServer.ts
🧠 Learnings (14)
📓 Common learnings
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/development-setup.mdc:0-0
Timestamp: 2025-07-21T01:45:40.026Z
Learning: Applies to **/*.{js,jsx,ts,tsx} : 使用 OxLint 进行代码检查
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to **/*.{ts,tsx} : Strict type checking enabled for TypeScript
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.289Z
Learning: Applies to src/renderer/**/*.{vue} : Use Vue 3 with TypeScript, leveraging defineComponent and PropType.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to **/*.{ts,tsx,js,jsx,vue} : Use English for logs and comments
src/main/utils/vector.ts (12)
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/shared/**/*.ts : Shared types in src/shared/
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.289Z
Learning: Applies to src/renderer/**/*.{ts,tsx,vue} : Use arrow functions for methods and computed properties.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/project-structure.mdc:0-0
Timestamp: 2025-07-21T01:47:11.596Z
Learning: Applies to src/shared/**/*.{ts,tsx,d.ts} : 共享类型定义放在 shared 目录
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/error-logging.mdc:0-0
Timestamp: 2025-07-21T01:46:19.681Z
Learning: Applies to **/*.{ts,tsx} : 优雅降级处理
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/electron-best-practices.mdc:0-0
Timestamp: 2025-07-21T01:45:54.217Z
Learning: Applies to src/{main,renderer}/**/*.ts : Use context isolation for improved security
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to **/*.{ts,tsx,js,jsx,vue} : Use English for logs and comments
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to **/*.{ts,tsx} : Strict type checking enabled for TypeScript
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/main/presenter/mcpPresenter/index.ts : Register new MCP tool in mcpPresenter/index.ts
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/renderer/src/**/*.{ts,tsx,vue} : Renderer to Main: Use usePresenter.ts composable for direct presenter method calls
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : Provider implementations should aggregate and yield usage events as part of the standardized stream.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : Provider implementations should yield image data events in the standardized format when applicable.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/main/presenter/configPresenter/**/*.ts : Centralize configuration in configPresenter/
src/main/lib/textsplitters/index.ts (10)
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/error-logging.mdc:0-0
Timestamp: 2025-07-21T01:46:19.681Z
Learning: Applies to **/*.{ts,tsx} : 避免记录敏感信息
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/development-setup.mdc:0-0
Timestamp: 2025-07-21T01:45:40.026Z
Learning: Applies to **/*.{js,jsx,ts,tsx} : Log和注释使用英文书写
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to **/*.{ts,tsx,js,jsx,vue} : Use English for logs and comments
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/error-logging.mdc:0-0
Timestamp: 2025-07-21T01:46:19.681Z
Learning: Applies to **/*.{ts,tsx} : 提供有意义的错误信息
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/shared/**/*.ts : Shared types in src/shared/
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/development-setup.mdc:0-0
Timestamp: 2025-07-21T01:45:40.026Z
Learning: Applies to **/*.{js,jsx,ts,tsx} : 使用 OxLint 进行代码检查
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/error-logging.mdc:0-0
Timestamp: 2025-07-21T01:46:19.681Z
Learning: Applies to **/*.{ts,tsx} : 优雅降级处理
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to **/*.{ts,tsx} : Strict type checking enabled for TypeScript
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/project-structure.mdc:0-0
Timestamp: 2025-07-21T01:47:11.596Z
Learning: Applies to src/shared/**/*.{ts,tsx,d.ts} : 共享类型定义放在 shared 目录
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/error-logging.mdc:0-0
Timestamp: 2025-07-21T01:46:19.681Z
Learning: Applies to **/*.{ts,tsx} : 不要吞掉错误
src/main/events.ts (6)
Learnt from: neoragex2002
PR: #550
File: src/renderer/src/stores/chat.ts:1011-1035
Timestamp: 2025-06-21T15:49:17.044Z
Learning: In src/renderer/src/stores/chat.ts, the user prefers to keep both text and content properties in the handleMeetingInstruction function's sendMessage call, even though they are redundant, rather than removing the content property.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/main/**/*.ts : Main to Renderer: Use EventBus to broadcast events via mainWindow.webContents.send()
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/electron-best-practices.mdc:0-0
Timestamp: 2025-07-21T01:45:54.217Z
Learning: Applies to src/main/presenter/index.ts : The IPC messages from the main process to notify the view mainly rely on the EventBus index.ts to listen for events that need to be notified and then send them to the renderer through the mainWindow
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/index.ts : The main Agent loop should send standardized STREAM_EVENTS (RESPONSE, END, ERROR) to the frontend via eventBus.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/electron-best-practices.mdc:0-0
Timestamp: 2025-07-21T01:45:54.217Z
Learning: Applies to src/main/**/*.ts : Use Electron's built-in APIs for file system and native dialogs
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/electron-best-practices.mdc:0-0
Timestamp: 2025-07-21T01:45:54.217Z
Learning: Applies to src/shared/.d.ts : The shared/.d.ts files are used to define the types of objects exposed by the main process to the renderer process
src/main/presenter/index.ts (13)
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/main/presenter/**/*.ts : One presenter per functional domain
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/main/presenter/configPresenter/**/*.ts : Centralize configuration in configPresenter/
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/renderer/src/**/*.{ts,tsx,vue} : Renderer to Main: Use usePresenter.ts composable for direct presenter method calls
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/index.ts : src/main/presenter/llmProviderPresenter/index.ts should manage the overall Agent loop, conversation history, tool execution via McpPresenter, and frontend communication via eventBus.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/electron-best-practices.mdc:0-0
Timestamp: 2025-07-21T01:45:54.217Z
Learning: Applies to src/renderer/src/composables/usePresenter.ts : The IPC in the renderer process is implemented in usePresenter.ts, allowing direct calls to the presenter-related interfaces exposed by the main process
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : Provider files should implement helper methods such as formatMessages, convertToProviderTools, parseFunctionCalls, and prepareFunctionCallPrompt as needed for provider-specific logic.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : Each file in src/main/presenter/llmProviderPresenter/providers/*.ts should handle interaction with a specific LLM API, including request/response formatting, tool definition conversion, native/non-native tool call management, and standardizing output streams to a common event format.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/main/presenter/mcpPresenter/index.ts : Register new MCP tool in mcpPresenter/index.ts
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/index.ts : The main Agent loop should buffer text content, handle tool call events, format tool results for the next LLM call, and manage conversation continuation logic.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/main/presenter/configPresenter/providers.ts : Add provider configuration in configPresenter/providers.ts when adding a new LLM provider
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/electron-best-practices.mdc:0-0
Timestamp: 2025-07-21T01:45:54.217Z
Learning: Applies to src/main/presenter/index.ts : The IPC messages from the main process to notify the view mainly rely on the EventBus index.ts to listen for events that need to be notified and then send them to the renderer through the mainWindow
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/electron-best-practices.mdc:0-0
Timestamp: 2025-07-21T01:45:54.217Z
Learning: Applies to src/main/**/*.ts : Use Electron's built-in APIs for file system and native dialogs
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/main/**/*.ts : Main to Renderer: Use EventBus to broadcast events via mainWindow.webContents.send()
src/renderer/src/events.ts (6)
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.289Z
Learning: Applies to src/renderer/**/*.{ts,tsx,vue} : Avoid enums; use const objects instead.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.289Z
Learning: Applies to src/renderer/**/*.{ts,tsx,vue} : Use arrow functions for methods and computed properties.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.289Z
Learning: Applies to src/renderer/**/*.{ts,tsx,vue} : Avoid unnecessary curly braces in conditionals; use concise syntax for simple statements.
Learnt from: neoragex2002
PR: #550
File: src/renderer/src/stores/chat.ts:1011-1035
Timestamp: 2025-06-21T15:49:17.044Z
Learning: In src/renderer/src/stores/chat.ts, the user prefers to keep both text and content properties in the handleMeetingInstruction function's sendMessage call, even though they are redundant, rather than removing the content property.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/main/**/*.ts : Main to Renderer: Use EventBus to broadcast events via mainWindow.webContents.send()
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/index.ts : The main Agent loop should send standardized STREAM_EVENTS (RESPONSE, END, ERROR) to the frontend via eventBus.
.github/workflows/build.yml (1)
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/development-setup.mdc:0-0
Timestamp: 2025-07-21T01:45:40.026Z
Learning: 使用 pnpm 包管理
src/main/presenter/llmProviderPresenter/providers/githubCopilotProvider.ts (12)
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : Provider files should implement helper methods such as formatMessages, convertToProviderTools, parseFunctionCalls, and prepareFunctionCallPrompt as needed for provider-specific logic.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : Each file in src/main/presenter/llmProviderPresenter/providers/*.ts should handle interaction with a specific LLM API, including request/response formatting, tool definition conversion, native/non-native tool call management, and standardizing output streams to a common event format.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : Implement coreStream method following standardized event interface in LLM provider files
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/main/presenter/configPresenter/providers.ts : Add provider configuration in configPresenter/providers.ts when adding a new LLM provider
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : Create provider file in src/main/presenter/llmProviderPresenter/providers/ when adding a new LLM provider
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : Provider implementations must use a coreStream method that yields standardized stream events to decouple the main loop from provider-specific details.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : Provider implementations should yield tool call events (tool_call_start, tool_call_chunk, tool_call_end) in the standardized format.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : Provider implementations should yield text events in the standardized format.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : All provider implementations must parse provider-specific data chunks and yield standardized events for text, reasoning, tool calls, usage, errors, stop reasons, and image data.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : The coreStream method in each Provider must perform a single streaming API request per conversation round and must not contain multi-round tool call loop logic.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/error-logging.mdc:0-0
Timestamp: 2025-07-21T01:46:19.681Z
Learning: Applies to **/*.{ts,tsx} : 实现错误重试机制
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/error-logging.mdc:0-0
Timestamp: 2025-07-21T01:46:19.681Z
Learning: Applies to **/*.{ts,tsx} : 始终使用 try-catch 处理可能的错误
src/renderer/src/components/settings/KnowledgeFileItem.vue (10)
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.289Z
Learning: Applies to src/renderer/**/*.{vue} : Use template syntax for declarative rendering.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.289Z
Learning: Applies to src/renderer/**/*.{vue} : Use Iconify/Vue for icon implementation.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.289Z
Learning: Applies to src/renderer/**/*.{vue} : Prefer "lucide:" icon family as the primary choice.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.289Z
Learning: Applies to src/renderer/**/*.{vue} : Use composition API and declarative programming patterns; avoid options API.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.289Z
Learning: Applies to src/renderer/**/*.{vue} : Use <script setup> syntax for concise component definitions.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/renderer/src/**/*.vue : Organize components by feature in src/renderer/src/
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-best-practices.mdc:0-0
Timestamp: 2025-07-21T01:47:28.788Z
Learning: Applies to src/renderer/src/**/*.{vue,ts,tsx,js,jsx} : Use the Composition API for better code organization and reusability
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.289Z
Learning: Applies to src/renderer/**/*.{vue} : Follow naming pattern: {collection}:{icon-name} for icons.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.289Z
Learning: Applies to src/renderer/**/*.{vue} : Use Shadcn Vue, Radix Vue, and Tailwind for components and styling.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.289Z
Learning: Applies to src/renderer/components/**/*.vue : Use PascalCase for component names (e.g., AuthWizard.vue).
src/renderer/src/components/settings/GitHubCopilotOAuth.vue (10)
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.289Z
Learning: Applies to src/renderer/**/*.{vue} : Use <script setup> syntax for concise component definitions.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.289Z
Learning: Applies to src/renderer/components/**/*.vue : Use PascalCase for component names (e.g., AuthWizard.vue).
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.289Z
Learning: Applies to src/renderer/**/*.{vue} : Use Iconify/Vue for icon implementation.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.289Z
Learning: Applies to src/renderer/**/*.{vue} : Use composition API and declarative programming patterns; avoid options API.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-best-practices.mdc:0-0
Timestamp: 2025-07-21T01:47:28.788Z
Learning: Applies to src/renderer/src/**/*.{vue,ts,tsx,js,jsx} : Use the Composition API for better code organization and reusability
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.289Z
Learning: Applies to src/renderer/**/*.{vue} : Import Icon component from Iconify/Vue.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.289Z
Learning: Applies to src/renderer/**/*.{ts,tsx,vue} : Use arrow functions for methods and computed properties.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.289Z
Learning: Applies to src/renderer/**/*.{vue} : Use the Icon component with lucide icons.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/renderer/src/**/*.vue : Use Composition API with proper TypeScript typing for new UI components
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/vue-shadcn.mdc:0-0
Timestamp: 2025-07-23T00:45:57.289Z
Learning: Applies to src/renderer/**/*.{vue} : Prefer "lucide:" icon family as the primary choice.
package.json (5)
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/development-setup.mdc:0-0
Timestamp: 2025-07-21T01:45:40.026Z
Learning: Applies to **/*.{js,jsx,ts,tsx} : 使用 OxLint 进行代码检查
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to test/**/*.{ts,tsx,js,jsx} : Use Vitest for unit and integration tests
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/project-structure.mdc:0-0
Timestamp: 2025-07-21T01:47:11.596Z
Learning: Applies to tests/**/*.{ts,js,tsx,jsx} : 测试文件放在 tests 目录
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Run tests with coverage reporting
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to **/*.{ts,tsx} : Strict type checking enabled for TypeScript
src/main/presenter/knowledgePresenter/knowledgeTaskPresenter.ts (5)
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/main/presenter/**/*.ts : One presenter per functional domain
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/index.ts : src/main/presenter/llmProviderPresenter/index.ts should manage the overall Agent loop, conversation history, tool execution via McpPresenter, and frontend communication via eventBus.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : Provider implementations should yield stop events with appropriate stop_reason in the standardized format.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/main/presenter/configPresenter/**/*.ts : Centralize configuration in configPresenter/
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/index.ts : The main Agent loop should buffer text content, handle tool call events, format tool results for the next LLM call, and manage conversation continuation logic.
src/main/presenter/filePresenter/FilePresenter.ts (10)
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : Provider files should implement helper methods such as formatMessages, convertToProviderTools, parseFunctionCalls, and prepareFunctionCallPrompt as needed for provider-specific logic.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/main/presenter/configPresenter/**/*.ts : Centralize configuration in configPresenter/
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : Each file in src/main/presenter/llmProviderPresenter/providers/*.ts should handle interaction with a specific LLM API, including request/response formatting, tool definition conversion, native/non-native tool call management, and standardizing output streams to a common event format.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/main/presenter/**/*.ts : One presenter per functional domain
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : When a provider does not support native function calling, it must prepare messages using prompt wrapping (e.g., prepareFunctionCallPrompt) before making the API call.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/renderer/src/**/*.{ts,tsx,vue} : Renderer to Main: Use usePresenter.ts composable for direct presenter method calls
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : Implement coreStream method following standardized event interface in LLM provider files
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : Provider implementations should yield image data events in the standardized format when applicable.
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/electron-best-practices.mdc:0-0
Timestamp: 2025-07-21T01:45:54.217Z
Learning: Applies to src/renderer/src/composables/usePresenter.ts : The IPC in the renderer process is implemented in usePresenter.ts, allowing direct calls to the presenter-related interfaces exposed by the main process
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: .cursor/rules/llm-agent-loop.mdc:0-0
Timestamp: 2025-07-21T01:46:52.865Z
Learning: Applies to src/main/presenter/llmProviderPresenter/providers/*.ts : Provider implementations should yield tool call events (tool_call_start, tool_call_chunk, tool_call_end) in the standardized format.
src/main/presenter/mcpPresenter/inMemoryServers/builtinKnowledgeServer.ts (2)
Learnt from: CR
PR: ThinkInAIXYZ/deepchat#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-21T01:45:33.768Z
Learning: Applies to src/main/presenter/mcpPresenter/inMemoryServers/*.ts : Implement new MCP tool in src/main/presenter/mcpPresenter/inMemoryServers/ when adding a new MCP tool
Learnt from: neoragex2002
PR: #550
File: src/main/presenter/mcpPresenter/inMemoryServers/meetingServer.ts:250-252
Timestamp: 2025-06-21T15:48:29.950Z
Learning: In the meeting server implementation (src/main/presenter/mcpPresenter/inMemoryServers/meetingServer.ts), when multiple tabs have the same title, the user prefers to let the code silently select the first match without adding warnings or additional ambiguity handling.
🧬 Code Graph Analysis (2)
src/main/presenter/filePresenter/FilePresenter.ts (1)
src/shared/chat.d.ts (1)
MessageFile(74-82)
src/main/presenter/mcpPresenter/inMemoryServers/builtinKnowledgeServer.ts (1)
src/shared/presenter.d.ts (1)
BuiltinKnowledgeConfig(1481-1492)
🪛 YAMLlint (1.37.1)
.github/workflows/build.yml
[error] 47-47: trailing spaces
(trailing-spaces)
🔇 Additional comments (9)
src/main/presenter/index.ts (1)
1-1: Import semicolon removal is inline with lint-rules – no further action.Nothing functional changed; the edit simply satisfies the formatting checker introduced by this PR.
src/main/lib/textsplitters/index.ts (1)
3-4: Comment block cleaned – good.Tiny formatting only; no impact.
src/main/utils/vector.ts (1)
1-1: Import style consistent with project formatter – looks good
Switching to single quotes aligns with Prettier defaults and the newformat:checkgate. No functional impact.package.json (1)
21-21: 👍 Addedformat:checkscript integrates nicely with CI
Prettier is already indevDependencies, so the step will work out-of-the-box.src/renderer/src/components/settings/KnowledgeFileItem.vue (1)
10-13: Multi-line attribute formatting improves readability – good change
No behavioural impact; aligns with the prettier style enforced in this PR.src/main/presenter/llmProviderPresenter/providers/githubCopilotProvider.ts (1)
395-410: Whitespace cleanup acknowledged
The removed blank lines reduce vertical noise without affecting logic.Also applies to: 546-561
src/main/presenter/mcpPresenter/inMemoryServers/builtinKnowledgeServer.ts (1)
19-19: Constructor formatting change looks goodNo functional impact – only whitespace collapsed.
src/renderer/src/components/settings/GitHubCopilotOAuth.vue (2)
24-24: Template indentation fix LGTMPure formatting; no concerns.
221-222: Handler call indentation LGTMNo logic change; reads clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/prcheck.yml (1)
32-37: Consolidate lint + format checks & strip trailing whitespaceYAML-lint flags trailing spaces on lines 32 & 35, and the new “lint” step duplicates the existing “Check Lint” step (lines 48-50). Running the same command twice lengthens CI time without adding coverage.
Diff suggestion—merge the two checks into one consolidated step (and remove the blank line containing only spaces):
- - - name: lint - run: pnpm run lint - - - name: format:check - run: pnpm run format:check + - name: Check formatting and linting + run: | + pnpm run format:check + pnpm run lintThis:
- Eliminates the whitespace lint warnings.
- Keeps formatting and linting in a single place, avoiding the later duplicate run.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/prcheck.yml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/prcheck.yml
[error] 32-32: trailing spaces
(trailing-spaces)
[error] 35-35: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build-check (x64)
|
LGTM |
* (WIP) feat: add Builtin Knowledge Server and settings integration * feat: add multiple languages translation * feat: enhance BuiltinKnowledgeSettings with model selection and update translations * feat: update BuiltinKnowledgeSettings with enhanced configuration options and translations * feat: update knowledge base settings to use 'builtinKnowledge' and enhance BuiltinKnowledgeSettings with URL query parameter handling * feat: enhance BuiltinKnowledgeSettings with model selection and error handling for missing models * feat: add confirmation dialog and error messages for removing built-in knowledge configurations * props * [WIP] feat: implement KnowledgePresenter and related embedding functionality * [WIP] feat: add KnowledgeConfHelper for managing knowledge base configurations * [WIP] feat: log new knowledge config additions in KnowledgePresenter * [WIP] feat: enhance knowledge base settings and descriptions across components * [WIP] feat: enhance Built-in Knowledge settings and descriptions, add advanced options and tooltips * [WIP] feat: add dimensionsHelper to settings for better user guidance on embedding dimensions * [WIP] feat: add getDimensions method and update embedding handling across providers * [wip] feat: enhance embedding handling by adding error handling and resetting model selection in settings * [WIP] feat: refactor embedding handling to use modelId and providerId, enhance KnowledgePresenter integration * [WIP] feat: update KnowledgePresenter and LLMProviderPresenter to improve embedding handling and error logging * [WIP] feat: enhance BuiltinKnowledgeSettings with additional parameters and loading logic for better user experience * [WIP] feat: enhance KnowledgePresenter to handle deleted configs and improve reset logic * [WIP] feat: update LLMProviderPresenter and OllamaProvider to enhance model listing with additional configuration properties * [WIP] feat: enhance Ollama model integration by updating local models to include dynamic configuration retrieval * [WIP] fix: update getRagApplication to include baseURL in Embeddings instantiation * [WIP] feat: update getDimensions method to return structured response with error handling * [WIP] feat: enhance BuiltinKnowledgeSettings with dynamic dimension detection and loading state * feat: add duration to toast notifications for improved user feedback * feat: add BuiltinKnowledge file upload box * feat: update TODO list with additional parameters and logic improvements for BuiltinKnowledgeSettings and OllamaProvider * feat: add delay duration to tooltips for improved user experience * feat: add BuiltinKnowledge file reload button * feat: limit BuiltinKnowledge file types * feat: add new BuiltinKnowledge form items * fix: fix BuiltInKnowledge embedding modelId * 还原lucide-vue-next版本提升的修改 * fix: fix BuiltInKnowledge rerank form item * [WIP] refactor: update knowledge base configuration to use BuiltinKnowledgeConfig and remove unused embedding classes (duckdb does not provide an binrary extension for windows) * chore: remove unused llm-tools embedjs dependencies from package.json * feat: implement DuckDBPresenter for vector database operations (make sure duckdb extension vss has been installed) * refactor: update import statements to use default imports for fs and path * feat: add BuiltinKnowledge form Information display * refactor: restructure postinstall script for clarity and improved extension installation process * refactor: update icon in BuiltinKnowledgeSettings and change v-show to v-if in KnowledgeBaseSettings; add file type acceptance in KnowledgeFile * refactor: simplify file icon retrieval by centralizing logic in getMimeTypeIcon utility function * refactor: enhance type safety for builtinKnowledgeDetail and improve code readability in KnowledgeBaseSettings and KnowledgeFile components * fix: add optional chaining for builtinKnowledgeDetail description to prevent potential runtime errors * feat: add KnowledgeFileMessage type and file management methods to IKnowledgePresenter interface * feat: enhance DuckDBPresenter with file management methods and update IVectorDatabasePresenter interface * refactor: rename methods and update table names in DuckDBPresenter for clarity and consistency * feat: implement file management methods in RagPresenter and update IKnowledgePresenter interface * feat: access BuiltinKnowledge file interface * fix: fix prompt information error * fix: improve error toast description for file upload failure * feat: add file management methods and enhance interfaces in presenters; update file handling logic * feat: add RAG_EVENTS for file update notifications; implement vector utility functions * feat: enhance LLM dimension handling and add normalization support; update related components and translations * feat: update vector database handling to include normalization support; refactor related methods * feat: add dayjs dependency for time formatting * feat: add a listener for FILE_UPDATED * feat: change the params format * feat: change callback function * fix: resolve merge conflicts in localization files * feat(knowledge): Implement file listing and fix embedding parameters * feat: change loadlist after file upload and file delete * fix(knowledge): correct timestamp storage and refactor database interaction * fix: remove unnecessary nextTick in reAddFile * fix: remove duplicate loadList in deleteFile * feat(knowledge): enhance file handling with status updates and event emissions * feat: add similarity query functionality to RagPresenter and DuckDBPresenter * feat: implement similarity query in BuiltinKnowledgeServer and update KnowledgeFile component * feat: enhance BuiltinKnowledge module with detailed architecture and design documentation * feat: remove part of builtinKnowledge base info display * fix: fix file status switching bug * feat: add builtinKnowledge file search * fix: reemove redundant div * feat: enhance file handling process in BuiltinKnowledge design with detailed flow for file insertion and retrieval * feat: update BuiltinKnowledge design document with refined file handling and retrieval processes * feat: refactor BuiltinKnowledge module by replacing RagPresenter with KnowledgeStorePresenter and updating related components * feat: add builtinKnowledge file search score * feat: enhance error handling in file upload and re-upload processes in KnowledgeFile component * fix: fix overly long file names * fix: fix overly long file names * refactor: simplify checkpoint logic in DuckDBPresenter open method * feat: add @langchain/core dependency to enhance functionality * fix: update file extension handling to use correct variable name * feat: add crash reporter initialization for error tracking * fix: enhance logging and error handling in DuckDBPresenter methods * fix: move crash reporter initialization inside logging check * feat: add toast messages for model status and L2 normalization support in multiple languages * refactor: simplify fileTask method by removing unnecessary promise wrapping and adding comments * refactor: update model handling by removing unnecessary ModelConfig references and enhancing model info structure * fix: update company name format in crash reporter configuration * fix: fix embedding model default settings and revert ModelConfigItem changed * fix: cancel crash report * fix: fix pulling model type not assignable problem * fix: remove unneccessary files * fix: remove unnecessary files * fix: block option rerank model (not implemented yet) * fix: dynamically decide whether to show model customization configuration button * fix: remove useless i18n translations * fix: remove useless dependencies and improve definitions * perf: imporve knowledgePresenter resource release * perf: convert to async function for better error handling * perf: convert to async function for better error handling * perf: imporve vector utils * fix: fix error words * (WIP) feat: selectively enable mcp toolsets * perf: mark the interrupted task as a user-cancelled task when app startup * perf: add try-catch to enhance program stability * fix: declared but never read error * fix: missing attr file_id when insert vector(s) * perf: skip duckdb vss extension installation on macOS * fix: remove bad references * perf: disable auto install duckdb vss extension 1. will cause macOS sign problem 2. will increase 40Mb for build * perf: remove langchain from package, reduce package size * fix: declared but never read error * perf: use Bipolar Quadratic Mapping algorithm to ensure that the vector confidence is between [0,1] * perf: a more appropriate scaling factor * perf: knowledge config update logic * fix: update text fixed * fix: lint * feat:Add Groq as Provider * update groq.svg * update groqProvider.ts * (WIP) perf: enhance knowledge management with chunk processing and task scheduling features * feat: remove python code run on js * (WIP) feat: add clearDirtyData method to clean up orphaned vectors and chunks * (WIP) feat: enhance DuckDBPresenter with logging and new insertVectors method; update KnowledgeStorePresenter for chunk processing and status management * feat: refactor task management in KnowledgeTaskPresenter; enhance chunk processing and status handling in KnowledgeStorePresenter * feat: add enabledMcpTools field to conversation for controlling MCP tools * feat: filter MCP tools by enabledMcpTools * refactor: update task management and chunk processing in KnowledgePresenter and KnowledgeTaskPresenter; enhance error handling and metadata management * feat: enhance DuckDBPresenter and KnowledgeStorePresenter with error handling; update task management and chunk processing * feat: enhance task management in KnowledgeTaskPresenter; improve error handling and processing flow in KnowledgeStorePresenter; update file list handling in KnowledgeFile component * feat: refactor toggle logic for MCP service and tool state * feat: enhance file handling in KnowledgeStorePresenter; improve error handling and metadata management in KnowledgeFile and presenter.d.ts * feat: update DuckDBPresenter and presenter.d.ts; enhance transaction management and introduce new task status summary interface * refactor: remove obsolete RAG event constants for file progress, chunk completion, and task queue status * feat: add file progress tracking and event emission for file processing updates * fix: update DuckDB dependency to version 1.3.2-alpha.25; enhance database cleanup logic in KnowledgePresenter * feat: enhance KnowledgePresenter configuration management; improve store presenter handling and update method signature * feat: add dialog handling with DialogPresenter and MessageDialog component * feat: enhance dialog handling with improved response management and new closeable option * feat: refactor dialog handling to support timeout and response management with enhanced type definitions * feat: update dialog request types for consistency and clarity in MessageDialog component * feat: enhance MessageDialog component with i18n support for descriptions and improve dialog timeout handling * feat: enhance dialog handling with improved error management and response structure * feat: improve dialog error handling and response structure in DialogPresenter * fix: e2b key not working * (WIP) perf: enhance knowledge management with chunk processing and task scheduling features * feat: implement task management features for pausing and resuming tasks in DuckDB and Knowledge presenters * feat: implement database migration and metadata management in DuckDBPresenter * fix: ensure database version is set after migration completion * update githubCopilotProvider * update Copilot Model * feat: Refactor Knowledge Presenter and related components - Updated KnowledgePresenter design document to reflect new architecture and features, including improved lifecycle management and event handling. - Enhanced file processing flow in KnowledgeStorePresenter to ensure immediate feedback and error handling during file reading. - Modified KnowledgeFile.vue to support additional file types and improve file status handling in the UI. - Improved configuration management for Knowledge Presenter, allowing for better integration and user experience. * use provider check if model id is not provided * fix: reorder parameters in getEmbeddings method for consistency across providers * feat: add export markdown * check copilot provider by model * update GitHubCopilotOAuth.vue * fix: remove redundant 'redetectDimensions' translations from multiple language settings * wip: better style * wip: fix worker * chore: remove unuse code * feat: add i18n * fix: format * fix: convert uploadedAt to string for consistent data handling * fix: lint * docs: add comprehensive documentation for Dialog module and its components * fix: i18n and ai review * Update src/main/events.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update src/main/lib/textsplitters/index.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update src/renderer/src/lib/utils.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * refactor: improve error handling and logging in dialog and knowledge task presenters; update text sanitization and localization * fix: #623 * feat: change function name * feat: add empty data display * feat: add click outside to close sidebar functionality * style(threads): optimize the operation logic of new sessions (#633) * style(threads): optimize the operation logic of new sessions * chore: format code * chore(ci): add code lint check (#634) * chore(ci): add code lint check * chore: remove linting steps from build workflow; add linting steps to PR check workflow * fix: resolve sidebar toggle button conflict (#637) * fix: Bugfix/gemini thinking (#639) * fix: gemini reasoning by config * feat: support gemini thinking * fix: user define model config first * fix: format * chore: ignore md for format * doc: remove empty line * fix: ai review * perf(ChatConfig): Set the TooltipProvider component to add a delay duration of 200& update the include configuration in the tsconfig.web.json file (#640) * feat: Add thinking budget support for Gemini 2.5 series models (#643) * chore: update 0.2.7 --------- Co-authored-by: hllshiro <40970081+hllshiro@users.noreply.github.com> Co-authored-by: ysli <sqsyli@qq.com> Co-authored-by: zhangmo8 <wegi866@gmail.com> Co-authored-by: dw9 <xweimvp@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: yyhhyyyyyy <yyhhyyyyyy8@gmail.com> Co-authored-by: 阿菜 Cai <1064425721@qq.com> Co-authored-by: 阿菜 Cai <jimmyrss1102@gmail.com> Co-authored-by: flingyp <flingyp@163.com>
Pull Request Description
The code
lintandformatshould be checked in each PR to ensure that the standards and format of the code are consistent each time.I use
pnpm run formatall the code using format.Summary by CodeRabbit