[feedback-pipeline-3] removed structopt for parsing commandline arguments#504
Merged
CommanderStorm merged 2 commits intocoordidante_feedback_2from Apr 10, 2023
Merged
Conversation
structopt for parsing commandline arguments
octycs
approved these changes
Apr 10, 2023
Contributor
octycs
left a comment
There was a problem hiding this comment.
Changes are all fine for me. Maybe it would be good to mention GITHUB_TOKEN and JWT_KEY in the Readme now.
CommanderStorm
added a commit
that referenced
this pull request
Apr 10, 2023
* changed the feedback api (renaming `delete_issue_requested` to `deletion_requested`) * [feedback-pipeline-3] removed `structopt` for parsing commandline arguments (#504) * removed structopt for parsing commandline arguments * documented the used environment variables in the README
CommanderStorm
added a commit
that referenced
this pull request
Apr 12, 2023
…ructured (#502) * refactored the feedback system to be flatter structured * [feedback-pipeline-2] API Change (#503) * changed the feedback api (renaming `delete_issue_requested` to `deletion_requested`) * [feedback-pipeline-3] removed `structopt` for parsing commandline arguments (#504) * removed structopt for parsing commandline arguments * documented the used environment variables in the README * refactored token management to be fully based in the tokens module * formatting fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First PR in the #501 PR-Train
Proposed Changes (include Screenshots if possible)
structoptto get keys from arguments as an alternative to commandline argumentsHow to test this PR
How has this been tested?
Checklist: