Skip to content

[feedback-pipeline-2] API Change#503

Merged
CommanderStorm merged 3 commits intocoordinate_feedback_1from
coordidante_feedback_2
Apr 10, 2023
Merged

[feedback-pipeline-2] API Change#503
CommanderStorm merged 3 commits intocoordinate_feedback_1from
coordidante_feedback_2

Conversation

@CommanderStorm
Copy link
Member

First PR in the #501 PR-Train

⚠️ This change has been pulled out, as this is a breaking API-Chnage ⚠️

Proposed Changes (include Screenshots if possible)

  • renamed delete_issue_requested to deletion_requested as this would better mach the API I will be introducing in further PRs

How to test this PR

  1. Code review

How has this been tested?

/

Checklist:

  • I have updated the documentation / No need to update the documentation
  • I have run the linter

@CommanderStorm CommanderStorm added the server Related to the backend/server label Apr 9, 2023
@CommanderStorm CommanderStorm requested a review from octycs April 9, 2023 21:32
@CommanderStorm CommanderStorm self-assigned this Apr 9, 2023
…uments (#504)

* removed structopt for parsing commandline arguments
* documented the used environment variables in the README
@CommanderStorm CommanderStorm merged commit 301d44b into coordinate_feedback_1 Apr 10, 2023
@CommanderStorm CommanderStorm deleted the coordidante_feedback_2 branch April 10, 2023 21:23
CommanderStorm added a commit that referenced this pull request Apr 12, 2023
…ructured (#502)

* refactored the feedback system to be flatter structured

* [feedback-pipeline-2]  API Change (#503)

* changed the feedback api (renaming `delete_issue_requested` to `deletion_requested`)
* [feedback-pipeline-3] removed `structopt` for parsing commandline arguments (#504)

* removed structopt for parsing commandline arguments
* documented the used environment variables in the README

* refactored token management to be fully based in the tokens module

* formatting fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

server Related to the backend/server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants