Skip to content

[Review] SyliusReviewBundle#3980

Merged
pjedrzejewski merged 30 commits intoSylius:masterfrom
GSadee:sylius-review-bundle
Feb 19, 2016
Merged

[Review] SyliusReviewBundle#3980
pjedrzejewski merged 30 commits intoSylius:masterfrom
GSadee:sylius-review-bundle

Conversation

@GSadee
Copy link
Copy Markdown
Member

@GSadee GSadee commented Jan 26, 2016

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets
License MIT
Doc PR

Initial implementation of SyliusReviewBundle, which allows to easily manage review system. It's based on @Zales0123 #3300.

"Reviewable" and "Reviewer" classes can be configured under sylius_review tag:

sylius_review:
    resources:
        product:
            subject: %sylius.model.product.class%
            review:
                classes:
                    model: Sylius\Component\Core\Model\ProductReview
                    form:
                        default: Sylius\Bundle\CoreBundle\Form\Type\ProductReviewType
                        admin: Sylius\Bundle\CoreBundle\Form\Type\ProductReviewAdminType
            reviewer:
                classes:
                    model: Sylius\Component\Core\Model\Customer

I have added changes from #3372 and extended this PR to use CustomerGuestType in ReviewType.

@pjedrzejewski pjedrzejewski mentioned this pull request Jan 26, 2016
Closed
7 tasks
@pjedrzejewski pjedrzejewski mentioned this pull request Jan 27, 2016
Merged
@michalmarcinkowski michalmarcinkowski added this to the v0.17.0 milestone Jan 27, 2016
aramalipoor
aramalipoor reviewed Jan 28, 2016
View reviewed changes
app/migrations/Version20150825160125.php Outdated
Copy link
Copy Markdown
Contributor

@aramalipoor aramalipoor Jan 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for these (3) migrations! Only 1 is sufficient, which adds/removes review table :D

@GSadee GSadee force-pushed the sylius-review-bundle branch from 65e15ce to dda2112 Compare January 29, 2016 10:37
@pjedrzejewski
Copy link
Copy Markdown
Contributor

pjedrzejewski commented Jan 29, 2016

@GSadee Rebase has gone wrong this one probably... :)

@nakashu
Copy link
Copy Markdown
Contributor

nakashu commented Feb 2, 2016

@GSadee @pjedrzejewski can you estimate when this will be finished? Got a project in development where reviews are needed, so wanted to know if I should wait or implement it on my own.
thanks.

@pjedrzejewski
Copy link
Copy Markdown
Contributor

pjedrzejewski commented Feb 2, 2016

We need this too and we want to get it merged by the end of the week. I would review it today already but rebase went really wrong...

@michalmarcinkowski
Copy link
Copy Markdown
Contributor

michalmarcinkowski commented Feb 2, 2016

@nakashu it will be done ASAP. We want to merge it this week.

@nakashu
Copy link
Copy Markdown
Contributor

nakashu commented Feb 2, 2016

great to hear. thanks

@nakashu
Copy link
Copy Markdown
Contributor

nakashu commented Feb 2, 2016

I'll probably add support for schema aggregate rating in PR after you merge this. (if it is not present.)

Propabably for another RFC, is how to implement it.

  • json-lc - this can be decoupled from temlplate, but is less supported/trusted
  • microdata - coupled to templates, or using macros and some crazy template stuff.

https://schema.org/AggregateRating

WIll create an RFC after merge.

@GSadee GSadee force-pushed the sylius-review-bundle branch from dda2112 to dad43bf Compare February 3, 2016 09:19
Zales0123
Zales0123 reviewed Feb 3, 2016
View reviewed changes
features/reviews/reviews.feature Outdated
Copy link
Copy Markdown
Contributor

@Zales0123 Zales0123 Feb 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shall be consistent and align all new scenarios to left.

Zales0123 and others added 17 commits February 19, 2016 08:48
@Zales0123 @GSadee
[Review] Make reviews more generic
2c019b7 
Split configurations into Review-, Product- and CoreBundle parts
@Zales0123 @GSadee
[Review] Split ProductReviewAdminType to Product- and CoreBundle part
85e0420
@Zales0123 @GSadee
[Review] Implemented ReviewDeleteListener
d216f9e 
Also some general and CS fixes.
@Zales0123 @GSadee
[Review] Change ReviewAuthorInterface to ReviewerInterface
9036bd3
@Zales0123 @GSadee
[Review] Added default Reviewer class
bbe88ce
@Zales0123 @GSadee
[Review] Added listeners on Product and Customer deletion
5b08884
@Zales0123 @GSadee
[Review] PR review changes vol.1
97f5fe0
@Zales0123 @GSadee
[Review] Added dynamic tags on ReviewDeleteListener
e007721 
Also some changes/fixes in templates and crucial changes in review creation.
@Zales0123 @GSadee
[Review] Fixed javascripts scenarios
c349d27 
Also some minor PR review fixes
@GSadee
[Review] Changed configuration after changes in ResourceBundle
c31bfe4
@GSadee
[Review] Added customer guest type to review and fixed unique email v…
ad1703b 
…alidator
@GSadee
[Review] Fixed updating review state
650f7ef
@GSadee
[Review] Fixed problem with lowercase text on buttons
21e2f8f
@GSadee
[Review] Fixed relation between Product and Reviews
17fffcb
@GSadee
[Review] Changed ProductReviewController to use FOSRestController ins…
c9ef294 
…tead of ResourceController
@GSadee
[Review] Changed migrations files for review
5a11a2e
@GSadee
[Review] CS fixes
a2167e3
@GSadee GSadee force-pushed the sylius-review-bundle branch from 94e26b0 to 6a793f9 Compare February 19, 2016 07:49
pjedrzejewski
pjedrzejewski reviewed Feb 19, 2016
View reviewed changes
src/Sylius/Bundle/ReviewBundle/composer.json Outdated
},
"extra": {
"branch-alias": {
"dev-master": "0.17/-dev"
Copy link
Copy Markdown
Contributor

@pjedrzejewski pjedrzejewski Feb 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove /.

@GSadee GSadee force-pushed the sylius-review-bundle branch from 6a793f9 to c9a86d0 Compare February 19, 2016 11:10
pjedrzejewski pushed a commit that referenced this pull request Feb 19, 2016
Merge pull request #3980 from GSadee/sylius-review-bundle
8ef740e 
[Review] SyliusReviewBundle
@pjedrzejewski pjedrzejewski merged commit 8ef740e into Sylius:master Feb 19, 2016
@pjedrzejewski
Copy link
Copy Markdown
Contributor

pjedrzejewski commented Feb 19, 2016

Long road but we have made it, thanks Grzegorz, Mateusz, Daniel and everyone involved! 👍 🎆

@michalmarcinkowski
Copy link
Copy Markdown
Contributor

michalmarcinkowski commented Feb 19, 2016

That was a big one! Great to see it merged! Thanks everyone 👍

@Zales0123
Copy link
Copy Markdown
Contributor

Zales0123 commented Feb 19, 2016

I'm really glad to see it merged 🎉

@loicmobizel loicmobizel mentioned this pull request May 12, 2016
Closed
@GSadee GSadee deleted the sylius-review-bundle branch September 22, 2017 08:31
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
Merge pull request Sylius#3980 from GSadee/sylius-review-bundle
cca7cef 
[Review] SyliusReviewBundle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.17.0

Development

Successfully merging this pull request may close these issues.