[User] Added proper listener to CustomerGuestType#3372
Closed
Zales0123 wants to merge 5 commits intoSylius:masterfrom
Closed
[User] Added proper listener to CustomerGuestType#3372Zales0123 wants to merge 5 commits intoSylius:masterfrom
Zales0123 wants to merge 5 commits intoSylius:masterfrom
Conversation
37ebb5e to
40f66f8
Compare
7 tasks
Contributor
There was a problem hiding this comment.
We should use interface
cecb4b1 to
cc9f5ca
Compare
Contributor
There was a problem hiding this comment.
I would say we need one more scenario, placing order as guest for already existing customer or is it covered somewhere else?
Contributor
Author
There was a problem hiding this comment.
Good point, fixed 👍
Contributor
9729ff4 to
078666c
Compare
Contributor
Author
|
@pjedrzejewski Rebased and ready for merge (at least I hope so ;)) |
Contributor
|
@michalmarcinkowski I'd like to hear your thoughts as it is your design but I'd love to avoid making this form type stateful. Perhaps we could pass the current customer as option? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While developing SyliusReviewBundle, I realized current CustomerGuestType is not working properly, while embedding in another form. I implemented new listener, that I hope would work better with such form.
Now there are 3 possibilities while using
sylius_customer_guest:RegisteredUserValidatoris triggered