Skip to content

[CI] Replace the full build for 2.0 with the build for 2.2 branch + reduce number of builds#18431

Merged
Rafikooo merged 3 commits intoSylius:2.1from
GSadee:SYL-5612-ci-remove-2.0-full-build
Oct 13, 2025
Merged

[CI] Replace the full build for 2.0 with the build for 2.2 branch + reduce number of builds#18431
Rafikooo merged 3 commits intoSylius:2.1from
GSadee:SYL-5612-ci-remove-2.0-full-build

Conversation

@GSadee
Copy link
Copy Markdown
Member

@GSadee GSadee commented Oct 10, 2025

Q A
Branch? 2.1
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Summary by CodeRabbit

  • Chores

    • Updated CI workflow naming to 2.2 and adjusted daily run schedules (shifted daily run times across workflows).
    • Aligned CI branch matrix to target the 2.2 line across jobs.
  • Tests

    • Standardized test matrix to favor PHP 8.3 (with 8.4 coverage), removing PHP 8.2 in most suites.
    • Revised end-to-end combinations for MySQL, MariaDB, and PostgreSQL to match new PHP/Symfony baselines and added targeted includes to preserve key coverage.

@GSadee GSadee requested review from a team as code owners October 10, 2025 05:00
@GSadee GSadee added the Maintenance CI configurations, READMEs, releases, etc. label Oct 10, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Oct 10, 2025

Walkthrough

Updates to GitHub Actions CI configuration: adjusted scheduled cron times, renamed one workflow to "2.2", changed workflow branch matrix entries to "2.2", and standardized PHP version entries in matrix.json (promoting/removing 8.2, consolidating on 8.3 and 8.4). No job logic or steps were added or removed.

Changes

Cohort / File(s) Change summary
CI schedule adjustment
.github/workflows/ci__full_2_1.yaml
Cron changed from 0 3 * * * to 0 2 * * *.
Workflow rename & branch matrix
.github/workflows/ci__full_2_2.yaml
Workflow name updated to "Continuous Integration 2.2 (Full)"; cron changed from 0 2 * * * to 0 3 * * *; matrix branch entries updated from ["2.0"] to ["2.2"] for static checks, e2e (MariaDB/MySQL/PostgreSQL), and packages.
Matrix JVM/PHP standardization
.github/workflows/matrix.json
Removed PHP 8.2 entries, promoted 8.3 (with Symfony 6.4 baseline in some entries) and retained 8.4; consolidated full static checks to ["8.3","8.4"]; adjusted e2e/package matrices and added specific include variants for full/e2e-mysql.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • GSadee
  • mpysiak
  • TheMilek

Poem

I twitch my whiskers at the nightly run,
Cron hops back an hour to greet the sun. 🌙
PHP 8.3 bounds in, 8.4 stays near,
Workflows renamed, the matrix clear.
A carrot cheer for CI — quick and fun! 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly communicates the main CI change by specifying the replacement of the 2.0 full build with the 2.2 branch and noting the reduction in the number of builds, which directly reflects the modifications made in this PR.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7edcd0b and c5e740f.

📒 Files selected for processing (2)
  • .github/workflows/ci__full_2_1.yaml (1 hunks)
  • .github/workflows/matrix.json (7 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/ci__full_2_1.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: End-to-end tests (MySQL) / Get matrix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 10, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands:

  • 🚀 /bns:deploy to redeploy the environment

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
.github/workflows/ci__full_2_1.yaml (1)

6-6: Fix the cron comment to match actual schedule.

The cron now runs at 02:00 UTC, but the inline comment still claims 03:00. Please update the comment to avoid confusion.

Apply this diff:

-            cron: "0 2 * * *" # Run every day at 3am
+            cron: "0 2 * * *" # Run every day at 2am
.github/workflows/ci__full_2_2.yaml (1)

10-10: Align the concurrency group suffix with the 2.2 workflow.

The concurrency group still ends with -2_0-full, which can confuse tracking and cancellation logic now that this workflow targets 2.2.

Apply this diff:

-    group: ci-${{ github.workflow }}-${{ github.ref }}-2_0-full
+    group: ci-${{ github.workflow }}-${{ github.ref }}-2_2-full
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7dcdad3 and 7edcd0b.

📒 Files selected for processing (3)
  • .github/workflows/ci__full_2_1.yaml (1 hunks)
  • .github/workflows/ci__full_2_2.yaml (6 hunks)
  • .github/workflows/matrix.json (7 hunks)

@Rafikooo Rafikooo merged commit 1a6ac44 into Sylius:2.1 Oct 13, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance CI configurations, READMEs, releases, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants