[CI] Update matrix for 2.1 branch + fix test installer#18088
[CI] Update matrix for 2.1 branch + fix test installer#18088NoResponseMate merged 4 commits intoSylius:2.1from
Conversation
WalkthroughThe changes update GitHub Actions workflow configurations. The CI workflow for MySQL end-to-end tests adds a step to fix Symfony log directory permissions and corrects a log artifact name. The matrix configuration updates database and Symfony versions, adjusts tested state machine adapters, and simplifies some test scenarios. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
❌ Preview Environment deleted from BunnyshellAvailable commands:
|
c8e8310 to
fb99cc3
Compare
cbe9cb5 to
ea720bd
Compare
f4c19a3 to
c55c0e3
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/ci_e2e-mysql.yaml (2)
107-112: Refine Symfony logs directory permission setup
The new step ensures log folder writeability, but parsing console output is brittle. Consider using the--rawflag to retrieve the parameter cleanly and fail fast on lookup errors:- LOGS_DIR=$(bin/console debug:container --parameter=kernel.logs_dir | grep 'kernel.logs_dir' | awk '{print $2}') + LOGS_DIR=$(bin/console debug:container --parameter=kernel.logs_dir --raw) + if [ -z "$LOGS_DIR" ]; then + echo "Unable to determine kernel.logs_dir" + exit 1 + fi🧰 Tools
🪛 YAMLlint (1.37.1)
[warning] 107-107: too many spaces after hyphen
(hyphens)
107-107: Fix YAML list indentation
YAMLlint warns about too many spaces after hyphens. Normalize to a single space for consistency:- - name: Fix permissions for Symfony logs directory + - name: Fix permissions for Symfony logs directory🧰 Tools
🪛 YAMLlint (1.37.1)
[warning] 107-107: too many spaces after hyphen
(hyphens)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/ci_e2e-mysql.yaml(2 hunks).github/workflows/matrix.json(4 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/ci_e2e-mysql.yaml
[warning] 107-107: too many spaces after hyphen
(hyphens)
⏰ Context from checks skipped due to timeout of 90000ms (13)
- GitHub Check: End-to-end tests (MySQL) / JS with Panther, PHP 8.2, Symfony ^6.4 (test_cached), MySQL 8.0, Twig ^3.3
- GitHub Check: End-to-end tests (MySQL) / JS with Panther, PHP 8.3, Symfony ^7.2 (test_cached), MySQL 8.4, Twig ^3.3
- GitHub Check: End-to-end tests (MySQL) / Non-JS, PHP 8.3, Symfony ^7.2 (test_cached), MySQL 8.4, Twig ^3.3
- GitHub Check: End-to-end tests (MySQL) / Non-JS, PHP 8.2, Symfony ^6.4 (test_cached), MySQL 8.0, Twig ^3.3
- GitHub Check: End-to-end tests (MySQL) / JS with Chromedriver, PHP 8.2, Symfony ^6.4 (test_cached), MySQL 8.0, Twig ^3.3
- GitHub Check: End-to-end tests (MySQL) / JS with Chromedriver, PHP 8.3, Symfony ^7.2 (test_cached), MySQL 8.4, Twig ^3.3
- GitHub Check: Packages / PHP 8.3, Symfony ^7.2
- GitHub Check: Packages / PHP 8.2, Symfony ^6.4
- GitHub Check: End-to-end tests (MariaDB) / Non-JS, PHP 8.3, Symfony ^7.2, MariaDB 11.4.7, State Machine Adapter symfony_workflow
- GitHub Check: End-to-end tests (MariaDB) / Non-JS, PHP 8.2, Symfony ^6.4, MariaDB 10.11.13, State Machine Adapter winzou_state_machine
- GitHub Check: End-to-end tests (PostgreSQL) / Non-JS, PHP 8.3, Symfony ^7.2, PostgreSQL 17.5
- GitHub Check: End-to-end tests (PostgreSQL) / Non-JS, PHP 8.2, Symfony ^6.4, PostgreSQL 15.13
- GitHub Check: Frontend / NodeJS 20.x
🔇 Additional comments (11)
.github/workflows/matrix.json (10)
27-27: Bump minimal.e2e-mariadb MariaDB for Symfony ^7.2
Upgrading to MariaDB 11.4.7 aligns with the version matrix update. Looks good.
54-54: Bump minimal.e2e-pgsql PostgreSQL to 15.13
Updating Postgres to 15.13 is correct; please ensure the Docker image/tag exists in your CI environment.
59-59: Bump minimal.e2e-pgsql PostgreSQL to 17.5
The Postgres 17.5 tag is now tested for PHP 8.3/Symfony ^7.2. Looks consistent.
86-86: Expand Symfony versions in full.static-checks
Adding~7.2.0and~7.3.0to the static-checks matrix broadens compatibility testing. Confirm that your static analysis tools support these version constraints.
90-91: Restrict full.e2e-mariadb to a single MariaDB version
The full matrix now only tests MariaDB 11.4.7 across Symfony versions^6.4,~7.2.0, and~7.3.0. This simplification reduces matrix size while still covering key combinations.
96-97: Add winzou_state_machine for Symfony ~7.3.0 on PHP 8.3
Including thewinzou_state_machineadapter for the8.3/~7.3.0combo matches minimal changes. Ensure the adapter works as expected under this version matrix.
104-104: Expand Symfony versions in full.e2e-mysql
Aligns the MySQL e2e tests with the broader Symfony matrix by adding~7.2.0and~7.3.0. Looks correct.
110-111: Expand full.e2e-pgsql matrix
Upgraded the Postgres versions array and expanded Symfony versions for thorough testing. Please verify that Postgres16.9and17.5are available in your CI runners.
122-122: Expand Symfony versions in full.packages
Adding~7.2.0and~7.3.0to the packages matrix covers recent releases. No issues spotted.
20-22:Details
✅ Verification successful
Update minimal.e2e-mariadb to new MariaDB version and switch state machine adapter
The minimal matrix now uses MariaDB 10.11.13 and thewinzou_state_machineadapter for PHP 8.2/Symfony ^6.4. Ensure that thewinzou_state_machineintegration is supported in your CI startup scripts and that any adapter-specific configuration is adjusted accordingly.Please verify that all e2e-mariadb test jobs pick up the new adapter by running:
🏁 Script executed:
#!/bin/bash # Confirm state_machine_adapter is set to winzou_state_machine in the matrix rg -C2 '"state_machine_adapter": "winzou_state_machine"' .github/workflows/matrix.jsonLength of output: 367
Confirmed state_machine_adapter in all e2e-mariadb matrix entries
The grep output shows
"state_machine_adapter": "winzou_state_machine"under both the MariaDB 10.11.13 and 11.4.7 blocks in.github/workflows/matrix.json. All e2e-mariadb jobs are correctly using the new adapter. No further changes needed..github/workflows/ci_e2e-mysql.yaml (1)
132-132: Artifact naming corrected
The log upload name is now properly formatted, with the extraneous parenthesis removed. This change looks correct.
Summary by CodeRabbit