[CI] Update branches for full builds + refactor and upmerge actions#17887
[CI] Update branches for full builds + refactor and upmerge actions#17887TheMilek merged 3 commits intoSylius:2.1from
Conversation
WalkthroughThe changes update several GitHub Actions workflow files to adjust scheduled run times, update branch and version references, and modify job matrices. Specifically, the scheduled times for multiple CI workflows were shifted to earlier or later times, branch references were updated from older versions (such as 1.13) to newer ones (such as 2.1), and documentation links in workflow-generated pull requests were revised to point to the correct workflow files for the new branch versions. No changes were made to workflow logic or exported entities. Changes
Sequence Diagram(s)sequenceDiagram
participant Scheduler
participant GitHub Actions Workflow
Scheduler->>GitHub Actions Workflow: Trigger workflow at scheduled time (per updated cron)
GitHub Actions Workflow->>GitHub Actions Workflow: Run jobs for specified branch/version
GitHub Actions Workflow-->>Scheduler: Report status/results
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/ci__full_2_0.yaml (1)
6-6: Approve schedule update and concurrency alignment, but update inline comment.
The cron expression correctly shifts the run to 2:00 AM, aligning with the branch’s CI window. However, the inline comment still reads “Run every day at 3am”, which is now inaccurate.Consider updating the comment to:
cron: "0 2 * * *" # Run every day at 2am.github/workflows/ci__full_1_14.yaml (1)
6-6: Approve schedule change, but correct the inline comment time.
The cron schedule has been updated to “0 1 * * *” (1 AM), matching the intended CI timing. The existing comment “Run every day at 2am” is now outdated.Please update the comment to:
cron: "0 1 * * *" # Run every day at 1am
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.github/workflows/ci__full_1_14.yaml(1 hunks).github/workflows/ci__full_2_0.yaml(1 hunks).github/workflows/ci__full_2_1.yaml(6 hunks).github/workflows/refactor.yaml(2 hunks).github/workflows/upmerge_pr.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (14)
- GitHub Check: End-to-end tests (MySQL) / Non-JS, PHP 8.3, Symfony ^7.2 (test_cached), MySQL 8.4, Twig ^3.3
- GitHub Check: End-to-end tests (MySQL) / JS with Chromedriver, PHP 8.3, Symfony ^7.2 (test_cached), MySQL 8.4, Twig ^3.3
- GitHub Check: End-to-end tests (MySQL) / JS with Panther, PHP 8.3, Symfony ^7.2 (test_cached), MySQL 8.4, Twig ^3.3
- GitHub Check: End-to-end tests (MySQL) / Non-JS, PHP 8.2, Symfony ^6.4 (test_cached), MySQL 8.0, Twig ^3.3
- GitHub Check: End-to-end tests (MySQL) / JS with Chromedriver, PHP 8.2, Symfony ^6.4 (test_cached), MySQL 8.0, Twig ^3.3
- GitHub Check: End-to-end tests (MySQL) / JS with Panther, PHP 8.2, Symfony ^6.4 (test_cached), MySQL 8.0, Twig ^3.3
- GitHub Check: End-to-end tests (PostgreSQL) / Non-JS, PHP 8.3, Symfony ^7.2, PostgreSQL 16.4
- GitHub Check: End-to-end tests (PostgreSQL) / Non-JS, PHP 8.2, Symfony ^6.4, PostgreSQL 15.8
- GitHub Check: Frontend / NodeJS 20.x
- GitHub Check: Packages / PHP 8.3, Symfony ^7.2
- GitHub Check: Packages / PHP 8.2, Symfony ^6.4
- GitHub Check: End-to-end tests (MariaDB) / Non-JS, PHP 8.3, Symfony ^7.2, MariaDB 11.4.3, State Machine Adapter winzou_state_machine
- GitHub Check: End-to-end tests (MariaDB) / Non-JS, PHP 8.3, Symfony ^7.2, MariaDB 11.4.3, State Machine Adapter symfony_workflow
- GitHub Check: End-to-end tests (MariaDB) / Non-JS, PHP 8.2, Symfony ^6.4, MariaDB 10.11.9, State Machine Adapter symfony_workflow
🔇 Additional comments (7)
.github/workflows/upmerge_pr.yaml (1)
59-59: Approve PR body link update to reflect the new 2.1 branch.
The documentation link in the pull request body now correctly points to theupmerge_pr.yamlworkflow in the2.1branch. This change ensures users access the right version of the workflow file..github/workflows/ci__full_2_1.yaml (4)
1-1: Approve workflow name update.
The workflow name has been updated from “Continuous Integration 1.13 (Full)” to “Continuous Integration 2.1 (Full)”, accurately reflecting the new branch version for the full CI pipeline.
6-6: Approve cron schedule change.
The cron expression has been updated to run at 3:00 AM (0 3 * * *), matching the desired schedule for branch2.1.
10-11: Approve concurrency group identifier update.
The concurrency group now includes2_1-full, ensuring that only one full CI run per branch2.1is active at a time.
20-21: Approve branch matrix updates across jobs.
All job matrices have been updated to target branch2.1, ensuring consistency across static checks, end-to-end tests, and package workflows.Also applies to: 29-30, 39-40, 49-50, 66-67
.github/workflows/refactor.yaml (2)
33-36: Approve addition of branch2.1in the matrix.
The matrix now includes a2.1entry with PHP 8.2, aligning the coding-standard workflow with the new branch and PHP version strategy.
66-66: Approve PR body link update for refactor workflow.
The pull request description now correctly referencesrefactor.yamlin the2.1branch, ensuring accurate documentation.
✅ Preview Environment deployed on Bunnyshell
See: Environment Details | Pipeline Logs Available commands:
|
Summary by CodeRabbit