[New routing] Shop product review crud#18292
Merged
NoResponseMate merged 2 commits intoSylius:new-routingfrom Feb 9, 2026
Merged
[New routing] Shop product review crud#18292NoResponseMate merged 2 commits intoSylius:new-routingfrom
NoResponseMate merged 2 commits intoSylius:new-routingfrom
Conversation
Member
loic425
commented
Aug 1, 2025
| Q | A |
|---|---|
| Branch? | new-routing |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | partially #18212 |
| License | MIT |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
de5e045 to
4a020fa
Compare
❌ Preview Environment deleted from BunnyshellAvailable commands:
|
4a020fa to
c8d1e5d
Compare
loic425
commented
Aug 1, 2025
src/Sylius/Bundle/CoreBundle/ExpressionLanguage/ChannelContextVariables.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/ExpressionLanguage/CustomerContextVariables.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/ExpressionLanguage/LocaleContextVariables.php
Outdated
Show resolved
Hide resolved
6d50a61 to
3becbd9
Compare
diimpp
reviewed
Aug 5, 2025
src/Sylius/Bundle/CoreBundle/ExpressionLanguage/ShopperContextVariables.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/ExpressionLanguage/ShopperContextVariables.php
Outdated
Show resolved
Hide resolved
| $factory = $container->findDefinition('sylius.factory.' . $subject . '_review'); | ||
|
|
||
| $reviewFactoryDefinition = new Definition(ReviewFactory::class, [$factory]); | ||
| $reviewFactoryDefinition->addTag('sylius.resource_factory'); |
Member
There was a problem hiding this comment.
Should the same be done for AttributeFactory compiler pass?
Member
Author
There was a problem hiding this comment.
| use Sylius\Resource\Metadata\ResourceMetadata; | ||
|
|
||
| return (new ResourceMetadata()) | ||
| ->withRoutePrefix('/{_locale}/products/{slug}') |
Member
There was a problem hiding this comment.
Just out of curiosity, how do I remove {_locale} part from the url as end-user? It's a common case, that have a docs entry on how-to-do for previous routing.
Member
Author
There was a problem hiding this comment.
We'll handle this with the metadata mutators.
Sylius/SyliusResourceBundle#1055
3becbd9 to
6bc1b57
Compare
fde6308 to
179d7ea
Compare
6bc1b57 to
a45ff30
Compare
6073ebb to
c87c829
Compare
loic425
commented
Feb 4, 2026
src/Sylius/Bundle/ShopBundle/Resources/config/app/sylius/resources/product_review.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/Resources/config/app/sylius/resources/product_review.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/Resources/config/app/sylius/resources/product_review.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/Resources/config/app/sylius/resources/product_review.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/Resources/config/app/sylius/resources/product_review.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/Resources/config/app/sylius/resources/product_review.php
Outdated
Show resolved
Hide resolved
9135b73 to
623588a
Compare
This was referenced Feb 6, 2026
623588a to
dbf666e
Compare
NoResponseMate
approved these changes
Feb 9, 2026
NoResponseMate
added a commit
that referenced
this pull request
Feb 10, 2026
| Q | A |-----------------|----- | Branch? | new-routing | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | partially #18212 | License | MIT <!-- - Bug fixes must be submitted against the 1.14 or 2.1 branch - Features and deprecations must be submitted against the 2.2 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Based on #18292
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.